ABataev added a comment. In D71286#1777917 <https://reviews.llvm.org/D71286#1777917>, @bader wrote:
> In D71286#1777894 <https://reviews.llvm.org/D71286#1777894>, @ABataev wrote: > > > Most probably, just missed the testing of the frontend part here > > > Should I add test for both: SYCL and OpenMP? > What is the right place for this kind of tests: clang/test/Preprocessor/ or > clang/test/Frontend/? It would good but make in different patches. For OpenMP tests there is a directory clang/test/OpenMP. For SYCL, probably, clang/test/Frontend, since it is going to be a test for the frontend. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71286/new/ https://reviews.llvm.org/D71286 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
