[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

kadircet added inline comments. Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK: TypedefDecl=MyEnum:[[@LINE-1]]:3 (Definition) FullCommentAsHTML=[ Documentation for MyEnum ] FullCommentAsXML=[c:@EA@MyEnumtypedef enum MyEnum MyEnum Docu

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/Selection.cpp:162 + // Refs to operator() and [] are (almost?) always implicit as part of calls. + if (auto *DRE = ll

[PATCH] D69970: [CGDebugInfo] Emit subprograms for decls when AT_tail_call is understood (reland with fixes)

djtodoro added a comment. I think that it sounds reasonable to avoid declaration subprograms for functions with reserved names, so that part looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69970/new/ https://reviews.llvm.org/D69970 ___

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. In D69962#1744679 , @NoQ wrote: > In D69962#1742291 , @Szelethus wrote: > > > Try to add a non-sanitizer built tablegen: > > `-DCLANG_TABLEGEN=/path/to/non/sanitized/clang-tblgen` > > `-

[clang] 4873319 - [clang][IFS][test] Reverting driver-test.c to what it was prior to e782192d5e6

Author: Puyan Lotfi Date: 2019-11-14T03:39:16-05:00 New Revision: 4873319f973ba86c5d1226e87cdc3a7c085451bb URL: https://github.com/llvm/llvm-project/commit/4873319f973ba86c5d1226e87cdc3a7c085451bb DIFF: https://github.com/llvm/llvm-project/commit/4873319f973ba86c5d1226e87cdc3a7c085451bb.diff L

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229240. Tyker marked 6 inline comments as done. Tyker added a comment. fixed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229242. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 Files: clang-tools-extra/clang-tidy/abseil/StrCatAppendCheck.cpp clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-tools-extra/clang-ti

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2642-2643 + if (S->getLifetimeExtendedTemporaryDecl()) +TRY_TO(TraverseLifetimeExtendedTemporaryDecl( +S->getLifetimeExtendedTemporaryDecl())); +}) rsmith wrote: >

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. Ironically the LLVM style guide says enumerators should be written out as you requested, but from what I can tell its not actually possible to get that format without this sort of change, do you agree? F10735507: image.png R

[PATCH] D70188: [ARM,MVE] Add intrinsics for vector get/set lane.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70188/new/ https://reviews.llvm.org/D70188

[PATCH] D70225: [clangd] Simplify the code in XRefs

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. While here, also fix potential UB in MergeIndex. Thanks Kadir for finding this! Repository: rG LLVM Github Mon

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 added a comment. I don't know much about how to write unit tests, but it works fine on my computer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 ___ c

[PATCH] D70225: [clangd] Simplify the code in XRefs

merge_guards_bot added a comment. Build result: pass - 60074 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70183: Detect source location overflow due includes

dnsampaio updated this revision to Diff 229254. dnsampaio marked an inline comment as done. dnsampaio added a comment. - Return an invalid FileID instead of exiting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } miyuki wrote: > dnsampaio wrote: > > miyuki wrote: > > > d

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones added a comment. Okay. I'll see if I can find a way to test this when `CLANG_DEFAULT_RTLIB` is set, and then I'll resubmit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 ___

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

SjoerdMeijer updated this revision to Diff 229255. SjoerdMeijer added a comment. Thanks again for the suggestion; this indeed (hopefully) looks a lot neater now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69628/new/ https://reviews.llvm.org/D69628 Files: clang/lib/CodeGen/CGLoopIn

[PATCH] D70041: register cuda language activation event and activate for .cuh files

hokein added a comment. Thanks for the patch. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file'

[PATCH] D70225: [clangd] Simplify the code in XRefs

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, the title is a bit confusing, the modified code is about the index, not XRefs. Comment at: clang-tools-extra/clangd/index/Merge.cpp:116 // files. - More |= Stati

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69707/new/ https://reviews.llvm.org/D69707 ___ cfe-commits mailing lis

[PATCH] D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI

miyuki added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69840/new/ https://reviews.llvm.org/D69840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7848fd8f7b5: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske updated this revision to Diff 229268. balazske added a comment. - Simplified the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.llvm.org/D69948 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel updated this revision to Diff 229269. anwel added a comment. Rebase on current llvm-project master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/DiagnosticDriv

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske marked 5 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:189-190 + // Check if error was generated. + if (C.isDifferent()) +return; + NoQ wrote: > That's actually one more goo

[PATCH] D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd83d9ff5c90: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D69800?vs=227688&id=229276#toc Reposit

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 229273. edward-jones added a comment. It seems that the option `--rtlib=platform` exists to force the driver to ignore the `-DCLANG_DEFAULT_RTLIB` for testing purposes, so I've added this option to the tests that were broken. These tests now seem to pa

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

edward-jones added a comment. If I set `-DCLANG_DEFAULT_RTLIB=compiler-rt` I see the following failure in `clang/test/Driver/cross-linux.c`: /home/ed/work/proj/riscv-testing/llvm/clang/test/Driver/cross-linux.c:62:26: error: CHECK-MULTI32-X86-64: expected string not found in input // CHECK-

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

hokein added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.h:29 std::vector Ranges; + llvm::DenseMap> MacroRefs; }; usaxena95 wrote: > hokein wrote: > > I think the `Ranges` and `MacrosRefs` have a lot of duplications, it is > > wastef

[clang] 7e6294c - Modernize llvm::Error handling in ExternalASTMerger

Author: Raphael Isemann Date: 2019-11-14T13:58:32+01:00 New Revision: 7e6294c056838683f43670c8390ef13df6657e57 URL: https://github.com/llvm/llvm-project/commit/7e6294c056838683f43670c8390ef13df6657e57 DIFF: https://github.com/llvm/llvm-project/commit/7e6294c056838683f43670c8390ef13df6657e57.dif

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

alexfh added a comment. While I have no objections against this patch, I wonder whether someone had a chance to ask GCC developers about this? Is it a conscious choice to suggest `override` when `final` is present? What's the argument for doing so? Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. we have a few places using `ASTCtx.getLangOpts().IsHeaderFile` to determine a header file, but it relies on "-

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

malcolm.parsons added a reviewer: alexfh. malcolm.parsons added a comment. Should `clang::format::cleanupAroundReplacements()` handle this instead? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70144/new/ https://reviews.llvm.org/D70144 _

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 229284. edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation detected". edward-jones added a comment. Added tests that a user can specify a specific ru

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. This doesn't cover decls in diagnostics, which use NamedDecl::getNameForDiagnostic(). (That should als

[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60058 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

JonasToth added a comment. In D70144#1745532 , @malcolm.parsons wrote: > Should `clang::format::cleanupAroundReplacements()` handle this instead? Of yes. Totally forgot that. That would probably the most elegant way :) Repository: rCTE Clang Tools E

[clang-tools-extra] 5a9547b - [clangd] Simplify the code in Index::refs

Author: Ilya Biryukov Date: 2019-11-14T14:43:29+01:00 New Revision: 5a9547b007090cf9c082ac84490310ee26d8b338 URL: https://github.com/llvm/llvm-project/commit/5a9547b007090cf9c082ac84490310ee26d8b338 DIFF: https://github.com/llvm/llvm-project/commit/5a9547b007090cf9c082ac84490310ee26d8b338.diff

[PATCH] D70225: [clangd] Simplify the code in XRefs

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Merge.cpp:116 // files. - More |= Static->refs(Req, [&](const Ref &O) { if (DynamicIndexFileURIs.count(O.Location.FileURI)) ho

[PATCH] D70225: [clangd] Simplify the code in XRefs

This revision was automatically updated to reflect the committed changes. ilya-biryukov marked an inline comment as done. Closed by commit rG5a9547b00709: [clangd] Simplify the code in Index::refs (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGf9dd03b135d7: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

merge_guards_bot added a comment. Build result: pass - 60015 tests passed, 0 failed and 722 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70235: [clangd] Add isHeaderFile helper.

sammccall added a comment. As discussed offline, we still want to respect the langopts signal, but we also want to treat *.h as a header if it's not present. So the function needs to take filename and langopts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

martong added a comment. Ping @shafik @balazske Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

anwel updated this revision to Diff 229296. anwel added a comment. Change clang's error message when trying to use the target's frame pointer as GRV to sound more like an error then a warning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 Fil

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo updated this revision to Diff 229298. koalo added a comment. Rebased to current master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

koalo added a comment. Yes, that is at least my understanding. I just rebased to master. In my understanding, "short" means "put it on a single line if it fits considering the current maximum line length". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.o

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:984 }}, + {R"cpp(enum Color { RED, [[GR^EEN]], };)cpp", + [](HoverInfo &HI) { kadircet wrote: > could you

[PATCH] D70235: [clangd] Add isHeaderFile helper.

hokein updated this revision to Diff 229300. hokein added a comment. take langOpts into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70235/new/ https://reviews.llvm.org/D70235 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tool

[PATCH] D70235: [clangd] Add isHeaderFile helper.

merge_guards_bot added a comment. Build result: pass - 60058 tests passed, 0 failed and 729 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D70242: [OpenCL] Allow addr space qualifiers on lambda call expressions

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added subscribers: ebevhan, yaxunl. Anastasia edited the summary of this revision. The addr space qualifier can be added optionally for lambdas after the attributes. They will alter the default address space of lambda c

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 marked 7 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:898 + // Handle macros. + if (auto Macro = locateMacroAt(Loc, AST.getPreprocessor())) { +if (auto MacroSID = getSymbolID(Macro->Name, Macro->Info, SM)

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a subscriber: mitchell-stellar. MyDeveloperDay added a comment. Thanks for rebasing, I think this is a good idea I'm just not sure about how the option presents itself, would you consider changing it? Comment at: clang/lib/Format/TokenAnnotator.cpp:3109

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1742354 , @rjmccall wrote: > In D69938#1742026 , @Anastasia wrote: > > > In D69938#1741713 , @rjmccall > > wrote: > > > > > In D69938#17

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. In D54628#1745645 , @koalo wrote: > Yes, that is at least my understanding. I just rebased to master. > > In my understanding, "short" means "put it on a single line if it fits > considering the current maximum line length"

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia updated this revision to Diff 229308. Anastasia added a comment. - Added pointer to lambda test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69938/new/ https://reviews.llvm.org/D69938 Files: clang/lib/Sema/SemaLambda.cpp clang/lib/Sema/SemaType.cpp clang/test/Sem

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383

[PATCH] D70157: Align branches within 32-Byte boundary

tstellar added a comment. Are there any optimizations in lld that might undo the 32-byte alignment emitted by the compiler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 ___

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

asb accepted this revision. asb added a comment. Please update the commit message to clarify the cases where we do deviate from the GCC defaults, but this looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.l

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

hokein added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:642 DeclPrinter TArgPrinter(POut, SubPolicy, Context, Indentation); -TArgPrinter.printTemplateArguments(*TArgs); +if (const auto *TArgInfo = D->getTemplateSpecializationArgsAsWritten()) + TA

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a comment. In D69938#1745737 , @Anastasia wrote: > In D69938#1742354 , @rjmccall wrote: > > > In D69938#1742026 , @Anastasia > > wrote: > > > > > In D69938#17

[PATCH] D19031: clang-format: Flexible line endings

MyDeveloperDay added a comment. Sorry I'm reviewing very old revisions, @mxbOctasic are you still interested in a patch like this? > It's not clang-format's task to clean up files with mixed line endings This is an interesting thought given that clang-format does exactly that based on how many

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:2020-2034 if (!FirstClause) { Diag(Tok, diag::err_omp_more_one_clause) << getOpenMPDirectiveName(DKind) << getOpenMPClauseName(CKind) << 0; ErrorFound = true; } +Clau

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: s.egerton, guansong, simoncook, fedor.sergeev, aheejin, rampitec. Herald added a project: clang. Added basic parsing/sema support for device/kind context selector. Repository: rG LLVM Github Monorepo

[PATCH] D70244: [Analyzer] Iterator Checkers: Replace `UnknownVal` in comparison result by a conjured value

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Sometimes the return value of a comparison

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added a comment. Thanks, the tests look great. Comment at: clang/include/clang/Basic/AttrDocs.td:3919 +in particular, this means that it cannot override a superclass method or satisfy +a protocol requirement. + Please add a new paragraph here: Beca

[PATCH] D70203: [AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well as A.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/test/Index/annotate-comments-typedef.m:20 } MyEnum; -// CHECK: TypedefDecl=MyEnum:[[@LINE-1]]:3 (Definition) FullCommentAsHTML=[ Documentation for MyEnum ] FullCommentAsXML=[

[clang-tools-extra] 37abeed - [clangd] Expose value of enumerators to Hover API. (not UI yet)

Author: Sam McCall Date: 2019-11-14T17:26:59+01:00 New Revision: 37abeed8145b5faf02ca9ae3ffedf46b52947f41 URL: https://github.com/llvm/llvm-project/commit/37abeed8145b5faf02ca9ae3ffedf46b52947f41 DIFF: https://github.com/llvm/llvm-project/commit/37abeed8145b5faf02ca9ae3ffedf46b52947f41.diff LO

[PATCH] D70209: [clangd] Expose value of enumerators to Hover API. (not UI yet)

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG37abeed8145b: [clangd] Expose value of enumerators to Hover API. (not UI yet) (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D7020

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

sammccall updated this revision to Diff 229317. sammccall marked 3 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70236/new/ https://reviews.llvm.org/D70236 Files: clang-tools-e

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

mitchell-stellar added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3109 return Right.HasUnescapedNewline; + if (isAllmanBrace(Left) && !Style.AllowShortEnumsOnASingleLine && + (Line.startsWith(tok::kw_enum) || MyDeveloperDay wrote:

[clang-tools-extra] bbcbb10 - [clangd] Ignore more implicit nodes in computing selection.

Author: Sam McCall Date: 2019-11-14T17:35:00+01:00 New Revision: bbcbb10e2d0848b611c51b1ff56c758645c55f3b URL: https://github.com/llvm/llvm-project/commit/bbcbb10e2d0848b611c51b1ff56c758645c55f3b DIFF: https://github.com/llvm/llvm-project/commit/bbcbb10e2d0848b611c51b1ff56c758645c55f3b.diff LO

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. ok sounds good, @koalo do you have the tests to ensure AfterEnum=true and AllowShortEnumsOnASingleIne=true show on a single line? otherwise perhaps we are already good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D5

[PATCH] D70236: [AST] Use written names instead of `type-param-0-0` in more cases when printing types and decls.

merge_guards_bot added a comment. Build result: pass - 60015 tests passed, 0 failed and 722 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D54628: Extend format with AllowShortEnumsOnASingleLine option

MyDeveloperDay added a comment. Nit: you should use a full context diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54628/new/ https://reviews.llvm.org/D54628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D70194: [clangd] Ignore more implicit nodes in computing selection.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbcbb10e2d08: [clangd] Ignore more implicit nodes in computing selection. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70194?vs=229141&id=229319#toc Repository: rG LLVM

[clang] 1275ab1 - Improve VFS compatibility on Windows

Author: Adrian McCarthy Date: 2019-11-14T08:48:47-08:00 New Revision: 1275ab1620b665eb06231ce3c4e5068c97d9b618 URL: https://github.com/llvm/llvm-project/commit/1275ab1620b665eb06231ce3c4e5068c97d9b618 DIFF: https://github.com/llvm/llvm-project/commit/1275ab1620b665eb06231ce3c4e5068c97d9b618.dif

[PATCH] D19031: [clang-format] Flexible line endings

cameron314 added a comment. @MyDeveloperDay: @mxbOctasic has moved on but I'm still maintaining this patch upstream, so I'm still interested in having it merged if possible. The advantage of having two options is that a default line ending can still be specified when none can be derived (this i

[PATCH] D69958: Improve VFS compatibility on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG1275ab1620b6: Improve VFS compatibility on Windows (authored by amccarth). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69958

[clang] c9de002 - [AMDGPU][HIP] Change default DWARF version to 4

Author: Scott Linder Date: 2019-11-14T11:51:11-05:00 New Revision: c9de002a2cf02b1a00abe5caaa05fd722583218a URL: https://github.com/llvm/llvm-project/commit/c9de002a2cf02b1a00abe5caaa05fd722583218a DIFF: https://github.com/llvm/llvm-project/commit/c9de002a2cf02b1a00abe5caaa05fd722583218a.diff

[PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

Meinersbur added a comment. Could you elaborate why this is better than `__builtin_assume_aligned`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69897/new/ https://reviews.llvm.org/D69897 ___ cfe-comm

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

poelmanc added a comment. In D70144#1745583 , @JonasToth wrote: > In D70144#1745532 , @malcolm.parsons > wrote: > > > Should `clang::format::cleanupAroundReplacements()` handle this instead? > > > Of yes. Totally f

[PATCH] D70191: [AMDGPU][HIP] Change default DWARF version to 4

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9de002a2cf0: [AMDGPU][HIP] Change default DWARF version to 4 (authored by scott.linder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70191/new/ https://r

[PATCH] D68578: [HIP] Fix device stub name

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1099-1108 +auto *FD = const_cast((ND)); +if (auto *TD = cast(FD)->getPrimaryTemplate()) + FD = TD->getTemplatedDecl(); +auto OldDeclName = FD->g

[PATCH] D70249: [clang-format] Fixed edge-case with `Style.SpacesInSquareBrackets` with trailing bare `&` lambda capture

mitchell-stellar created this revision. mitchell-stellar added a reviewer: MyDeveloperDay. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lambda captures allow for a lone `&` capture, so `&]` needs to be properly handled. R

[PATCH] D68578: [HIP] Fix device stub name

tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1099-1108 +auto *FD = const_cast((ND)); +if (auto *TD = cast(FD)->getPrimaryTemplate()) + FD = TD->getTemplatedDecl(); +auto OldDeclName = FD->getDeclName(); +auto NewNameStr = std::st

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

aganea updated this revision to Diff 229333. aganea marked an inline comment as done. aganea added a comment. Call into `ExecuteCC1Tool()` directly, as suggested by @hans Add more comments. Remove `pThis` in `CrashRecoveryContext.cpp:RunSafely()` as suggested by @zturner CHANGES SINCE LAST ACTI

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

aaron.ballman added a comment. Why did this get committed when there were still outstanding review questions that were not answered? In D69759#1739935 , @yonghong-song wrote: > Regarding to this one "This is missing a bunch of C++ tests that show what

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:2953-2954 +(!(isOpenMPTargetExecutionDirective(DKind) && Res && + (*Res == OMPDeclareTargetDeclAttr::MT_Link || +*Res == OMPDeclareTargetDeclAttr::MT_To { +

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added a comment. I would suggest to split this patch into 2 part: the first one is NFC and just makes the ompiler to use the new interfaces and the second with the new functionality for mappers. Comment at: include/clang/AST/OpenMPClause.h:4298 + /// use_device_ptr a

[PATCH] D70172: [CUDA][HIP] Fix assertion due to dtor check on windows

rnk added a comment. Are we sure using both Itanium and MS C++ ABIs at the same time is really the best way forward here? What are the constraints on CUDA that require the Itanium ABI? I'm sure there are real reasons you can't just use the MS ABI as is, but I'm curious what they are. Was there

[clang] 399e29d - [OPENMP]Add assignment operator in UDR test, NFC.

Author: Alexey Bataev Date: 2019-11-14T13:01:16-05:00 New Revision: 399e29ddc600a2d91e08e7029e7dade3581c9820 URL: https://github.com/llvm/llvm-project/commit/399e29ddc600a2d91e08e7029e7dade3581c9820 DIFF: https://github.com/llvm/llvm-project/commit/399e29ddc600a2d91e08e7029e7dade3581c9820.diff

[clang-tools-extra] e2369fd - [clang-include-fixer] Skip .rc files when finding symbols

Author: Reid Kleckner Date: 2019-11-14T10:04:35-08:00 New Revision: e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 URL: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 DIFF: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691.diff

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

dexonsmith added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:25 + // CHECK-NEXT: store %0* %self, %0** %self.addr, + // CHECK-NEXT: store i8* %_cmd, i8** %_cmd.addr, + rjmccall wrote: > The IR names of local values aren't emitted in rele

[PATCH] D70249: [clang-format] Fixed edge-case with `Style.SpacesInSquareBrackets` with trailing bare `&` lambda capture

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70249/new/ https://reviews.llvm.org/D70249 __

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:92 + // *not* load itself automatically on '.cu' and '.cuh' files. + const cudaFilePatterns: {scheme: string, pattern: string}[] = [ +{scheme : 'file', pattern : '**/*

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

rnk added a comment. This is a single .rc entry: { "directory": "C:/src/llvm-project/build", "command": "C:\\PROGRA~2\\WI3CF2~1\\10\\bin\\100183~1.0\\x64\\rc.exe -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_ DEPRECATE -D_CRT_SE

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2369fd197d9: [clang-include-fixer] Skip .rc files when finding symbols (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70196/new/ https://

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr. Herald added subscribers: hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds the following intrinsics: - faddp - fmaxp, fminp, fmaxnmp & fminnmp - fmlalb, fmlalt, fmlslb & fmlslt - flo

  1   2   >