ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added inline comments.
================
Comment at: clang-tools-extra/clangd/index/Merge.cpp:116
// files.
- More |= Static->refs(Req, [&](const Ref &O) {
if (DynamicIndexFileURIs.count(O.Location.FileURI))
----------------
hokein wrote:
> I assume the potential UB is this code?
Yes, exactly. I believe it's not UB after C++17 or C++20.
However, mutating `More` inside the assignment to `More` definitely makes the
reader pause, we'd rather avoid it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70225/new/
https://reviews.llvm.org/D70225
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
