dexonsmith added inline comments.

================
Comment at: clang/test/CodeGenObjC/direct-method.m:25
+  // CHECK-NEXT: store %0* %self, %0** %self.addr,
+  // CHECK-NEXT: store i8* %_cmd, i8** %_cmd.addr,
+
----------------
rjmccall wrote:
> The IR names of local values aren't emitted in release builds of the 
> compiler, so you need to use FileCheck variables for these allocas the same 
> way that you do for RETVAL and SELF.
That’s worth double-checking.  I think that has been fixed, such that whether 
names are dropped is controlled by a cc1 flag (which the driver sets by default 
in release builds).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69991/new/

https://reviews.llvm.org/D69991



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to