[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1347 Contexts.back().CanBeExpression = false; -} else if (Current.isOneOf(tok::semi, tok::exclaim)) { +} else if (Current.isOneOf(

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak created this revision. llunak added reviewers: ABataev, rsmith, dblaikie. llunak added projects: clang, OpenMP. Herald added a reviewer: jdoerfert. Herald added a subscriber: cfe-commits. This patch makes template instantiations be already performed in the PCH instead of it being done in e

[PATCH] D64284: (WIP) share template instantiations from PCH in one .o if -building-pch-with-obj

llunak abandoned this revision. llunak added a comment. Due to some technical problems with this approach and lack of feedback, I'm scratching this one. A new approach is at https://reviews.llvm.org/D69585 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64284/new

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

poelmanc marked 2 inline comments as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:67-70 +// With -std c++14 or earlier (!LangOps.CPlusPlus17), it was sufficient to +// return CtorExpr->getSourceRange(). H

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 59446 tests passed, 1 failed and 764 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp Log files: console-log.txt

Re: [clang] bd87916 - [clang] Add no_builtin attribute

Yup, I didn't follow up to this email but we talked on gchat and sorted it out. On Tue, Oct 29, 2019 at 2:20 PM Vitaly Buka wrote: > Ignoring "slave lost exception" bots are green for a while > http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast?numbuilds=100 > > http://lab.llvm.org:80

Re: [clang] bd87916 - [clang] Add no_builtin attribute

Ignoring "slave lost exception" bots are green for a while http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast?numbuilds=100 http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap?numbuilds=100 Vlads report was done when bots were on staging master :8014 for github migration.

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

beanz added a comment. `LLVM_NO_DEAD_STRIP` isn't actually useful only for when plugins are enabled. It is also useful in a lot of contexts around building JIT host processes. The advantage of the old name was it specified exactly what it did (i.e. not dead strip code). It seems to me that may

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

NoQ added a comment. I suspect that with this check by choosing path-sensitivity you gain less than you lose. That is, checking how the array pointer is passed around may be nice, but if you sacrificed that, you could have turned this check into a compiler warning which would have had an effect

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226972. Bigcheese set the repository for this revision to rG LLVM Github Monorepo. Bigcheese added a comment. This fixes some issues I received externally. - Fix issue with MSVC getting confused about `ModuleDeps::ModuleDeps`. - Always generate absolute pat

[PATCH] D69582: Let clang driver support parallel jobs

tra added a reviewer: echristo. tra added a subscriber: echristo. tra added a comment. @echristo Eric, any thoughts/concerns on the overall direction for the driver? @yaxunl One concern I have is diagnostics. When the jobs are executed in parallel, I assume all of them will go to the standard er

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. I haven't reviewed the list [1] properly so I don't know the number of false positives yet. [1] http://paste.debian.net/806/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 __

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:42 +BugType & +SufficientSizeArrayIndexingChecker::GetBugTypeForType(const QualType T) const { + auto BT = BugTypeCache.find(T); The whole point of b

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese updated this revision to Diff 226974. Bigcheese added a comment. I forgot to clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 Files: clang/include/clang/Tooling/DependencyScanning/D

[clang] eb535d2 - Accept __is_same_as as a GCC-compatibility synonym for the proper trait name __is_same.

Author: Richard Smith Date: 2019-10-29T14:44:38-07:00 New Revision: eb535d23418c7259cac85bdb13197263b2cee056 URL: https://github.com/llvm/llvm-project/commit/eb535d23418c7259cac85bdb13197263b2cee056 DIFF: https://github.com/llvm/llvm-project/commit/eb535d23418c7259cac85bdb13197263b2cee056.diff

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

lhames added subscribers: beanz, lhames. lhames added a comment. In D69356#1726074 , @beanz wrote: > ... It seems to me that maybe a more appropriate approach is that > `LLVM_SUPPORT_PLUGINS` implies `LLVM_NO_DEAD_STRIP`, rather than conflating > the two

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8410 + "'std::is_constant_evaluated' will always evaluate to " + "'true' in constexpr mode">, InGroup; def warn_comparison_bitwise_always : Warning< "constexpr mode" isn

[clang] 98286b5 - [Headers] Fix compatibility between arm_acle.h and intrin.h

Author: Eli Friedman Date: 2019-10-29T14:52:56-07:00 New Revision: 98286b569d01a461d75c9fd133cbf52c0c92e32a URL: https://github.com/llvm/llvm-project/commit/98286b569d01a461d75c9fd133cbf52c0c92e32a DIFF: https://github.com/llvm/llvm-project/commit/98286b569d01a461d75c9fd133cbf52c0c92e32a.diff

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese requested changes to this revision. Bigcheese added a comment. This revision now requires changes to proceed. So I agree solving this problem makes sense, but I have some issues with the current patch. - This defaults to doing the lookup. The test suite, and some real outputs, just us

[clang] dbcb690 - Replace std::function in PrintingPolicy with a callbacks object.

Author: Richard Smith Date: 2019-10-29T15:29:44-07:00 New Revision: dbcb690fb78193e99452748c4af72eccb262e4e2 URL: https://github.com/llvm/llvm-project/commit/dbcb690fb78193e99452748c4af72eccb262e4e2 DIFF: https://github.com/llvm/llvm-project/commit/dbcb690fb78193e99452748c4af72eccb262e4e2.diff

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:896 + if (S.CanPerformCopyInitialization(Entity, &AsRvalue)) +return true; +} else if (auto *FTD = dyn_cast(D)) { Overlad resolution can actually still fail if there

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 226980. aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Add test case where check for non-deduced parameter conversions is necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

jrtc27 created this revision. jrtc27 added a reviewer: asb. Herald added subscribers: cfe-commits, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, apa

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc updated this revision to Diff 226987. poelmanc added a comment. Added release notes, fixed backticks in documentation, removed blank line, removed new hasListedName matcher and used existing hasAnyName matcher. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://r

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8410 + "'std::is_constant_evaluated' will always evaluate to " + "'true' in constexpr mode">, InGroup; def warn_comparison_bitwise_always : W

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc marked 3 inline comments as done. poelmanc added a comment. @aaron.ballman Thanks for the `hasAnyName` feedback! From the name `internal::VariadicFunction` I assumed arguments were needed at compile-time, but thanks to your suggestion I found the overload taking `ArrayRef`. Repository

[PATCH] D69548: Give clang-tidy readability-redundant-string-init a customizable list of string types to fix

poelmanc marked an inline comment as done. poelmanc added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/RedundantStringInitCheck.cpp:21 +const char DefaultStringNames[] = "basic_string"; + aaron.ballman wrote: > I think the default shou

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:196 if (ExplodedNode *N = C.generateNonFatalErrorNode(state)) { if (!BT_illegalwhence) This is getting pretty messy, given that you've already made a transition i

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/MangleNumberingContext.h:57-58 + + /// Has device mangle numbering context. + virtual bool hasDeviceMangleNumberingContext() const { return false; } + It would be nicer if there were a single entry

[clang] ae3159e - Thread safety analysis: Peel away NoOp implicit casts in initializers

Author: Aaron Puchert Date: 2019-10-30T00:37:32+01:00 New Revision: ae3159e497934ed1320d20aab8b32e3bf00a8f10 URL: https://github.com/llvm/llvm-project/commit/ae3159e497934ed1320d20aab8b32e3bf00a8f10 DIFF: https://github.com/llvm/llvm-project/commit/ae3159e497934ed1320d20aab8b32e3bf00a8f10.diff

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1253-1255 + MemRegionManager(ASTContext &c, llvm::BumpPtrAllocator &a, SValBuilder &SVB, + SymbolManager &SymMgr) + : Ctx(c), A(a), SVB(SVB), SymMgr(S

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

NoQ added a comment. In D68725#1724213 , @Charusso wrote: > In D68725#1722136 , @NoQ wrote: > > > Even if `AllocaRegion` didn't store the expression, any path-sensitive > > checker for which such region is "interes

[clang] 07ee46d - [MS] Fix constexpr data member pointer conversions

Author: Reid Kleckner Date: 2019-10-29T16:58:00-07:00 New Revision: 07ee46d613d7c1862878d7c7d1208a7b3e37459d URL: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d DIFF: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d.diff

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

Charusso abandoned this revision. Charusso added a comment. In D68725#1726332 , @NoQ wrote: > But i believe that we already have enough concepts and tools here, there's no > need to introduce more of them. F10581160: image.png

[PATCH] D68725: [analyzer] MemoryBlockRegion: Generalize AllocaRegion

Charusso added a comment. In D68725#1726332 , @NoQ wrote: > I don't particularly love `SymbolMetadata` because i believe it should be > associated with symbols [...] That is why I secretly wanted to get rid of that concept, but I am fine with using a g

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1726121 , @lhames wrote: > In D69356#1726074 , @beanz wrote: > > > ... It seems to me that maybe a more appropriate approach is that > > `LLVM_SUPPORT_PLUGINS` impl

[clang] cbb3104 - Suppress useless GCC "bitfield is too small to hold all values of enum class" warning.

Author: Richard Smith Date: 2019-10-29T17:20:46-07:00 New Revision: cbb3104b1c8ea93b6749043184a8d8952b8b2747 URL: https://github.com/llvm/llvm-project/commit/cbb3104b1c8ea93b6749043184a8d8952b8b2747 DIFF: https://github.com/llvm/llvm-project/commit/cbb3104b1c8ea93b6749043184a8d8952b8b2747.diff

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

On Mon, Oct 28, 2019 at 4:42 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If the intended behavior is to show the crash at the call site like >> LangRef in the patch suggest then line 0 will certainly not achieve that. I >> implicitly assumed the wording in LangRef would

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

beanz added a comment. In D69356#1726336 , @hubert.reinterpretcast wrote: > Is there some documentation indicating these other use cases? If you have JIT'd code that needs to link against functions exposed in the process running the JIT you can't dead

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. Ping: is fixed, this is now good to go. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D69012: [Headers] Fix compatibility between arm_acle.h and intrin.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG98286b569d01: [Headers] Fix compatibility between arm_acle.h and intrin.h (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D69012?vs=225130&id=226999#toc Repository: rG LLVM

[PATCH] D69215: [DWARF5] Added support for deleted C++ special member functions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf919be336583: [DWARF5] Added support for deleted C++ special member functions. (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new

[PATCH] D69533: Thread safety analysis: Peel away NoOp implicit casts in initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rGae3159e49793: Thread safety analysis: Peel away NoOp implicit casts in initializers (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + And if you want to allow your code to build with both clang-9 and clang-10, you have to

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso updated this revision to Diff 227006. Charusso marked 12 inline comments as done. Charusso added a comment. - Fix. - Added a `FIXME` about the missing symbol of `BlockDataRegion`, `BlockCodeRegion` and `FunctionCodeRegion`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69540/ne

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso added a comment. Thanks for the review! I am not sure why but after your review I always see the most appropriate design immediately. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1253-1255 + MemRegionManager(ASTContext &c, llvm::Bump

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:158 // symbols to use, only content metadata. - return nonloc::SymbolVal(SymMgr.getExtentSymbol(FTR)); + return FTR->getMemRegionManager().getStatic

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > And if you want to allow your c

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

rsmith added a comment. In D63960#1712398 , @Tyker wrote: > The now that constexpr destructors are legal. The code in this patch need to > be adapted, I have question about the following code. > > struct A { > constexpr ~A() {} > }; > > conste

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso updated this revision to Diff 227013. Charusso marked 2 inline comments as done. Charusso added a comment. - Unpack the issue-solving about code regions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69540/new/ https://reviews.llvm.org/D69540 Files: clang/include/clang/Stati

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

arphaman accepted this revision. arphaman added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:43 + +class ModuleDepCollectorPP final : public PPCallbacks { +public: --

[PATCH] D69540: [analyzer] DynamicSize: Remove 'getExtent()' from regions

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:158 // symbols to use, only content metadata. - return nonloc::SymbolVal(SymMgr.getExtentSymbol(FTR)); + return FTR->getMemRegionManager().getS

[PATCH] D69598: WIP: Work on cleaning up denormal mode handling

arsenm created this revision. arsenm added reviewers: scanon, andrew.w.kaylor, cameron.mcinally, spatel, RKSimon, olista01, SjoerdMeijer. Herald added subscribers: dexonsmith, hiraditya, tpr, mgorny, wdng. Herald added a project: LLVM. Cleanup handling of the denormal-fp-math attribute. Consolida

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This patch uses the new `DynamicSize.cpp` to serve dynamic info

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8410 + "'std::is_constant_evaluated' will always evaluate to " + "'true' in constexpr mode">, InGroup; def warn_comparison_bitwise_always : Warning< xbolva00 wrote: > rs

[PATCH] D69599: [analyzer] DynamicSize: Remove 'getSizeInElements()' from store

Charusso added a comment. The [1] patch which introduced such static element-count data has only one test case in `outofbound.c`: void f2() { int *p = malloc(12); p[3] = 4; // expected-warning{{Access out-of-bound array element (buffer overflow)}} } which probably wanted to be `(in

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + rsmith wrote: > efriedma wrote: > > And if you want to allow your code to build with bot

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

NoQ added inline comments. Comment at: cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:295-297 + OS << "Null pointer argument in call to " << CurrentFunctionDescription + << ' ' << IdxOfArg << llvm::getOrdinalSuffix(IdxOfArg) + << " parameter"; -

[PATCH] D66333: [analyzer] NonNullParamChecker and CStringChecker parameter number in checker message

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1548 - state = checkNonNull(C, state, Dst, DstVal); + state = checkNonNull(C, state, Dst, DstVal, 1); if (!state) bruntib wrote: > NoQ wrote: > > You could als

[PATCH] D69602: [analyzer] Test case for lambda capture by value modelling

gamesh411 created this revision. gamesh411 added reviewers: NoQ, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. This test provides test coverage

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

hubert.reinterpretcast added a comment. In D69356#1726354 , @beanz wrote: > Can you please explain how the "no dead strip" semantic is harmful for > plug-in support, and how implying no dead strip for plugins is any different > from the current implement

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

lichray added a comment. Should we find a way to set `->`'s type to `TT_TrailingReturnArrow`? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69577/new/ https://reviews.llvm.org/D69577 ___ cfe-commits mailing list cfe-

<    1   2