NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:196
if (ExplodedNode *N = C.generateNonFatalErrorNode(state)) {
if (!BT_illegalwhence)
----------------
This is getting pretty messy, given that you've already made a transition in
this function. If you do `addTransition` and then `generateNonFatalErrorNode`,
then you'll get two parallel successor nodes, but you only need one. You should
either delay the transition that happens immediately after `CheckNullStream`,
or chain the two transitions together sequentially (as opposed to in parallel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67706/new/
https://reviews.llvm.org/D67706
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
