[PATCH] D68663: [clang-offload-bundler] Support `.cui` and `.d`.

tra added a comment. Maybe, add a TODO to eventually remove `.d` . `.cui` should probably remain as it's yet another variant of preprocessed output that we allow bundling for C/C++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68663/new/ https:/

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

mibintc updated this revision to Diff 223940. mibintc added a comment. I added a test case to show the warning diagnostics when options conflicting with fp-model are provided. I fixed a couple bugs in RenderFloatingPointOptions when issueing diagnostics. still owe a test case showing how the fp

[PATCH] D68652: [driver][hip] Skip bundler if host action is nothing.

tra added inline comments. Comment at: clang/test/Driver/hip-syntax-only.hip:7 + +// CHECK-DAG: clang{{.*}}" "-cc1" {{.*}} "-fcuda-is-device" +// CHECK-DAG: clang{{.*}}" "-cc1" "-triple" "x86_64" hliao wrote: > tra wrote: > > I'd include `-target ` and a comment

r374119 - Fix crash or wrong code bug if a lifetime-extended temporary contains a

Author: rsmith Date: Tue Oct 8 14:26:03 2019 New Revision: 374119 URL: http://llvm.org/viewvc/llvm-project?rev=374119&view=rev Log: Fix crash or wrong code bug if a lifetime-extended temporary contains a "non-constant" value. If the constant evaluator evaluates part of a variable initializer, in

[PATCH] D68665: [HIP] Fix -save-temps

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Currently clang does not save some of the intermediate file generated during device compilation for HIP when -save-temps is specified. This patch fixes that. https://reviews.llvm.org/D68665 Files: lib/Driver/Driver.cpp lib/

r374126 - [IRGen] Emit lifetime markers for temporary struct allocas

Author: thegameg Date: Tue Oct 8 15:10:38 2019 New Revision: 374126 URL: http://llvm.org/viewvc/llvm-project?rev=374126&view=rev Log: [IRGen] Emit lifetime markers for temporary struct allocas When passing arguments using temporary allocas, we need to add the appropriate lifetime markers so that

[PATCH] D68669: [llvm-objdump][WIP] Make llvm-objdump -h compatible with GNU objdump.

rupprecht planned changes to this revision. rupprecht added a comment. Note: herald added reviewers, but this patch is just to provide context. I'll send the real patches for review in the coming days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D68669: [llvm-objdump][WIP] Make llvm-objdump -h compatible with GNU objdump.

rupprecht created this revision. Herald added subscribers: llvm-commits, cfe-commits, seiya, arphaman, jakehehrlich, aheejin, arichardson, sbc100, emaste. Herald added a reviewer: espindola. Herald added a reviewer: alexshap. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM.

[PATCH] D68611: [IRGen] Emit lifetime markers for temporary struct allocas

This revision was automatically updated to reflect the committed changes. thegameg marked an inline comment as done. Closed by commit rG143f6b837790: [IRGen] Emit lifetime markers for temporary struct allocas (authored by thegameg). Herald added a project: clang. Herald added a subscriber: cfe-com

[PATCH] D68665: [HIP] Fix -save-temps

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/Driver.cpp:4400 + // HIP image for device compilation with -fno-gpu-rdc is per compilation + // unit. + bool IsHIPNoRDC = JA.getOffloading

r374127 - [clang-scan-deps] Improve string/character literal skipping

Author: arphaman Date: Tue Oct 8 15:42:44 2019 New Revision: 374127 URL: http://llvm.org/viewvc/llvm-project?rev=374127&view=rev Log: [clang-scan-deps] Improve string/character literal skipping The existing string/character literal skipping code in the dependency directives source minimizer has

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223954. SouraVX added a comment. Addressed comments, regarding flags. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-des

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

a_sidorin added a comment. Hello Balasz, In my opinion, importing and setting the attributes should be handled by the stuff used in InitializeImportedDecl(). Can we extend it or reuse the code? It will allow us not to miss the required actions while importing a new function too. Repository:

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 3 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1619 + else { +SPFlags |= llvm::DISubprogram::SPFlagNotDefaulted; + } Previously SPFlagNotDefaulted is setted to SPFlagZero as

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

This revision was automatically updated to reflect the committed changes. arphaman marked 5 inline comments as done. Closed by commit rGa13f0da1d0bc: [clang-scan-deps] Improve string/character literal skipping (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D68436?vs=2

[PATCH] D68634: [ASTImporter] Imported FunctionDecls inherit attributes from existing functions

a_sidorin added a comment. Ouch! Sorry, Gabor -_\\ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68634/new/ https://reviews.llvm.org/D68634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-defaulted-out-of-class.cpp:25 + + //FIXME -- clang will not mark above member funtions, excluding constructors + // as out of class. If we did not mark destruct

r374130 - Factor out some duplication. NFC.

Author: rsmith Date: Tue Oct 8 16:37:49 2019 New Revision: 374130 URL: http://llvm.org/viewvc/llvm-project?rev=374130&view=rev Log: Factor out some duplication. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-p

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. In D68578#1698864 , @t-tye wrote: > From a source language point of view, the device function comprises the code > that is launched as a grid. We need this fact to be present in the symbols > used. Only the device function should hav

r374131 - [cxx_status] Note that Clang has supported std::source_location since

Author: rsmith Date: Tue Oct 8 16:39:56 2019 New Revision: 374131 URL: http://llvm.org/viewvc/llvm-project?rev=374131&view=rev Log: [cxx_status] Note that Clang has supported std::source_location since version 9. Modified: cfe/trunk/www/cxx_status.html Modified: cfe/trunk/www/cxx_status.htm

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk added a comment. In D68055#1698653 , @rsmith wrote: > From a big-picture perspective, I would like us to move to treating MS and > GNU extensions in the same way (at the cc1 level) to the extent that we can. > I think this moves us in that direction.

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith added a comment. Looks fine to me with some doc improvements. Comment at: clang/docs/ReleaseNotes.rst:64-66 + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, + by subtracting pointer's integral value from the pointer itself; in C, also, + appl

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

xbolva00 added a comment. In D68055#1688747 , @programmerjake wrote: > Shouldn't `__GNUG__` match `__GNUC__`? +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055

r374133 - [c++20] Implement most of P1152R4.

Author: rsmith Date: Tue Oct 8 17:49:40 2019 New Revision: 374133 URL: http://llvm.org/viewvc/llvm-project?rev=374133&view=rev Log: [c++20] Implement most of P1152R4. Diagnose some now-deprecated uses of volatile types: * as function parameter types and return types * as the type of a structur

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne updated this revision to Diff 223971. mhorne added a comment. Address lenary's comments. Add a check for __riscv_float_abi_double in getFloat/setFloat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 Files: libunwind/include/__libunwin

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

CaseyCarter added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int std::vector v(array, array + 3); ---

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne marked 5 inline comments as done. mhorne added a comment. Thanks for the review! Comment at: libunwind/src/Registers.hpp:3585 + +inline uint64_t Registers_riscv::getRegister(int regNum) const { + if (regNum == UNW_REG_IP) lenary wrote: > Do you want to

[PATCH] D68681: [libc++][test] Miscellaneous MSVC cleanups

CaseyCarter created this revision. CaseyCarter added reviewers: mclow.lists, EricWF, ldionne. Herald added a subscriber: dexonsmith. - Silence unused-local-typedef warnings: `map.cons/assign_initializer_list.pass.cpp` (and the `set.cons` variant) uses a local typedef only within `LIBCPP_ASSERT`s

r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

Author: rsmith Date: Tue Oct 8 19:04:54 2019 New Revision: 374135 URL: http://llvm.org/viewvc/llvm-project?rev=374135&view=rev Log: [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue whose value is not ignored. We don't warn on all the cases that are deprecated: specifically, we

[PATCH] D68578: [HIP] Fix device stub name

t-tye added a comment. In D68578#1700652 , @tra wrote: > In D68578#1698864 , @t-tye wrote: > > > From a source language point of view, the device function comprises the > > code that is launched as a grid. We need

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

poelmanc created this revision. poelmanc added reviewers: jonathanmeier, alexfh. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, ormris. Herald added a project: clang. Clang-tidy can ignore most formatting concerns as formatting is clang-format's job. H

[PATCH] D62731: [RFC] Add support for options -frounding-math, -fp-model=, and -fp-exception-behavior=, : Specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1330 + and ``fast``. + Details: + rjmccall wrote: > "provided by other, single-purpose floating point options." I don't know why you keep including "clang" as a modifier here; this is the

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge planned changes to this revision. nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:152 + // Don't bother computing the offset for the end of the line, just use + // zero.

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. In D67536#1699221 , @ilya-biryukov wrote: > I have actually seen clients that just make the text gray and it looks pretty > nice (ReSharper for Visual Studio and IntelliJ IDEA definitely do that). I don't think there is a confli

[PATCH] D68682: Clang-tidy fixes should avoid creating new blank lines

Eugene.Zelenko added a comment. You may be iinterested to l Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

<    1   2