CaseyCarter added inline comments.
================
Comment at:
test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159
float array[3] = {0.0f, 1.0f, 2.0f};
+#pragma warning(suppress: 4244) // narrowing float to int
std::vector<int> v(array, array + 3);
----------------
CaseyCarter wrote:
> BillyONeal wrote:
> > CaseyCarter wrote:
> > > This will blow up non-MSVC-ish when running the test suite with `-Wall -W
> > > -Werror` (which is typical). I suggest wrapping in `#ifdef _MSC_VER`.
> > Why didn't it blow up on Contest then? clang-cl is happy with it?
> clang-cl is the "ish" in my "MSVC-ish" (MSVC and compilers emulating MSVC).
> GCC and clang-without-`-fms-compatibility` when compiling with `-Wall` warn
> about unrecognized pragmas, just as does cl in default mode
> (https://godbolt.org/z/Chue0L).
Correction: Wrap with `#ifdef TEST_COMPILER_C1XX` instead of `#ifdef _MSC_VER`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61365/new/
https://reviews.llvm.org/D61365
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
