r372945 - [analyzer] A speculative attempt to avoid gcc-7 crashes caused by r372942.

Author: dergachev Date: Thu Sep 26 00:01:31 2019 New Revision: 372945 URL: http://llvm.org/viewvc/llvm-project?rev=372945&view=rev Log: [analyzer] A speculative attempt to avoid gcc-7 crashes caused by r372942. Modified: cfe/trunk/lib/StaticAnalyzer/Core/Store.cpp Modified: cfe/trunk/lib/Sta

[clang-tools-extra] r372948 - [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

Author: kadircet Date: Thu Sep 26 00:27:43 2019 New Revision: 372948 URL: http://llvm.org/viewvc/llvm-project?rev=372948&view=rev Log: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl Summary: To be used by define-inline code action to determine whether the function/method bo

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL372948: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

mgehre created this revision. mgehre added reviewers: aaron.ballman, gribozavr, hokein, alexfh. mgehre added a project: clang. Herald added subscribers: xazax.hun, mgorny. Finds non-static member functions that can be made ``const`` because the functions don't use ``this`` in a non-const way. The

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

grandinj added a comment. Nice! I went with a more brute force approach, and I also struggled with logical vs physical const-correctness https://cgit.freedesktop.org/libreoffice/core/tree/compilerplugins/clang/store/constmethod.cxx Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG, nice patch, thanks! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 _

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

lebedev.ri added a comment. Awesome! I believe i have asked this question in the convert-to-static diff - can ExprMutAnalyzer be used here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68074/new/ https://reviews.llvm.org/D68074 ___

r372949 - [Testing] Workaround libcxx bug when OS is "none"

Author: davezarzycki Date: Thu Sep 26 01:19:44 2019 New Revision: 372949 URL: http://llvm.org/viewvc/llvm-project?rev=372949&view=rev Log: [Testing] Workaround libcxx bug when OS is "none" If clang is configured to use libcxx as the default C++ standard library, then using "none" for the OS in th

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet updated this revision to Diff 221896. kadircet added a comment. - Rename regions to points - Return EOF if there are no shared namespaces with the target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

MyDeveloperDay added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); Manikishan wrote: > MyDeveloperDay wrot

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclarationsOnePerLine

Manikishan marked an inline comment as done. Manikishan added inline comments. Comment at: lib/Format/FormatToken.h:524 +T = T->getPreviousNonComment(); +return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && +T->Next->Tok.is(tok::colon)); ---

[PATCH] D68024: [clangd] Implement GetEligiblePoints

ilya-biryukov added a comment. A few go-by comments from me, Haojian should have better context here! Comment at: clang-tools-extra/clangd/SourceCode.cpp:655 +lex(llvm::StringRef Code, const format::FormatStyle &Style, +llvm::function_ref A) { // FIXME: InMemoryFileAdapt

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 221903. hokein added a comment. Rewrite the getBeignningOfIdentifier function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files: clang-tools-extra/clangd/SourceCo

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 221904. hokein added a comment. Fix a typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/clangd/u

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach created this revision. Herald added subscribers: cfe-commits, kristof.beyls, aprantl. Herald added a project: clang. Currently the following situation can occur: During AArch64 frame lowering cfi instructions get emitted if debug information is generated but not if not. Since cfi inst

[clang-tools-extra] r372953 - [clang-tidy] Make llvm-header-guard work on llvm git monorepo

Author: hokein Date: Thu Sep 26 02:56:37 2019 New Revision: 372953 URL: http://llvm.org/viewvc/llvm-project?rev=372953&view=rev Log: [clang-tidy] Make llvm-header-guard work on llvm git monorepo Reviewers: gribozavr Reviewed By: gribozavr Subscribers: xazax.hun, ilya-biryukov, MaskRay, jkorous,

[PATCH] D68026: [clang-tidy] Make llvm-header-guard work on llvm git monorepo

This revision was automatically updated to reflect the committed changes. Closed by commit rL372953: [clang-tidy] Make llvm-header-guard work on llvm git monorepo (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. We have turned on the flag manually and used it for a while, and don't see any major issues, let's enable it by default.

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr added a comment. Thanks! Do you need me to commit the patch for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

gribozavr added a comment. What is the expected contract of the functions that this checker flags? Are they supposed to perform unaligned reads correctly, and we have just an implementation bug in these functions, or is it the caller's fault if they pass an unaligned address? ===

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi Hans, I'm a bit suspicious against the part > This also revertes the part of r369938 which checked that -working-directory works. in this revert. You do: > + SmallString<128> Buf; > + if (!llvm::sys::fs::current_path(Buf)) > +Buf = "."; > + CDB << "{ \"directory\": \"" << escap

[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68077/new/ https://reviews.llvm.org/D68077 _

[PATCH] D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67964/new/ https://reviews.llvm.org/D67964 _

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221910. kadircet added a comment. - Rebase and update testhelpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/Def

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 221912. kadircet added a comment. - Rebase and update testhelpers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files: clang-tools-extra/clangd/refactor/tweaks/Def

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221911. kadircet added a comment. - Revert miscommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 221913. kadircet added a comment. - Mark tweak as visible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInlin

[clang-tools-extra] r372969 - [clangd][vscode] Turn on the semantic highlighting by default.

Author: hokein Date: Thu Sep 26 04:34:11 2019 New Revision: 372969 URL: http://llvm.org/viewvc/llvm-project?rev=372969&view=rev Log: [clangd][vscode] Turn on the semantic highlighting by default. Summary: We have turned on the flag manually and used it for a while, and don't see any major issues,

[clang-tools-extra] r372970 - [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

Author: hokein Date: Thu Sep 26 04:35:34 2019 New Revision: 372970 URL: http://llvm.org/viewvc/llvm-project?rev=372970&view=rev Log: [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0. Summary: This would enable the newly-added semantic selection feature in

[PATCH] D68077: [clangd][vscode] Turn on the semantic highlighting by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372969: [clangd][vscode] Turn on the semantic highlighting by default. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372970: [clangd][vscode] Update vscode lsp dependencies to pickup the new changes in… (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet updated this revision to Diff 221920. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68024/new/ https://reviews.llvm.org/D68024 Files: clang-tools-ex

[PATCH] D68024: [clangd] Implement GetEligiblePoints

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:655 +lex(llvm::StringRef Code, const format::FormatStyle &Style, +llvm::function_ref A) { // FIXME: InMemoryFileAdapter crashes unless the buffer

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Help to fix https://github.com/clangd/clangd/issues/159. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:286 - Before = Lexer::GetBeginningOfToken(Before, SM, LangOpts); - Token Tok; - if (Before.isValid() && - !Lexer::getRawToken(Before, Tok, SM, LangOpts, false) && - Tok.is(tok:

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added a comment. Currently we add too many qualifiers in some cases, e.g. here's a common pattern in clangd: // foo.h #include "Decl.h" namespace clang::clangd { std::string printName(Decl*D); } // foo.cpp #include "foo.h" namespace clang::clangd { std::string p

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 221924. gchatelet marked 11 inline comments as done. gchatelet added a comment. - Address aaron ballman comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added a comment. @aaron.ballman thx a lot for the review. I really appreciate it, especially because I'm not too familiar with this part of the codebase. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:1092 + // Wildcard is a super set of all builtins, we keep only this

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:439 +// Empty '!' implies no more functions. +if (S.size() == 1 && S[0] == '!') + break; ``` if (S.consume_front("!")) { if (S.empty()) ... else ... } ``` ===

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 +"package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/";, +

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added a comment. We also need to rename parameters sometimes, right? // Sometimes we need to rename parameters. void usages(int decl_param, int); void usages(int def_param, int now_named) { llvm::errs() << def_param + now_named; } // And template parameters! (the

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri updated this revision to Diff 221929. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. Rebased. I've added most (?) of the obviously-missing folds. This improved situation, although admittedly by not as much as i had hoped. ping @vsk; can this get going plea

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:120 + std::string BasicBlockSections; + Comment its allowed values ("all", "labels", "none") Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1103 + dy

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh marked an inline comment as done. lildmh added a comment. In D67978#1683166 , @ABataev wrote: > In D67978#1683146 , @lildmh wrote: > > > HI Alexey, the ast print test is already there. Because I didn't check

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin updated this revision to Diff 221931. mbrkusanin added reviewers: echristo, craig.topper, uweigand, tstellar, dylanmckay, petecoup. mbrkusanin added a comment. - rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 Files: clang/l

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

mbrkusanin added a comment. @echristo @craig.topper @uweigand @tstellar @dylanmckay @petecoup Do you have any comments on the current patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___ cfe-co

r372975 - [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

Author: svenvh Date: Thu Sep 26 06:31:36 2019 New Revision: 372975 URL: http://llvm.org/viewvc/llvm-project?rev=372975&view=rev Log: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test Add the -Wconversion -Werror options to check no unexpected conversion is done. Patch by Pierre Gondois

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

This revision was automatically updated to reflect the committed changes. Closed by commit rL372975: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 221935. hokein marked 2 inline comments as done. hokein added a comment. Simplify the logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files: clang-tools-extra/c

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein updated this revision to Diff 221936. hokein added a comment. Upload correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67695/new/ https://reviews.llvm.org/D67695 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part > > > This also revertes the part of r369938 which checked that > -working-directory works. > > in this revert. > > You do: > > > + SmallString<128> Buf; > > + if (!llv

[PATCH] D67695: [clangd] Implement getBeginning for overloaded operators.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:286 - Before = Lexer::GetBeginningOfToken(Before, SM, LangOpts); - Token Tok; - if (Before.isValid() && - !Lexer::getRawToken(Before, Tok, SM, LangOpts, false) && - Tok.is(tok::raw_id

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 +"package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd

[clang-tools-extra] r372978 - Use std::unique_ptr in ClangTidyCheckFactories

Author: gribozavr Date: Thu Sep 26 06:47:29 2019 New Revision: 372978 URL: http://llvm.org/viewvc/llvm-project?rev=372978&view=rev Log: Use std::unique_ptr in ClangTidyCheckFactories I had to explicitly define some destructors that could only be defined in the corresponding .cpp files. Modified:

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 +"package": "vsce package --baseImagesUrl https://raw.githubusercontent

[clang-tools-extra] r372979 - Return results by value from ClangTidyCheckFactories::createChecks

Author: gribozavr Date: Thu Sep 26 06:55:01 2019 New Revision: 372979 URL: http://llvm.org/viewvc/llvm-project?rev=372979&view=rev Log: Return results by value from ClangTidyCheckFactories::createChecks Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp clang-tools-extra/trunk/cla

[PATCH] D68024: [clangd] Implement GetEligiblePoints

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:996 + std::vector Enclosing = {""}; + // FIXME: In addition to namespaces try to generate events for function + // definitions as well. One

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

Eugene.Zelenko added a comment. See also PR21981 and D45444 . Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:93 + bool VisitUser(const ImplicitCastExpr *Cast) { + +if (Cast->getCastKind() != CK_NoOp)

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Might be worth mentioning in ReleaseNotes too :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://revi

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 +"package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd

[clang-tools-extra] r372980 - [clangd][vscode] Add npm helper commands to package/release the extension.

Author: hokein Date: Thu Sep 26 07:04:52 2019 New Revision: 372980 URL: http://llvm.org/viewvc/llvm-project?rev=372980&view=rev Log: [clangd][vscode] Add npm helper commands to package/release the extension. Summary: Help to fix https://github.com/clangd/clangd/issues/159. Reviewers: ilya-biryuk

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372980: [clangd][vscode] Add npm helper commands to package/release the extension. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r372981 - [clangd] Bump vscode-clangd v0.0.18

Author: hokein Date: Thu Sep 26 07:11:23 2019 New Revision: 372981 URL: http://llvm.org/viewvc/llvm-project?rev=372981&view=rev Log: [clangd] Bump vscode-clangd v0.0.18 CHANGELOG: - enable semantic highlighting by default - upgrade the LSP dependencies to pickup the incoming LSP v3.15.0 Modified

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

xbolva00 added a comment. This is great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1684104 , @lildmh wrote: > In D67978#1683166 , @ABataev wrote: > > > In D67978#1683146 , @lildmh wrote: > > > > > HI Alexey, the ast print

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 221939. gchatelet added a comment. - Checks function name validity and errors when passed 0 argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/i

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

hokein added a comment. In D66647#1684046 , @ilya-biryukov wrote: > We also need to rename parameters sometimes, right? > > // Sometimes we need to rename parameters. > void usages(int decl_param, int); > > void usages(int def_param, int now_named

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221947. kadircet added a comment. - Use canonical decl when checking visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refac

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 221962. yonghong-song retitled this revision from "[WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic" to "[WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields". yonghong-song edited the summary of this revision.

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. Please also see the ongoing discussion on the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1684169 , @ABataev wrote: > In D67978#1684104 , @lildmh wrote: > > > In D67978#1683166 , @ABataev wrote: > > > > > In D67978#1683146

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. This would fix PR37240 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list c

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

uweigand added a comment. This makes sense to me (although we don't currently need the options parameter there). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___ cfe-commits mailing list cfe-comm

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the first part to https://reviews.llvm.org/D68070 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:60 + template const T *getParent(const Expr *E) { +auto Parents = Ctxt.getParents(*E); +if (Parents.size() != 1) Return type is

r372994 - Un-XFAIL coverage_no_integrated_as.c test on Windows

Author: rnk Date: Thu Sep 26 09:56:25 2019 New Revision: 372994 URL: http://llvm.org/viewvc/llvm-project?rev=372994&view=rev Log: Un-XFAIL coverage_no_integrated_as.c test on Windows You can't use -fno-integrated-as for *-msvc triples because no usable standalone assembler exists. Perhaps we coul

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi, As Karl-Johan said I'll be out of office for a few days so please submit a fix if you can find the time. Thanks, Mikael Den 26 sep. 2019 15:39 skrev Hans Wennborg : On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl abandoned this revision. yaxunl marked an inline comment as done. yaxunl added a comment. no longer needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___ cfe-commits mailing list cfe-comm

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

leonardchan added a comment. *ping* @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1683905 , @gribozavr wrote: > Thanks! Do you need me to commit the patch for you? Yes, thank you. I don't have commit access—and also wasn't sure if anyone else had further comment. CHANGES SINCE LAST ACTION https:/

r372999 - Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions

Author: rnk Date: Thu Sep 26 10:19:22 2019 New Revision: 372999 URL: http://llvm.org/viewvc/llvm-project?rev=372999&view=rev Log: Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions Handling backslashes in include paths in the implementation isn't non-conforming. M

r373004 - Only pass -coverage-notes-file when emitting coverage

Author: rnk Date: Thu Sep 26 11:13:19 2019 New Revision: 373004 URL: http://llvm.org/viewvc/llvm-project?rev=373004&view=rev Log: Only pass -coverage-notes-file when emitting coverage The only functional change here is that -coverage-notes-file is not passed to -cc1 in some situations. This code

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh updated this revision to Diff 221990. lildmh retitled this revision from "[OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays" to "[OpenMP 5.0] Fix user-defined mapper lookup in sema". lildmh edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh updated this revision to Diff 221991. lildmh added a comment. Fix mapper type checking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67978 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/declare_mapper_messages.c test/OpenMP/declare_mapper_m

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

r373005 - Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..."

Author: dergachev Date: Thu Sep 26 11:52:00 2019 New Revision: 373005 URL: http://llvm.org/viewvc/llvm-project?rev=373005&view=rev Log: Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..." This reverts commit r372940 which was an overreaction to a flaky buildbot. Modified: cfe

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

r373007 - [clang-scan-deps] Allow continuation line backslashes followed by whitespace

Author: arphaman Date: Thu Sep 26 12:28:51 2019 New Revision: 373007 URL: http://llvm.org/viewvc/llvm-project?rev=373007&view=rev Log: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer Clang allows continuations that have whitespace be

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rG15d5f5dd350e: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in… (authored by arphaman). Changed prior to commit: https://reviews

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:63 +* As per C++ and C Standards (C++: ``[expr.add]``; C17: 6.5.6p8), applying + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, In C, even adding 0 to a null pointe

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

adamf created this revision. adamf added reviewers: rnk, thakis. adamf added a project: clang. Herald added a subscriber: cfe-commits. MS name mangling supports cache for first 10 distinct function arguments. The error was when non cached template type occurred twice (e.g. 11th and 12th). For such

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Comment at: clang/docs/ReleaseNotes.rst:238 -- ... +- * ``pointer-overflow`` check was extended added to catch the cases where +a non-zero offset being applied, either to a ``nullptr``, or the resul

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr added a comment. Sorry, could you rebase the patch to apply cleanly to master? Seems like someone else edited ReleaseNotes.rst in the meanwhile. $ arc patch D67567 ... Checking patch clang-tools-extra/docs/ReleaseNotes.rst... error: while searching for: Finds instances wher

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:63 +* As per C++ and C Standards (C++: ``[expr.add]``; C17: 6.5.6p8), applying + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, rsmith wrote: > In C, even ad

r373010 - [OPENMP50]Emit warnings if the functions was defined/used before marked

Author: abataev Date: Thu Sep 26 13:04:15 2019 New Revision: 373010 URL: http://llvm.org/viewvc/llvm-project?rev=373010&view=rev Log: [OPENMP50]Emit warnings if the functions was defined/used before marked declare variant. We can use the original function if it was used/emitted already. So, just

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 222016. mwyman added a comment. Rebased patch to apply to current master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/Cl

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1684785 , @gribozavr wrote: > Sorry, could you rebase the patch to apply cleanly to master? Seems like > someone else edited ReleaseNotes.rst in the meanwhile. > > $ arc patch D67567 > ... > Checking patch clang-too

  1   2   >