r371326 - [NewPM][Sancov] Create the Sancov Pass after building the pipelines

2019-09-08 Thread Leonard Chan via cfe-commits
Author: leonardchan Date: Sun Sep 8 00:30:17 2019 New Revision: 371326 URL: http://llvm.org/viewvc/llvm-project?rev=371326&view=rev Log: [NewPM][Sancov] Create the Sancov Pass after building the pipelines We're running into linker errors from missing sancov sections: ``` ld.lld: error: relocati

[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

2019-09-08 Thread Leonard Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL371326: [NewPM][Sancov] Create the Sancov Pass after building the pipelines (authored by leonardchan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D66336: [ASTImporter] Add development internals docs

2019-09-08 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66336/new/ https://reviews.llvm.org/D66336 ___

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

2019-09-08 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang/test/Profile/misexpect-branch-cold.c:4 +// RUN: llvm-profdata merge %S/Inputs/misexpect-branch.proftext -o %t.profdata +// RUN: %clang_cc1 %s -O2 -o - -disable-llvm-passes -emit-llvm -fprofile-instrument-use-path=%t.profdata -v

[PATCH] D58531: [clang] Specify type of pthread_create builtin

2019-09-08 Thread James Clarke via Phabricator via cfe-commits
jrtc27 added a comment. In D58531#1611356 , @jdoerfert wrote: > In D58531#1599209 , @probinson wrote: > > > We've started running into this too in building the PS4 system. +jdoerfert > > who added pthread_create to

[PATCH] D58531: [clang] Specify type of pthread_create builtin

2019-09-08 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I like the patch and I think it is fine. Small nits: Could we have a test for " we can detect dodgy pthread_create declarations" and maybe `pthread[_attr]_t`? There is an unresolved com

r371342 - Move prop-sink branch to monorepo.

2019-09-08 Thread Gabor Borsik via cfe-commits
Author: boga95 Date: Sun Sep 8 12:23:43 2019 New Revision: 371342 URL: http://llvm.org/viewvc/llvm-project?rev=371342&view=rev Log: Move prop-sink branch to monorepo. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp cfe/trunk/test/Analysis/taint-generic.c Modified

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

2019-09-08 Thread Borsik Gábor via Phabricator via cfe-commits
boga95 closed this revision. boga95 marked 10 inline comments as done. boga95 added a comment. Closed by 080ecafdd8b3e990e5ad19202d089c91c9c9b164 . Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

2019-09-08 Thread Khem Raj via Phabricator via cfe-commits
raj.khem added a comment. Can we bring this to 9.x release branch as well please ? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65699/new/ https://reviews.llvm.org/D65699 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-09-08 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. In D59754#1656217 , @leonardchan wrote: > Hi! We've noticed that for our arm bots, we're getting some flaky builds that > sometimes fail with `error: array designators are a C99 extension > [-Werror,-Wc99-designator]` and sometime

[PATCH] D67335: [analyzer][NFC] Refactor the checker registration unit test file

2019-09-08 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, Charusso, dcoughlin, baloghadamsoftware. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Nothing exciting

[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers

2019-09-08 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, dcoughlin, Charusso, baloghadamsoftware, dkrupp. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Please don't take

[PATCH] D67335: [analyzer][NFC] Refactor the checker registration unit test file

2019-09-08 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/unittests/StaticAnalyzer/RegisterCustomCheckersTest.cpp:84 -} -} -} +} // namespace +} // namespace ento Well, according to `clangd`, this is how it's supposed to be

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

2019-09-08 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D59754#1656217 , @leonardchan wrote: > Hi! We've noticed that for our arm bots, we're getting some flaky builds that > sometimes fail with `error: array designators are a C99 extension > [-Werror,-Wc99-designator]` and sometime

[PATCH] D65699: [Driver] Prioritize SYSROOT/usr/include over RESOURCE_DIR/include on linux-musl

2019-09-08 Thread Khem Raj via Phabricator via cfe-commits
raj.khem added a comment. one issue I now see is that when we have some thing like static const struct { const wchar_t *name; int (*func)(EditLine *, int, const wchar_t **); } cmds[] = { { L"bind", map_bind}, { L"echotc",