jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land.
I like the patch and I think it is fine. Small nits: Could we have a test for " we can detect dodgy pthread_create declarations" and maybe `pthread[_attr]_t`? There is an unresolved comment by @shrines. @probinson: "it seems straightforward enough although clearly needs clang-format-diff run over it." I'll accept this assuming the above points are easy to fix and given that no one expressed concerns but only positive comments were made. ================ Comment at: clang/lib/AST/ASTContext.cpp:9239 + ASTContext::GetBuiltinTypeError &Error, + unsigned *IntegerConstantArgs); + ---------------- I like the static helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
