jrtc27 added a comment. In D58531#1611356 <https://reviews.llvm.org/D58531#1611356>, @jdoerfert wrote:
> In D58531#1599209 <https://reviews.llvm.org/D58531#1599209>, @probinson wrote: > > > We've started running into this too in building the PS4 system. +jdoerfert > > who added pthread_create to the builtin list. > > > > Looking at the patch, it seems straightforward enough although clearly > > needs clang-format-diff run over it. > > I don't touch Clang that much so I'm reluctant to okay it myself. > > > @probinson Thanks for making me aware of this patch. > > > A separate point is whether it makes sense to be emitting this warning in > > the first place for GE_Missing_type. I'd argue that, if we don't know the > > type of the builtin, we should never emit the warning > > @jrtc27 I hope the immediate need for this is gone after D58091 > <https://reviews.llvm.org/D58091> was finally committed? Given that I caused > this mess I can take a look at the patch if you are still interested in it, > are you? Yes, now that it's not a warning if we don't provide a type this is no longer completely necessary. I would still be slightly in favour of this patch though as then we can detect dodgy `pthread_create` declarations, but it's not a big deal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58531/new/ https://reviews.llvm.org/D58531 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
