[clang-tools-extra] r370843 - [clangd] Split Preamble.h out of ClangdUnit.h. NFC

Author: sammccall Date: Wed Sep 4 00:35:00 2019 New Revision: 370843 URL: http://llvm.org/viewvc/llvm-project?rev=370843&view=rev Log: [clangd] Split Preamble.h out of ClangdUnit.h. NFC Summary: Add comment describing use of preamble in clangd. Remove deps on ClangdUnit.h where possible. Subscr

[PATCH] D67117: [clangd] Split Preamble.h out of ClangdUnit.h. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL370843: [clangd] Split Preamble.h out of ClangdUnit.h. NFC (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r370850 - Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline"

Author: hans Date: Wed Sep 4 01:19:30 2019 New Revision: 370850 URL: http://llvm.org/viewvc/llvm-project?rev=370850&view=rev Log: Re-commit r363191 "[MS] Pretend constexpr variable template specializations are inline" While the next Visual Studio update (16.3) will fix this issue, that hasn't s

[PATCH] D65527: Avoid assemble step in verbose-output-quoting.c

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65527/new/ https://reviews.llvm.org/D65527 __

Re: r364476 - Revert r363191 "[MS] Pretend constexpr variable template specializations are inline"

Re-committed in r370850 for PR42843. On Wed, Jun 26, 2019 at 11:16 PM Reid Kleckner via cfe-commits wrote: > > Author: rnk > Date: Wed Jun 26 14:16:51 2019 > New Revision: 364476 > > URL: http://llvm.org/viewvc/llvm-project?rev=364476&view=rev > Log: > Revert r363191 "[MS] Pretend constexpr varia

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:647 + WE.changes.emplace(); + auto FS = FSProvider.getFileSystem(); + for (const auto &It : R->ApplyEdits) { please pull out a method for this part e.g. `Erro

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske updated this revision to Diff 218610. balazske added a comment. - Added comment about repeated enums in C99. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D67135: [clang-tidy] performance-inefficient-vector-operation: Support proto repeated field

lebedev.ri added a comment. I'm not sure this is the correct approach. I'd think the check instead should be parametrized, so this patch should become just extending the config. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67135/new/ https://revie

[PATCH] D67149: Fix argument order for BugType instation for

rtmpdavid created this revision. rtmpdavid added a reviewer: MTC. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a mixup in this specific one, name and category are in incorrect order Repository: rC Clang https://reviews.llvm.org/D67149 Files: clang/lib/Sta

[clang-tools-extra] r370862 - [clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC

Author: sammccall Date: Wed Sep 4 02:46:06 2019 New Revision: 370862 URL: http://llvm.org/viewvc/llvm-project?rev=370862&view=rev Log: [clangd] Rename ClangdUnit.h -> ParsedAST.h. NFC This much better reflects what is (now) in this header. Maybe a rename to ParsedTU would be an improvement, but

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong updated this revision to Diff 218625. martong added a comment. - Fix wrong file comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 Files: clang/unittests/AST/ASTImporterODRStrategiesTest.cpp

[clang-tools-extra] r370864 - [clangd] Move threading helper to more appropriate header. NFC

Author: sammccall Date: Wed Sep 4 02:53:24 2019 New Revision: 370864 URL: http://llvm.org/viewvc/llvm-project?rev=370864&view=rev Log: [clangd] Move threading helper to more appropriate header. NFC Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp clang-tools-extra/trunk/clangd/T

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

gchatelet added a comment. This patch broke my build as well (discovered by runnin `git bisect`), command line > cmake -DCMAKE_BUILD_TYPE=Debug -DCMAKE_C_COMPILER=/usr/local/bin/clang > -DCMAKE_ASM_COMPILER=/usr/local/bin/clang > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ > -DCMAKE_EXPORT_CO

[clang-tools-extra] r370865 - [clangd] Remove obsolete includes. NFC

Author: sammccall Date: Wed Sep 4 03:01:05 2019 New Revision: 370865 URL: http://llvm.org/viewvc/llvm-project?rev=370865&view=rev Log: [clangd] Remove obsolete includes. NFC Modified: clang-tools-extra/trunk/clangd/Threading.h clang-tools-extra/trunk/clangd/Trace.cpp clang-tools-extr

[clang-tools-extra] r370869 - [clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline into relevant callsites. NFC

Author: sammccall Date: Wed Sep 4 03:15:27 2019 New Revision: 370869 URL: http://llvm.org/viewvc/llvm-project?rev=370869&view=rev Log: [clangd] Remove macro-expansion-location from getBeginningOfIdentifier. Inline into relevant callsites. NFC Modified: clang-tools-extra/trunk/clangd/SourceC

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

svenvh added a comment. Shared library builds seem to be broken indeed. I tried fixing by adding `Support` and `clangAST` as dependencies for `clangInterp`, but that creates a cyclic dependency between `clangAST` <-> `clangInterp`. Which makes me wonder whether `clangInterp` should be a separ

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet marked 13 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:414 + if (llvm::Error Err = reformatEdit(E, Style)) { +llvm::handleAllErrors(std::move(Err), [&](llvm::ErrorInfoBase &EIB) { + e

[PATCH] D66637: [clangd] Support multifile edits as output of Tweaks

kadircet updated this revision to Diff 218637. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66637/new/ https://reviews.llvm.org/D66637 Files: clang-tools-ex

r370874 - Revert "[Clang Interpreter] Initial patch for the constexpr interpreter"

Author: lebedevri Date: Wed Sep 4 03:57:06 2019 New Revision: 370874 URL: http://llvm.org/viewvc/llvm-project?rev=370874&view=rev Log: Revert "[Clang Interpreter] Initial patch for the constexpr interpreter" Breaks BUILD_SHARED_LIBS build, introduces cycles in library dependency graphs. (clangIn

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

lebedev.ri added a comment. In D64146#1657117 , @svenvh wrote: > Shared library builds seem to be broken indeed. I tried fixing by adding > `Support` and `clangAST` as dependencies for `clangInterp`, but that creates > a cyclic dependency between `clang

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

lebedev.ri added a comment. In D64146#1657146 , @lebedev.ri wrote: > In D64146#1657117 , @svenvh wrote: > > > Shared library builds seem to be broken indeed. I tried fixing by adding > > `Support` and `clangAST` a

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 218639. Anastasia added a comment. Moved addr space of pointee inference into Build* helpers of Sema. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://reviews.llvm.org/D65744 Files: clang/include/clang/AST/Type.h clang/lib/AST

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1653081 , @rjmccall wrote: > In D65744#1652355 , @Anastasia wrote: > > > I don't think this is likely to change. Are you suggesting to move the > > deduction logic for pointee o

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: include/clang/AST/Type.h:6509 + return isa(CanonicalType); +} + rjmccall wrote: > Hmm. So this method, confusingly, will not return true for a deduced `auto`, > unless the

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1639175 , @mantognini wrote: > I think this looks good. Maybe the tests should be extended to test `auto` as > function return type, and if there's some special handling around > `decltype(auto)`, then it should be te

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand reopened this revision. nand added a comment. Thanks for identifying these issues - I fixed the cycle detected by modules since then, however I wasn't aware of the issue with shared libs until now. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ htt

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. MSVC builds are seeing template instantiation issues with this patch: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/27972/steps/build/lo

[clang-tools-extra] r370884 - [clangd] Fix SelectionTree behavior on implicit 'this'

Author: sammccall Date: Wed Sep 4 05:15:20 2019 New Revision: 370884 URL: http://llvm.org/viewvc/llvm-project?rev=370884&view=rev Log: [clangd] Fix SelectionTree behavior on implicit 'this' Modified: clang-tools-extra/trunk/clangd/Selection.cpp clang-tools-extra/trunk/clangd/unittests/Se

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. For white-box testing correct container and iterator mo

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. I believe that the code can still be simplified somewhat, but that it's correct as-is for `float`, `double`, and `long double`. I'll take an AI to follow-up on future improvements, and let's g

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

baloghadamsoftware added a comment. I did not add debug calls to the tests of the existing iterator checkers yet, they will come in the next patch. After that I think the next step is to refactor the monolithic checker class into smaller ones: the iterator modelling into one file, and all the o

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, ostannard. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows you to declare a function with a name of your choice (say `foo`), but have clang treat it as if it were a builtin functio

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia updated this revision to Diff 218661. Anastasia added a comment. - Added forgotten test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65744/new/ https://reviews.llvm.org/D65744 Files: clang/include/clang/AST/Type.h clang/lib/AST/Expr.cpp clang/lib/Sema/SemaType.cpp cl

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

This revision was automatically updated to reflect the committed changes. Closed by commit rL370891: [libc++] Add `__truncating_cast` for safely casting float types to integers (authored by ldionne, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, miyuki, ostannard. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. Herald added a project: clang. The ACLE intrinsics for the MVE instruction set have polymorphic variants: you can write vaddq(v,w) and ha

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

lebedev.ri added a comment. It somehow doesn't seem entirely good to provide a way to mark arbitrary function in sources as a builtin.. Why can't those MVE builtins be implemented similarly like all the existing builtins? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[clang-tools-extra] r370895 - [clangd] Add TUScheduler.h to CodeComplete.cpp to unbreak builds

Author: kadircet Date: Wed Sep 4 06:04:34 2019 New Revision: 370895 URL: http://llvm.org/viewvc/llvm-project?rev=370895&view=rev Log: [clangd] Add TUScheduler.h to CodeComplete.cpp to unbreak builds Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2957 +if (!AliasFunc) { + auto *IFunc = cast(GetOrCreateLLVMFunction( + AliasName, DeclTy, GD, /*ForVTable=*/false, /*DontDefer=*/true, erichkeane wrote: > erichkeane

[PATCH] D67163: [Driver] Use shared singleton instance of DriverOptTable

ilya-biryukov created this revision. ilya-biryukov added reviewers: gribozavr, sammccall. Herald added a subscriber: kadircet. Herald added a project: clang. This significantly reduces the time required to run clangd tests, by ~10%. Should also have an effect on other tests that run command-line

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

simon_tatham added a comment. Sorry about that – I didn't want to put the discussion of rationale in too many different places. The commit message for the followup patch D67161 discusses it a bit. The usual thing in previous intrinsics systems like NEON is that

[PATCH] D67057: [AST][JSON] Generate parent context id from Decl* instead of DeclContext*

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Thank you for this! Comment at: clang/lib/AST/JSONNodeDumper.cpp:118 +// same AST Node. +auto ParentDeclContextDecl = dyn_c

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

erichkeane added a subscriber: rnk. erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2957 +if (!AliasFunc) { + auto *IFunc = cast(GetOrCreateLLVMFunction( + AliasName, DeclTy, GD, /*ForVTable=*/false, /*DontDefer=*/true,

[PATCH] D67165: [clangd][vscode] Don't register notifications multiple times when clangd crashes.

hokein planned changes to this revision. hokein added a comment. wait, there is still an issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67165/new/ https://reviews.llvm.org/D67165 ___ cfe-commits

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

alexfh added a reviewer: aaron.ballman. alexfh added a comment. In D67140#1656858 , @gribozavr wrote: > Thanks! Yay consistency. > > I prefer the term "checker" to refer to individual modules because I feel it > is more precise and less ambiguous. In phra

[PATCH] D66990: [clangd] Add distinct highlightings for declarations of functions and methods

ilya-biryukov added a comment. In D66990#1656230 , @nridge wrote: > Not a hard requirement, just a nice-to-have for someone moving from one tool > to another :) > If you feel that for now it's better not to do this, I can respect that. Thanks, if that

[PATCH] D67165: [clangd][vscode] Don't register notifications multiple times when clangd crashes.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. hokein planned changes to this revision. hokein added a comment. wait, there is still an issue. Previously, we registered the notif

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2957 +if (!AliasFunc) { + auto *IFunc = cast(GetOrCreateLLVMFunction( + AliasName, DeclTy, GD, /*ForVTable=*/false, /*DontDefer=*/true, erichkeane wrote: > zsrkmyn

[PATCH] D67160: [clang, ARM] Default to -fno-lax-vector-conversions in ARM v8.1-M.

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67160/new/ https://reviews.llvm.org/D67160 __

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:240 + Arg = Arg->IgnoreImpCasts(); + if (isa(Arg)) + Arg = cast(Arg)->getSubExpr(); aaron.ballman wrote: > The bug claims that this is only for handling n

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

alexfh added a comment. Please add full context to the diff. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 __

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. Does anyone have any suggestions on how to fix the MSVC problems? I am trying to get access to a Windows machine, but it's not guaranteed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D641

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

probinson added a comment. It looks to me like the patch does things the New Way only for Linux and NetBSD, so for PS4 backward compatibility I am okay with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 _

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

lebedev.ri added a comment. In D64146#1657473 , @nand wrote: > Merged clangInterp and clangAST into a single library while keeping Interp in > a separate folder. > This is required since clangInterp needs access to the AST, but the intry > points to the

[PATCH] D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:326 + CharSourceRange ArgsRange = + MakeFileCharRange(Args[I]->getBeginLo

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a comment. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28 + IgnoreSingleArgument( + Options.getLocalOrGlobal("IgnoreSingl

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

nand added a comment. The existing evaluator is not a separate library to start with. Given the tangling between ExprConstants.cpp and the AST nodes, I don't really see any elegant way of dealing with this problem. An example of the problem is `FieldDecl::getBitWidthValue`. Repository: rG L

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb updated this revision to Diff 218683. xyb added a comment. Update with full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp clang-tools-extra/test/clang-tidy/bug

[PATCH] D66699: [PowerPC][Altivec] Fix constant argument for vec_dss

This revision was automatically updated to reflect the committed changes. jsji marked an inline comment as done. Closed by commit rL370902: [PowerPC][Altivec] Fix constant argument for vec_dss (authored by jsji, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG if there are no other concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 ___ cfe-comm

r370902 - [PowerPC][Altivec] Fix constant argument for vec_dss

Author: jsji Date: Wed Sep 4 07:01:47 2019 New Revision: 370902 URL: http://llvm.org/viewvc/llvm-project?rev=370902&view=rev Log: [PowerPC][Altivec] Fix constant argument for vec_dss Summary: This is similar to vec_ct* in https://reviews.llvm.org/rL304205. The argument must be a constant, other

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:240 + Arg = Arg->IgnoreImpCasts(); + if (isa(Arg)) + Arg = cast(Arg)->getSubExpr(); xyb wrote: > aaron.b

r370903 - [ASTImporter] Added visibility context check for TypedefNameDecl.

Author: balazske Date: Wed Sep 4 07:12:18 2019 New Revision: 370903 URL: http://llvm.org/viewvc/llvm-project?rev=370903&view=rev Log: [ASTImporter] Added visibility context check for TypedefNameDecl. Summary: ASTImporter makes now difference between typedefs and type aliases with same name in di

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb added a comment. Thanks. BTW, I can't commit the patch by myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos.

xyb added a comment. Thanks. BTW, I can't commit the patch by myself. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67080/new/ https://reviews.llvm.org/D67080 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370903: [ASTImporter] Added visibility context check for TypedefNameDecl. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb added a comment. Thanks. BTW, I can't commit the patch by myself. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67056/new/ https://reviews.llvm.org/D67056 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

hokein updated this revision to Diff 218691. hokein added a comment. Update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67165/new/ https://reviews.llvm.org/D67165 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.t

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, hokein. Herald added subscribers: jfb, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This takes ~5% of time when running clangd unit tests. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D67172: [clangd] Use pre-populated mappings for standard symbols

ilya-biryukov added a comment. Also considered moving the std symbol mapping into a separate (private-to-implementation) class, e.g. we don't use suffix mappings and symbol mappings outside system includes. But decided to wait until suffix mapping are going away completely. Repository: rG LL

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits mailing list cf

r370908 - [Driver] Use shared singleton instance of DriverOptTable

Author: ibiryukov Date: Wed Sep 4 07:26:28 2019 New Revision: 370908 URL: http://llvm.org/viewvc/llvm-project?rev=370908&view=rev Log: [Driver] Use shared singleton instance of DriverOptTable Summary: This significantly reduces the time required to run clangd tests, by ~10%. Should also have an

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighligh

[clang-tools-extra] r370908 - [Driver] Use shared singleton instance of DriverOptTable

Author: ibiryukov Date: Wed Sep 4 07:26:28 2019 New Revision: 370908 URL: http://llvm.org/viewvc/llvm-project?rev=370908&view=rev Log: [Driver] Use shared singleton instance of DriverOptTable Summary: This significantly reduces the time required to run clangd tests, by ~10%. Should also have an

[PATCH] D67163: [Driver] Use shared singleton instance of DriverOptTable

This revision was automatically updated to reflect the committed changes. Closed by commit rL370908: [Driver] Use shared singleton instance of DriverOptTable (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new se

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji updated this revision to Diff 218696. jsji added a comment. Rebase to ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66748/new/ https://reviews.llvm.org/D66748 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Sema/SemaChecki

[PATCH] D67174: Rename of constants in ASTImporterVisibilityTest. NFC.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67174 Files: clang/unittests

[PATCH] D64480: [ASTImporter] Added visibility context check for TypedefNameDecl.

balazske added a comment. Rename of constants: https://reviews.llvm.org/D67174 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64480/new/ https://reviews.llvm.org/D64480 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D67163: [Driver] Use shared singleton instance of DriverOptTable

arphaman added a comment. Thanks, this is useful for clang-scan-deps too! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67163/new/ https://reviews.llvm.org/D67163 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:88 +// recover from clangd crashes. +this.dispose(); +// Register the handler to handle semantic highlighting notification. C

[PATCH] D66569: [analyzer] ccc-analyzer: handle --sysroot=/path in addition to --sysroot /path

chris.laplante added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66569/new/ https://reviews.llvm.org/D66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

hokein updated this revision to Diff 218710. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67165/new/ https://reviews.llvm.org/D67165 Files: clang-tools-extra/cla

r370912 - [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

Author: jsji Date: Wed Sep 4 08:22:26 2019 New Revision: 370912 URL: http://llvm.org/viewvc/llvm-project?rev=370912&view=rev Log: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst* Summary: This is follow up of https://reviews.llvm.org/D66699. We might get ISEL ICE if we call vec

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

This revision was automatically updated to reflect the committed changes. Closed by commit rL370912: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst* (authored by jsji, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri updated this revision to Diff 218720. lebedev.ri marked 3 inline comments as done. lebedev.ri added a comment. Merged the check into `pointer-overflow`, revisited test coverage. Using `EmitCheckedInBoundsGEP()` in more places TBD. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4703-4720 +// 2) The sign of the difference between the computed address and the base +// pointer matches the sign of the total offset. +llvm:

[PATCH] D67165: [clangd][vscode] Make SemanticHighlightingFeature more self-contained.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67165/new/ https://reviews.llvm.org/D67165

[PATCH] D67096: [clangd][vscode] Add a flag to enable semantic highlighting in clangd

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:113 const semanticHighlightingFeature = - new semanticHighlighting.SemanticHighlightingFeature(); + new semanticHighlighting.SemanticHighlightingFeature(

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

alexfh added a comment. In D67056#1657540 , @xyb wrote: > Thanks. BTW, I can't commit the patch by myself. There's an outstanding comment. Please address it first, and I'll be happy to commit your patch. Repository: rCTE Clang Tools Extra CHANGES S

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--+---

r370915 - [X86] Add support for avx512bf16 for __builtin_cpu_supports and compiler-rt's cpu indicator.

Author: ctopper Date: Wed Sep 4 09:01:43 2019 New Revision: 370915 URL: http://llvm.org/viewvc/llvm-project?rev=370915&view=rev Log: [X86] Add support for avx512bf16 for __builtin_cpu_supports and compiler-rt's cpu indicator. Modified: cfe/trunk/test/CodeGen/target-builtin-noerror.c Modifi

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

kkwli0 added inline comments. Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--++ +| device extension | cl

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Comment at: clang/docs/OpenMPSupport.rst:204 ++--+--+--+-

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

protze.joachim added inline comments. Comment at: clang/docs/OpenMPSupport.rst:165 ++--+--+--++ +| OMPD | OMPD i

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28 + IgnoreSingleArgument( + Options.getLocalOrGlobal("IgnoreSingleArgument", 0) != 0), CommentBoolLiterals(Options.getLocalOrGlobal("CommentBoolLiterals", 0

[clang-tools-extra] r370919 - [clang-tidy] Fix bugprone-argument-comment bug if there are marcos.

Author: alexfh Date: Wed Sep 4 09:19:32 2019 New Revision: 370919 URL: http://llvm.org/viewvc/llvm-project?rev=370919&view=rev Log: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos. Summary: Fix bugprone-argument-comment bug if there are marcos. For example: ``` void j(int a,

[PATCH] D67080: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370919: [clang-tidy] Fix bugprone-argument-comment bug if there are marcos. (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook created this revision. simoncook added reviewers: asb, lenary. Herald added subscribers: llvm-commits, cfe-commits, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, ni

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28 + IgnoreSingleArgument( + Options.getLocalOrGlobal("IgnoreSingleArgument", 0) != 0), CommentBoolLiterals(Options.getLocalOrGlobal("CommentBoolLiterals"

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

alexfh added a comment. In D67084#1657534 , @xyb wrote: > Thanks. BTW, I can't commit the patch by myself. The patch doesn't apply cleanly. Please rebase it against current HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https:/

  1   2   >