xyb added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:28
+ IgnoreSingleArgument(
+ Options.getLocalOrGlobal("IgnoreSingleArgument", 0) != 0),
CommentBoolLiterals(Options.getLocalOrGlobal("CommentBoolLiterals", 0) !=
----------------
alexfh wrote:
> Why is it a global option? Are there other checks that would need the same
> option? The one below also needs to be check-local.
Sorry, I'm afraid I didn't get your point. Could you please explain more? This
setting just follows the same pattern used for other settings. All other
settings use "Options.getLocalOrGlobal(...)", I'm not sure why this setting
need be different. Or do you mean we should change other settings
("StrictMode", "CommentBoolLiterals", "CommentIntegerLiterals", ...) to local
options also?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67056/new/
https://reviews.llvm.org/D67056
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
