xyb added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp:240 + Arg = Arg->IgnoreImpCasts(); + if (isa<UnaryOperator>(Arg)) + Arg = cast<UnaryOperator>(Arg)->getSubExpr(); ---------------- aaron.ballman wrote: > The bug claims that this is only for handling negative literals, but this > allows any unary operator. Is that intentional? If we're going to allow > arbitrary unary operators, why not arbitrary binary operators as well? Actually, it handles "UnaryOperator Literal". So it will handle "+12", "-12", "~12". I can restrict it for UO_MINUS only, but is it real necessary? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
