[PATCH] D65725: [analyzer] Mention whether an event is about a condition in a bug report part 2

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:465 void assert(int b) { - if (!b) // tracking-note{{Assuming 'b' is not equal to 0}} + if (!b) // tracking-note{{Assuming 'b' i

r368259 - [diagtool] Use `operator<<(Colors)` to print out colored output.

Author: ruiu Date: Thu Aug 8 00:04:01 2019 New Revision: 368259 URL: http://llvm.org/viewvc/llvm-project?rev=368259&view=rev Log: [diagtool] Use `operator<<(Colors)` to print out colored output. r368131 introduced this new API to print out messages in colors. If the colored output is disabled, `

[PATCH] D65854: [diagtool] Use `operator<<(Colors)` to print out colored output.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368259: [diagtool] Use `operator<<(Colors)` to print out colored output. (authored by ruiu, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368261 - [clangd] Fix implicit template instatiations appearing as topLevelDecls.

Author: jvikstrom Date: Thu Aug 8 00:21:06 2019 New Revision: 368261 URL: http://llvm.org/viewvc/llvm-project?rev=368261&view=rev Log: [clangd] Fix implicit template instatiations appearing as topLevelDecls. Summary: The parser gives implicit template instantiations to the action's HandleTopLev

[PATCH] D65510: [clangd] Fix implicit template instatiations appearing as topLevelDecls.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 4 inline comments as done. Closed by commit rL368261: [clangd] Fix implicit template instatiations appearing as topLevelDecls. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald add

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus marked 2 inline comments as done. Szelethus added a comment. After testing this patch out, I'm confident it works pretty well. Take a look at the following two runs: 138 notes

[PATCH] D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. printTemplateSpecializationArgs was not printing partial variable specialization args. This adds an additi

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Conversion operators contain invalid MemberLocs which causes SemanticHighlighting to emit a lot of error l

r368267 - [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

Author: sureyeaah Date: Thu Aug 8 01:37:49 2019 New Revision: 368267 URL: http://llvm.org/viewvc/llvm-project?rev=368267&view=rev Log: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase Reviewers: arphaman, sammccall Subscribers: dexonsmith, cfe-commits Tags: #clang Diffe

[PATCH] D65883: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase

This revision was automatically updated to reflect the committed changes. Closed by commit rL368267: [Extract] Fixed SemicolonExtractionPolicy for SwitchStmt and SwitchCase (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56 +if (ME->getMemberLoc().isInvalid()) + // If the member is a conversion operator the loc will be invalid. This + // causes the addToken function to emit a lot of error log

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D62960: Add SVE opaque built-in types

rsandifo-arm updated this revision to Diff 214095. rsandifo-arm edited the summary of this revision. rsandifo-arm added a comment. - Remove pointless "SVE Types" comments - Expand commentary about SVE type layout and future debug info handling - Make macro formatting more consistent with the surro

[PATCH] D62960: Add SVE opaque built-in types

rsandifo-arm marked 7 inline comments as done. rsandifo-arm added inline comments. Comment at: lib/AST/ASTContext.cpp:1974 + break; +#include "clang/Basic/AArch64SVEACLETypes.def" } rjmccall wrote: > Why do SVE predicates have 16-bit alignment? Should

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

Pierre added a comment. Just one comment, Thank you again for making everything clearer :) Comment at: clang/lib/Sema/OpenCLBuiltins.td:116 +// combination of Types and vector sizes. +// +// E.g.: If TypeListField = and VectorList = <1, 2, 4>, then Maybe it wo

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Code to import "ctor initializers" at import of functions is mo

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The API provided by refactoring lib doesn't provide enough flexibility to get clangd's rename to behave as we expect

[clang-tools-extra] r368277 - [clangd] Correct the documentation, NFC.

Author: hokein Date: Thu Aug 8 03:58:16 2019 New Revision: 368277 URL: http://llvm.org/viewvc/llvm-project?rev=368277&view=rev Log: [clangd] Correct the documentation, NFC. Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.h Modified: clang-tools-extra/trunk/clangd/unittests/T

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:141 + for (Decl *TopLevelDecl : AST.getLocalTopLevelDecls()) { +auto RenameInDecl = +tooling::getOccurrencesOfUSRs(RenameUSRs, OldName, TopLevelDecl); nit: most

[PATCH] D65938: [AST] No longer visiting CXXMethodDecl bodies created by compiler when method was default created.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov, gribozavr. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. Clang generates function bodies and puts them in the AST for default methods if it is defaulted

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

jvikstrom updated this revision to Diff 214110. jvikstrom marked an inline comment as done. jvikstrom added a comment. Changed to do an isa check instead of checking if MemberLoc is invalid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65928/new/

[PATCH] D65919: Add llvm-prefer-register-over-unsigned to clang-tidy and apply it to LLVM

dsanders created this revision. dsanders added reviewers: arsenm, bogner. Herald added subscribers: cfe-commits, s.egerton, Jim, asbirlea, Petar.Avramovic, jsji, jocewei, PkmX, tpr, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, MaskRay, jrtc27, niosHD, sabuasal, ap

[PATCH] D65634: [RISCV] Default to ilp32d/lp64d in RISC-V Linux

asb added a comment. In D65634#1618443 , @rogfer01 wrote: > Thanks @asb @lenary for the review! > > I understand that, after this change, we will also want to make > `-march=rv{32,64}gc` the default in Linux as well. Otherwise there will be an > ABI mism

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56 +if (isa(MD)) + // If the member is a conversion operator the loc will be invalid. This + // causes the addToken function to emit a lot of error logs about trying

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

hokein updated this revision to Diff 214112. hokein marked 4 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65936/new/ https://reviews.llvm.org/D65936 Files: clang-tools-extra/cla

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:175 +// Currently, we only support normal rename (one range) for C/C++. +// FIXME: support multiple-range rename for objective-c methods. +if (Rename.getNameRanges().size() > 1) ---

[PATCH] D65940: [clang-format] fix crash involving invalid preprocessor line

krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This (invalid) fragment is crashing clang-format: #if 1 int x; #elif int y; #endif The reason being that the parser expects a token after `#elif`, and the subsequent parsing of the ne

[PATCH] D65940: [clang-format] fix crash involving invalid preprocessor line

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: unittests/Format/FormatTest.cpp:3090 Style); + // Don't crash if there is nothing following #elif. + verifyFormat("#if 1\n" --

[PATCH] D65941: [OpenCL] Fix lang mode predefined macros for C++ mode

Anastasia created this revision. Anastasia added a reviewer: svenvh. Herald added subscribers: ebevhan, yaxunl. We should only avoid adding `__OPENCL_C_VERSION__`, all other predefined macros about the language mode are still valid. This change also fixes the language version check in the header

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65940: [clang-format] fix crash involving invalid preprocessor line

krasimir updated this revision to Diff 214115. krasimir marked an inline comment as done. krasimir added a comment. - Apply review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65940/new/ https://reviews.llvm.org/D65940 Files: lib/Format/TokenAnnotato

[PATCH] D65940: [clang-format] fix crash involving invalid preprocessor line

krasimir marked an inline comment as done. krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:3090 Style); + // Don't crash if there is nothing following #elif. + verifyFormat("#if 1\n" gribozavr wrote: > `// #elif direc

r368280 - [clang-format] fix crash involving invalid preprocessor line

Author: krasimir Date: Thu Aug 8 04:56:18 2019 New Revision: 368280 URL: http://llvm.org/viewvc/llvm-project?rev=368280&view=rev Log: [clang-format] fix crash involving invalid preprocessor line Summary: This (invalid) fragment is crashing clang-format: ``` #if 1 int x; #elif int y; #endif ```

[PATCH] D65940: [clang-format] fix crash involving invalid preprocessor line

This revision was automatically updated to reflect the committed changes. Closed by commit rL368280: [clang-format] fix crash involving invalid preprocessor line (authored by krasimir, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CH

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

jvikstrom updated this revision to Diff 214117. jvikstrom marked an inline comment as done. jvikstrom added a comment. Added test for conversion operators. Also changed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65928/new/ https://revie

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56 +if (isa(MD)) + // If the member is a conversion operator the loc will be invalid. This + // causes the addToken function to

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:56 +if (isa(MD)) + // If the member is a conversion operator the loc will be invalid. This + /

[PATCH] D65941: [OpenCL] Fix lang mode predefined macros for C++ mode

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65941/new/ https://reviews.llvm.org/D65941 ___ cfe-commits mailing list cfe-commits@

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

hokein added a comment. please update the patch description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65928/new/ https://reviews.llvm.org/D65928 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang-tools-extra] r368282 - [clangd] Remove a function accidently being added in rL368261.

Author: hokein Date: Thu Aug 8 05:19:01 2019 New Revision: 368282 URL: http://llvm.org/viewvc/llvm-project?rev=368282&view=rev Log: [clangd] Remove a function accidently being added in rL368261. Modified: clang-tools-extra/trunk/clangd/AST.cpp Modified: clang-tools-extra/trunk/clangd/AST.cp

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:40 +TEST(PrintTemplateSpecializationArgs, PrintsTemplateArgs) { + TestTU TU; looks like the related tests are in `PrintASTTests.cpp`, could you move the test there? Re

[clang-tools-extra] r368283 - [clangd] Don't include internal gtest header.

Author: hokein Date: Thu Aug 8 05:33:12 2019 New Revision: 368283 URL: http://llvm.org/viewvc/llvm-project?rev=368283&view=rev Log: [clangd] Don't include internal gtest header. Modified: clang-tools-extra/trunk/clangd/unittests/PrintASTTests.cpp Modified: clang-tools-extra/trunk/clangd/uni

[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds a new HighlightingKind "Primitive". Adds a special case for TypeLocs that have an underlying TypePtr

[clang-tools-extra] r368287 - [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if underlying MemberDecl is a CXXConversionDecl.

Author: jvikstrom Date: Thu Aug 8 05:43:55 2019 New Revision: 368287 URL: http://llvm.org/viewvc/llvm-project?rev=368287&view=rev Log: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if underlying MemberDecl is a CXXConversionDecl. Summary: Conversion operators conta

[PATCH] D65938: [AST] No longer visiting CXXMethodDecl bodies created by compiler when method was default created.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:262 + struct $Class[[A]] { + $Class[[B]] $Field[[BB]]; +

[PATCH] D65928: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if the MemberLoc is invalid.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 2 inline comments as done. Closed by commit rL368287: [clangd] Added an early return from VisitMemberExpr in SemanticHighlighting if… (authored by jvikstrom, committed by ). Herald added a project: LLVM. Her

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. The `ExprWithCleanups` node is added to the AST along with the elidable CXXConstructExpr. If it is the outermost node of the node being matched, ignore it as well. Repository: rG LLVM Github Mon

[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, just a nit. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:138 +// Builtins must be special cased as they do not have a TagDecl. +if (const auto

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:175 +// Currently, we only support normal rename (one range) for C/C++. +// FIXME: support multiple-range rename for objective-c methods. +if (Rename.getNameRanges().size() > 1)

[PATCH] D65000: [ARM] Set default alignment to 64bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL368288: [ARM] Set default alignment to 64bits (authored by dnsampaio, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65000/new/ https://reviews.llvm.org/D650

r368288 - [ARM] Set default alignment to 64bits

Author: dnsampaio Date: Thu Aug 8 05:50:36 2019 New Revision: 368288 URL: http://llvm.org/viewvc/llvm-project?rev=368288&view=rev Log: [ARM] Set default alignment to 64bits Summary: The maximum alignment used by ARM arch is 64bits, not 128. This could cause overaligned memory access for 128 bit

[clang-tools-extra] r368291 - [clangd] Added semantic highlighting support for primitives.

Author: jvikstrom Date: Thu Aug 8 06:10:30 2019 New Revision: 368291 URL: http://llvm.org/viewvc/llvm-project?rev=368291&view=rev Log: [clangd] Added semantic highlighting support for primitives. Summary: Adds a new HighlightingKind "Primitive". Adds a special case for TypeLocs that have an und

[PATCH] D65943: [clangd] Added semantic highlighting support for primitives.

This revision was automatically updated to reflect the committed changes. jvikstrom marked an inline comment as done. Closed by commit rL368291: [clangd] Added semantic highlighting support for primitives. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscri

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments.

jvikstrom updated this revision to Diff 214132. jvikstrom marked 2 inline comments as done. jvikstrom added a comment. Merged test with PrintASTTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65926/new/ https://reviews.llvm.org/D65926 File

[PATCH] D65926: [clangd] Fixed printTemplateSpecializationArgs not printing partial variable specialization arguments.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/unittests/ASTTests.cpp:40 +TEST(PrintTemplateSpecializationArgs, PrintsTemplateArgs) { + TestTU TU; hokein wrote: > looks like the related tests are in `PrintASTTests.cpp`, could you move th

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6538 /// -/// In C++17 copy elidable constructors are no longer being -/// generated in the AST as it is

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

martong added a comment. Would it be an alternative solution if we imported the function parameters after we created the FunctionDecl? I guess it would be. Maybe that would result in a smaller change, what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

r368295 - [OPENMP]Add support for analysis of linear variables and step.

Author: abataev Date: Thu Aug 8 06:42:45 2019 New Revision: 368295 URL: http://llvm.org/viewvc/llvm-project?rev=368295&view=rev Log: [OPENMP]Add support for analysis of linear variables and step. Summary: Added support for basic analysis of the linear variables and linear step expression. Linear

[PATCH] D65461: [OPENMP]Add support for analysis of linear variables and step.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368295: [OPENMP]Add support for analysis of linear variables and step. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM C

[PATCH] D65936: [clangd] Use raw rename functions to implement the rename.

hokein marked 3 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:175 +// Currently, we only support normal rename (one range) for C/C++. +// FIXME: support multiple-range rename for objective-c methods. +i

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/test/Analysis/Inputs/ctu-other.cpp:135 + +struct DefParmContext { + static const int I; martong wrote: > shafik wrote: > > martong wrote: > > > Perhaps we could write `D

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

balazske added a comment. Yes importing the parameters should be doable after the create of the function. I am not sure if it fixes this problem, the parameter that has the default expression can still be encountered without the default expression set in it. Repository: rG LLVM Github Monore

r368301 - [FIX][NFC] Update clang sema test

Author: dnsampaio Date: Thu Aug 8 07:45:42 2019 New Revision: 368301 URL: http://llvm.org/viewvc/llvm-project?rev=368301&view=rev Log: [FIX][NFC] Update clang sema test Try to fix Sema test for default alignment for when compiling to ARM, but not to android, due r9427aa2d543b Modified: cfe

[PATCH] D65630: [PowerPC] Port SSE3, SSSE3 and SSE4 intrinsics to PowerPC.

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65630/new/ https://reviews.llvm.org/D65630 ___ cfe-commits maili

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny marked 2 inline comments as done. jdenny added a comment. In D65835#1619560 , @ABataev wrote: > In D65835#1619549 , @jdenny wrote: > > > In D65835#1619526 , @ABataev w

[PATCH] D65556: Phabricator D49466

dankm added a comment. In D65556#1610001 , @lebedev.ri wrote: > Please fix patch title and description Sorry, I'm going to delete this. It was supposed to be a new patchset on D49466 . Repository: rG LLVM Github Mono

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

ymandel updated this revision to Diff 214159. ymandel marked an inline comment as done. ymandel added a comment. Added test; adjusted comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65944/new/ https://reviews.llvm.org/D65944 Files: clang

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the comments. I struggled with the wording so your edits are appreciated. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6556 /// -/// ``varDecl(hasInitializer(any( -/// ignoringEli

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1621168 , @jdenny wrote: > In D65835#1619560 , @ABataev wrote: > > > In D65835#1619549 , @jdenny wrote: > > > > > In D65835#1619526

[PATCH] D57165: [FileManager] Revert r347205 to avoid PCH file-descriptor leak.

thakis added a comment. Herald added a project: clang. A few weeks later, I realize that since the test doesn't have a ".test" extension, it doesn't run on any bots. Could you rename it to leakfiles.test (or any other fitting extension listed in clang/test/lit.cfg.py's config.suffixes list)?

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:6556 /// -/// ``varDecl(hasInitializer(any( -/// ignoringElidableConstructorCall(callExpr()), -/// exprWithCleanups(ignoringElidableConstructo

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache updated this revision to Diff 214168. modocache marked 3 inline comments as done. modocache added a comment. Thanks for the review, @Quuxplusone! I addressed your test comments, but the 'co_yield' test is something I think I'll need to deal with separately. Repository: rG LLVM Githu

[PATCH] D65043: [Format] Add C++20 standard to style options

modocache added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:13780 + // In C++2a, it is interpreted as a prefix increment on 'i'. + verifyFormat("co_yield++ i;"); + verifyFormat("co_yield ++i;", Cpp2a); Quuxplusone wrote: > My comment htt

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D65956: clang: Diag running out of file handles while looking for files

thakis created this revision. thakis added a reviewer: rnk. clang would only print "file not found" when it's unable to find a header file. If the reason for that is a file handle leak, that's not a very useful error message. For errors that aren't in a small whitelist ("file not found", "file i

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 214169. svenvh added a comment. - Move checking of GenType compatibility from SemaLookup to TableGen emitter. - Provide more elaborate explanation about combining GenTypes in a declaration. - Add `max`/`min` definitions to cover "sgentype" behavior and add test

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:820 + llvm::DenseMap> + CompatibleAliases; `unordered_set`? Repository: rG LLVM Gith

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh marked 6 inline comments as done. svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:116 +// combination of Types and vector sizes. +// +// E.g.: If TypeListField = and VectorList = <1, 2, 4>, then Pierre wrote: > Maybe it would be

[PATCH] D62960: Add SVE opaque built-in types

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/AST/ASTContext.cpp:1974 + break; +#include "clang/Basic/AArch64SVEACLETypes.def" } rsandifo-arm wrote: > rjmccall wrote:

[PATCH] D65956: clang: Diag running out of file handles while looking for files

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65956/new/ https://reviews.llvm.org/D65956 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik commandeered this revision. denik added a reviewer: yunlian. denik added a comment. Herald added a project: clang. Taking ownership of the change as Yunlian is no longer working on this CL. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://re

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

gribozavr added a comment. In D65853#1619801 , @plotfi wrote: > I tested this out. Seems to work fine, and print the Expected's Error. I am > fine with it if @compnerd and @lhames and @jkorous are cool with it. @compnerd @lhames @jkorous ping? Reposit

[clang-tools-extra] r368313 - [clang-doc] Protect Index with mutex during reducing and generation stage

Author: diegoastiazaran Date: Thu Aug 8 10:14:17 2019 New Revision: 368313 URL: http://llvm.org/viewvc/llvm-project?rev=368313&view=rev Log: [clang-doc] Protect Index with mutex during reducing and generation stage Idx in ClangDocContext instance was being modified by multiple threads causing a

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

This revision was automatically updated to reflect the committed changes. Closed by commit rL368313: [clang-doc] Protect Index with mutex during reducing and generation stage (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka updated this revision to Diff 214183. vitalybuka added a comment. Fix https://godbolt.org/z/-PinQP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.llvm.org/D61879 Files: clang/test/CodeGenCXX/member-function-p

[PATCH] D65575: [analyzer] Mention whether an event is about a condition in a bug report part 1

Szelethus added a comment. In D65575#1611013 , @NoQ wrote: > Fantastic! Let's open the wording bikeshed season? > > I suspect that a simple "(The) Value -> Condition value" change would have > worked better. > > Another variant: "Value ..., which particip

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 | ++--+

r368319 - [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

Author: ymandel Date: Thu Aug 8 10:41:44 2019 New Revision: 368319 URL: http://llvm.org/viewvc/llvm-project?rev=368319&view=rev Log: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`. Summary: The `ExprWithCleanups` node is added to the AST along with the eli

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

ymandel updated this revision to Diff 214188. ymandel marked an inline comment as done. ymandel added a comment. updated HTML docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65944/new/ https://reviews.llvm.org/D65944 Files: clang/docs/LibAST

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:469-471 +extern void __assert_fail (__const char *__assertion, __const char *__file, + unsigned int __lin

[PATCH] D65944: [clang] Update `ignoringElidableConstructorCall` matcher to ignore `ExprWithCleanups`.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368319: [clang] Update `ignoringElidableConstructorCall` matcher to ignore… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.org/D65853 __

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Couldn't cross build users just pass -nostdsysteminc to tell clang to not look in system header locations? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 ___

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. The llvm-dev discussion is here http://lists.llvm.org/pipermail/llvm-dev/2019-July/134035.html I think the consensus is that it should be fine to change the data layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/n

r368322 - clang: Diag running out of file handles while looking for files

Author: nico Date: Thu Aug 8 10:58:32 2019 New Revision: 368322 URL: http://llvm.org/viewvc/llvm-project?rev=368322&view=rev Log: clang: Diag running out of file handles while looking for files clang would only print "file not found" when it's unable to find a header file. If the reason for tha

[PATCH] D65956: clang: Diag running out of file handles while looking for files

This revision was automatically updated to reflect the committed changes. Closed by commit rL368322: clang: Diag running out of file handles while looking for files (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368323 - Recommit Devirtualize destructor of final class.

Author: yamauchi Date: Thu Aug 8 11:00:49 2019 New Revision: 368323 URL: http://llvm.org/viewvc/llvm-project?rev=368323&view=rev Log: Recommit Devirtualize destructor of final class. Original patch commited as r364100, reverted as r364359, recommitted as r365509, reverted as r365850. Added:

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

lebedev.ri added a comment. Why do you need to change (update) the datalayout in every single test? That looks extremely noisy and hides the actually-needed changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/

  1   2   3   >