Szelethus marked an inline comment as done. Szelethus added inline comments.
================ Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:469-471 +extern void __assert_fail (__const char *__assertion, __const char *__file, + unsigned int __line, __const char *__function) +__attribute__ ((__noreturn__)); ---------------- Szelethus wrote: > NoQ wrote: > > Szelethus wrote: > > > NoQ wrote: > > > > I'm pretty sure you can define this function only once. > > > Note that it is in a namespace! > > I mean, why is it in a namespace? Why not just define it once for the whole > > file? It's not like you're gonna be trying out different variants of > > `__assert_fail`. > Yea, good point. Actually, I kinda like how a single namespace is a single test case, an all-in-one package. Do you insist? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65287/new/ https://reviews.llvm.org/D65287 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
