[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209376. quantum added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def clang/lib/CodeGen/

[clang-tools-extra] r365849 - [clangd] Add a missing early return in getTypeHierarchy()

Author: nridge Date: Thu Jul 11 17:24:45 2019 New Revision: 365849 URL: http://llvm.org/viewvc/llvm-project?rev=365849&view=rev Log: [clangd] Add a missing early return in getTypeHierarchy() Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags:

[PATCH] D64307: [clangd] Add a missing early return in getTypeHierarchy()

This revision was automatically updated to reflect the committed changes. Closed by commit rL365849: [clangd] Add a missing early return in getTypeHierarchy() (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

Nathan-Huckleberry created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Lexer::getLocForEndOfToken is defined to return an invalid location if the given location is inside a macro. Other checks conditionally warn based off location validity. Updat

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Sorry for the delay here. It'd be nice to land the LLVM patch first and with its own testing -- we should have testing for the pass builder independent of Clang (IE, in the LLV

[PATCH] D64598: fix unnamed fiefield issue and add tests for __builtin_preserve_access_index intrinsic

yonghong-song updated this revision to Diff 209379. yonghong-song added a subscriber: anakryiko. yonghong-song added a comment. change test case so we can test metadata is generated correctly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64598/new/ https://revie

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

Nathan-Huckleberry updated this revision to Diff 209381. Nathan-Huckleberry added a comment. - Ran git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 Files: clang-tools-extra/clang-tidy/bugp

r365850 - Re-Revert Devirtualize destructor of final class.

Author: rupprecht Date: Thu Jul 11 17:32:08 2019 New Revision: 365850 URL: http://llvm.org/viewvc/llvm-project?rev=365850&view=rev Log: Re-Revert Devirtualize destructor of final class. This reverts r365509 (git commit d088720edad9c29ee0d622b5d69092e18a9ac0bd) This is a second revert[1] due to f

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

chandlerc added a comment. Just to make sure we're on the same page (and sorry I didn't jump in sooner)... With the old PM, *anything* that is `always_inline` *gets* `instsimplify` run on it, even at -O0, even if you didn't want that. So using `-instsimplify` explicitly is, IMO, not any more sc

[PATCH] D64608: [OpenCL] Make TableGen'd builtin tables and helper functions static

tstellar created this revision. tstellar added reviewers: Pierre, Anastasia. Herald added a subscriber: yaxunl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64608 Files: clang/lib/Sema/SemaLookup.cpp clang/utils/TableGen/ClangOpenCLBuiltinEmi

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. > This change breaks building the Linux kernel for arm32 (at least): Follow up discussion in https://github.com/ClangBuiltLinux/linux/issues/598. I think the kernel is wrong here. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D645

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added a comment. ah, maybe the addition of `-no-integrated-as` shouldn't produce this error? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64527/new/ https://reviews.llvm.org/D64527 ___ cfe-commits mai

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

inglorion created this revision. inglorion added reviewers: tejohnson, rnk, pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, mehdi_amini. Herald added a project: clang. Previously, passing -fthinlto-index= to clang required that bitcode files be explicitly marked by -x ir. This chan

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. - Correctly display macro expansion and spelling locations. - Use the

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nickdesaulniers added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555 + // in -E mode either for example, even though it's not really used either. + if (!isa(JA)) { +ArgStringList DummyArgs; Should you be checking `!TC.IsIntegrat

[PATCH] D64610: [clang] allow -fthinlto-index= without -x ir

inglorion added a comment. This was suggested on D64458 . If we take this change, D64458 can be simplified to just accepting -fthinlto-index= as a CoreOption without needing any further changes to Driver.cpp. I also changed the

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

rnk added a comment. I think the intention of this change was to ignore assembler flags in pre-processing actions without warning about them. It implements that behavior by running the code that gathers and validates assembler flags. The validation is whats emitting the problematic errors. I do

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum updated this revision to Diff 209391. quantum marked 10 inline comments as done. quantum added a comment. Apply review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64537/new/ https://reviews.llvm.org/D64537 Files: clang/include

[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

quantum marked 28 inline comments as done. quantum added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:33 +// Thread-local storage +TARGET_BUILTIN(__builtin_wasm_tls_size, "z", "nc", "bulk-memory") + tlively wrote: > quantum wrote

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Much better! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611 __

Re: [PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

Yes, the current behavior is erroring for assembler flags clang does not recognize, which is irrelevant when compiling with `-no-integrated-as`, which is breaking our assembler flag feature detection in building the Linux kernel. On Thu, Jul 11, 2019, 6:09 PM Reid Kleckner via Phabricator < revi..

r365857 - Codegen, NFC: 32bit test in auto-var-init.cpp

Author: vitalybuka Date: Thu Jul 11 18:36:11 2019 New Revision: 365857 URL: http://llvm.org/viewvc/llvm-project?rev=365857&view=rev Log: Codegen, NFC: 32bit test in auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp Modified: cfe/trunk/test/CodeGenCXX/auto-var-init.cpp U

r365858 - Handle IntToPtr in isBytewiseValue

Author: vitalybuka Date: Thu Jul 11 18:42:03 2019 New Revision: 365858 URL: http://llvm.org/viewvc/llvm-project?rev=365858&view=rev Log: Handle IntToPtr in isBytewiseValue Summary: This helps with more efficient use of memset for pattern initialization From @pcc prototype for -ftrivial-auto-var-

[PATCH] D63967: Handle IntToPtr in isBytewiseValue

This revision was automatically updated to reflect the committed changes. Closed by commit rL365858: Handle IntToPtr in isBytewiseValue (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D63967?vs=207180&id=209394#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer

MaskRay updated this revision to Diff 209396. MaskRay marked 2 inline comments as done. MaskRay retitled this revision from "[Driver] Consolidate shouldUseFramePointer() and shouldUseLeafFramePointer()" to "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-p

r365860 - [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

Author: maskray Date: Thu Jul 11 19:01:51 2019 New Revision: 365860 URL: http://llvm.org/viewvc/llvm-project?rev=365860&view=rev Log: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer Use a tri-state enum to represent shouldUseFramePointer() and

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

MaskRay updated this revision to Diff 209398. MaskRay retitled this revision from "[Driver] Refactor interaction between -f(no-)omit-frame-pointer and -mno-omit-leaf-frame-pointer" to "[Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer". MaskRay

[PATCH] D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rL365860: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)? (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

r365861 - [analyzer] exploded-graph-rewriter: Improve source location dumps.

Author: dergachev Date: Thu Jul 11 19:10:33 2019 New Revision: 365861 URL: http://llvm.org/viewvc/llvm-project?rev=365861&view=rev Log: [analyzer] exploded-graph-rewriter: Improve source location dumps. - Correctly display macro expansion and spelling locations. - Use the same procedure to displa

[PATCH] D64611: [analyzer] exploded-graph-rewriter: Improve source location dumps.

NoQ closed this revision. NoQ added a comment. Whoops, forgot the phabricator link. Committed as rC365861 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64611/new/ https://reviews.llvm.org/D64611

r365862 - [PowerPC] Default to -fomit-frame-pointer when optimization is enabled

Author: maskray Date: Thu Jul 11 19:14:08 2019 New Revision: 365862 URL: http://llvm.org/viewvc/llvm-project?rev=365862&view=rev Log: [PowerPC] Default to -fomit-frame-pointer when optimization is enabled NetBSD, Linux, CloudABI and Hurd already omit frame pointer for PowerPC. Make it do so for o

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka added a comment. In D64597#1581654 , @jfb wrote: > In D64597#1581605 , @pcc wrote: > > > The problem with `0x` on 32-bit is that it is likely to be a valid > > address. > > > > When I discussed t

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

MaskRay added a comment. I did this in rC365862 with a test after my refactoring of the interface rC365860 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60335/new/ https://reviews.llvm.org/

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209400. vitalybuka added a comment. 0x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeGenCXX/aut

r365863 - NFC: Unforget a colon in a few CHECK: directives.

Author: dergachev Date: Thu Jul 11 19:16:56 2019 New Revision: 365863 URL: http://llvm.org/viewvc/llvm-project?rev=365863&view=rev Log: NFC: Unforget a colon in a few CHECK: directives. Differential Revision: https://reviews.llvm.org/D64526 Modified: cfe/trunk/test/Analysis/cfg-rich-construc

[PATCH] D64597: CodeGet: Init 32bit pointers with 0xFFFFFFFF

vitalybuka updated this revision to Diff 209401. vitalybuka added a comment. undo unrelated line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64597/new/ https://reviews.llvm.org/D64597 Files: clang/lib/CodeGen/PatternInit.cpp clang/test/CodeG

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

NoQ added a comment. Thanks all! I guess i'll commit. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64526/new/ https://reviews.llvm.org/D64526 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL365863: NFC: Unforget a colon in a few CHECK: directives. (authored by dergachev, committed by ). Herald added a subscribe

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

MaskRay updated this revision to Diff 209404. MaskRay added a comment. Use A->render(Args, CmdArgs); Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64277/new/ https://reviews.llvm.org/D64277 Files: include/clang/Driver/Options.td lib/Basic/TargetInfo.cp

r365866 - [X86][PowerPC] Support -mlong-double-128

Author: maskray Date: Thu Jul 11 19:32:15 2019 New Revision: 365866 URL: http://llvm.org/viewvc/llvm-project?rev=365866&view=rev Log: [X86][PowerPC] Support -mlong-double-128 This patch makes the driver option -mlong-double-128 available for X86 and PowerPC. The CC1 option -mlong-double-128 is av

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

This revision was automatically updated to reflect the committed changes. Closed by commit rL365866: [X86][PowerPC] Support -mlong-double-128 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

rjmccall added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturnLoc().getBeginLoc(), Anastas

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

MaskRay added a comment. This should be rebased after D64294 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cf

[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

rjmccall added a comment. There are some code paths that I think are common between the parser and template instantiation, like `BuildPointerType` and `BuildReferenceType`, but if you want to do context-sensitive inference that might not be good enough. CHANGES SINCE LAST ACTION https://revi

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. The followup patch for this change is at https://reviews.llvm.org/D64598. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits mailing

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6587 +return; + } + Mordante wrote: > rjmccall wrote: > > Comment indentation. > > > > Should we do this when starting to parse a function prototype instead of > > when parsi

[clang-tools-extra] r365867 - [clangd] Implement typeHierarchy/resolve for subtypes

Author: nridge Date: Thu Jul 11 20:26:32 2019 New Revision: 365867 URL: http://llvm.org/viewvc/llvm-project?rev=365867&view=rev Log: [clangd] Implement typeHierarchy/resolve for subtypes Summary: This allows the client to resolve subtypes one level at a time. For supertypes, this is not necessar

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

This revision was automatically updated to reflect the committed changes. nridge marked 3 inline comments as done. Closed by commit rL365867: [clangd] Implement typeHierarchy/resolve for subtypes (authored by nridge, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-com

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64613 Files: clang-tools-extra/clangd/XR

[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/test/type-hierarchy.test:1 # RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPa

[PATCH] D64613: [clangd] Type hierarchy: don't resolve parents if the client only asked for children

nridge added a comment. This is an issue I noticed while writing the unit test for D64308 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64613/new/ https://reviews.llvm.org/D64613 __

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D64614 Files: clang-tools-extra/docs/clan

[PATCH] D64614: [clangd] Mark type hierarchy as a supported feature in the docs

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:264 +-++--+ -| Type hierarchy | No | No | +| Type hierarchy

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Charusso accepted this revision. Charusso added a comment. The `impure-warning` sounds like some alpha, not-well-defined warning, other than that I like the movement to rethink existing checkers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64274/new/ https://reviews.llvm.org/D64274

r365872 - test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available

Author: maskray Date: Thu Jul 11 22:51:36 2019 New Revision: 365872 URL: http://llvm.org/viewvc/llvm-project?rev=365872&view=rev Log: test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available Follow-up of D64317/r365587. Modified: cfe/trunk/test/Dri

r365873 - [test] Delete trailing spaces from YAML tests

Author: maskray Date: Thu Jul 11 22:59:28 2019 New Revision: 365873 URL: http://llvm.org/viewvc/llvm-project?rev=365873&view=rev Log: [test] Delete trailing spaces from YAML tests Modified: cfe/trunk/unittests/Tooling/DiagnosticsYamlTest.cpp cfe/trunk/unittests/Tooling/RefactoringActionRu

[clang-tools-extra] r365874 - [test] Delete trailing spaces from YAML tests after D65566/r365869

Author: maskray Date: Thu Jul 11 23:01:37 2019 New Revision: 365874 URL: http://llvm.org/viewvc/llvm-project?rev=365874&view=rev Log: [test] Delete trailing spaces from YAML tests after D65566/r365869 Modified: clang-tools-extra/trunk/test/clang-include-fixer/merge.test clang-tools-extra/

[PATCH] D64607: [clang-tidy] Fix crash on end location inside macro

lebedev.ri added a comment. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64607/new/ https://reviews.llvm.org/D64607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

r365877 - [Driver] Delete --no-add-needed for RHEL7 or newer

Author: maskray Date: Thu Jul 11 23:46:47 2019 New Revision: 365877 URL: http://llvm.org/viewvc/llvm-project?rev=365877&view=rev Log: [Driver] Delete --no-add-needed for RHEL7 or newer This is really not needed. gcc driver doesn't add this option. BTW, since binutils 2.22, --no-copy-dt-needed-ent

Re: r364424 - [clang/DIVar] Emit the flag for params that have unmodified value

Hi Vedant, This looks good! Thanks! Regards, Djordje On 11.7.19. 02:11, Vedant Kumar wrote: > Hi Djordje, > > Just a heads-up that I’ve landed r365716 to fix a crash in a stage2 build of > AppleClang with -femit-debug-entry-values enabled. > > I went ahead and landed the fix as it seemed simp

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom updated this revision to Diff 209139. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Moved alias target namespace add token to another function and added testcase for global namespace specifier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:87 + bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNSLoc) { +if (NestedNameSpecifier *NNS = NNSLoc.getNestedNameSpecifier()) + if (NNS->getKind() == NestedNameSp

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

hokein added a comment. Thanks for bringing this up and implementing it. I haven't looked into the details of the patch, just some high-level comments: - the scope of the patch seems a bit unclear to me, what's the problem we are trying to solve? - the patch looks like calculating the diff/delt

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); r

[PATCH] D63503: cmake: Add CLANG_LINK_CLANG_DYLIB option

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63503/new/ https://reviews.llvm.org/

[PATCH] D61909: Add Clang shared library with C++ exports

aheejin added a comment. `CLANG_LINK_CLANG_DYLIB=ON` does not seem to work with `LLVM_INSTALL_TOOLCHAIN_ONLY=ON`. I filed a bug report: https://bugs.llvm.org/show_bug.cgi?id=42575 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://reviews.llvm.org

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side, just a comment for the TM scope name. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:73 // This check is for not getting two entr

[PATCH] D64527: driver: Don't warn about assembler flags being unused when not assembling

nathanchance added a comment. This change breaks building the Linux kernel for arm32 (at least): ... YACCscripts/dtc/dtc-parser.tab.c HOSTCC scripts/dtc/yamltree.o HOSTCC scripts/dtc/dtc-parser.tab.o HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTLD scripts/dtc/dtc UPD

[clang-tools-extra] r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

r365742 - Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."

Author: hokein Date: Thu Jul 11 01:54:28 2019 New Revision: 365742 URL: http://llvm.org/viewvc/llvm-project?rev=365742&view=rev Log: Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class." This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df

[clang-tools-extra] r365745 - [clangd] Added highlightings for namespace specifiers.

Author: jvikstrom Date: Thu Jul 11 02:29:16 2019 New Revision: 365745 URL: http://llvm.org/viewvc/llvm-project?rev=365745&view=rev Log: [clangd] Added highlightings for namespace specifiers. Summary: Added highlightings for namespace specifiers. Reviewers: hokein, sammccall, ilya-biryukov Subsc

[PATCH] D64492: [clangd] Added highlightings for namespace specifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365745: [clangd] Added highlightings for namespace specifiers. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D64495: [AArch64] Implement __jcvt intrinsic from Armv8.3-A

ktkachov updated this revision to Diff 209149. ktkachov added a comment. Fix comments plus an offline comment I had (copy-pasto in an assert message) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64495/new/ https://reviews.llvm.org/D64495 Files: clang/include/clang/Basic/BuiltinsAArc

[clang-tools-extra] r365748 - [clangd] Reland rL365634

Author: kadircet Date: Thu Jul 11 02:54:31 2019 New Revision: 365748 URL: http://llvm.org/viewvc/llvm-project?rev=365748&view=rev Log: [clangd] Reland rL365634 This was reverted in rL365678, the failure was due to YAML parsing of compile_commands.json. Converting backslashes to forward slashes t

[clang-tools-extra] r365751 - [clangd] Add a missing "return nullptr; " to the SelectionTree::commonAncestor.

Author: hokein Date: Thu Jul 11 03:06:24 2019 New Revision: 365751 URL: http://llvm.org/viewvc/llvm-project?rev=365751&view=rev Log: [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor. This would fix some mysterious crashes on codeAction in clangd. Modified: clang-

[PATCH] D64475: [clangd] Duplicate lines of semantic highlightings sent removed.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:172 + const HighlightingToken &Rhs) { + return Lhs.R.start.line == Rhs.R.start.line + ? Lhs.R.start.character < Rhs.R.start.character -

[PATCH] D64540: [CGDebugInfo] Simplfiy EmitFunctionDecl parameters, NFC

djtodoro accepted this revision. djtodoro added a comment. This revision is now accepted and ready to land. LGTM! Thanks @vsk! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64540/new/ https://reviews.llvm.org/D64540 ___ cfe-commits mailing

[clang-tools-extra] r365756 - [clangd] Fix windows buildbots

Author: kadircet Date: Thu Jul 11 03:41:58 2019 New Revision: 365756 URL: http://llvm.org/viewvc/llvm-project?rev=365756&view=rev Log: [clangd] Fix windows buildbots Modified: clang-tools-extra/trunk/clangd/unittests/GlobalCompilationDatabaseTests.cpp Modified: clang-tools-extra/trunk/clang

[PATCH] D64554: [CrossTU] Add a function to retrieve original source location.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. A new function will be added to get the original SourceLocation for a SourceLocation that was impor

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein created this revision. hokein added reviewers: sammccall, SureYeaah. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should use getTypePtrOrN

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:367 } - return nullptr; } sorry, the previous patch rL365751 didn't fix the crash, and I re-read the code more thoroughly, I think we w

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Selection.cpp:361 return nullptr; for (const Node *Ancestor = Root;; Ancestor = Ancestor->Children.front()) { +asse

[PATCH] D64482: [Driver] Define _FILE_OFFSET_BITS=64 on Solaris

ro added a comment. In D64482#1579850 , @MaskRay wrote: > > Honestly I find such enforced C/C++ difference very unfortunate... e.g. > > if (Opts.CPlusPlus) > Builder.defineMacro("_GNU_SOURCE"); You may not like them, but there are plenty of exa

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

hokein updated this revision to Diff 209172. hokein marked an inline comment as done. hokein added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64556/new/ https://reviews.llvm.org/D64556 Files: clang-tools-extra/clan

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby created this revision. DavidTruby added a reviewer: ABataev. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section 2.

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8114 + } else { +LValue VarLVal = CGF.EmitLValueForField(VDLVal, It->second); +RValue VarRVal = CGF.EmitLoadOfLValue(VarLVal, RD->getLocation()); I think you csn use `

[clang-tools-extra] r365763 - [clangd] Fix an assertion crash in "ExtractVariable" tweak

Author: hokein Date: Thu Jul 11 05:29:01 2019 New Revision: 365763 URL: http://llvm.org/viewvc/llvm-project?rev=365763&view=rev Log: [clangd] Fix an assertion crash in "ExtractVariable" tweak Summary: GetTypePtr requires that the type should not be null, otherwise we hit an assertion, we should u

[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rL365763: [clangd] Fix an assertion crash in "ExtractVariable" tweak (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby updated this revision to Diff 209184. DavidTruby added a comment. Moved common VarLVal initialisation out of the if/else statement CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/

[clang-tools-extra] r365764 - [clangd] Remove the extra ";", NFC

Author: hokein Date: Thu Jul 11 05:31:18 2019 New Revision: 365764 URL: http://llvm.org/viewvc/llvm-project?rev=365764&view=rev Log: [clangd] Remove the extra ";", NFC Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp Modified: clang-tools-extra/trunk/clangd/unittests/TestFS.cpp

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

DavidTruby added a comment. I don't have commit access so can't commit this myself, could you do it for me? Thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list cfe-co

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[]

[PATCH] D64489: [clangd][QueryDriver] Use language from underlying database if possible

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/QueryDriverDatabase.cpp:121 // Should we also preserve flags like "-sysroot", "-nostdinc" ? - const llvm::StringRef Args[] = { - Driver, "-E", "-x", driver::ty

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Fixed toHalfOpenFileRange to work for macros as well as template instantiations - Added unit tests

[PATCH] D64563: Updated the signature for some stack related intrinsics (CLANG)

cdevadas created this revision. cdevadas added a reviewer: arsenm. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch includes the intrinsics int_addressofreturnaddress, int_frameaddress & int_sponentry. This patch should go along with the changes in https://re

[PATCH] D64562: [clangd] Fixed toHalfOpenFileRange

SureYeaah updated this revision to Diff 209193. SureYeaah added a comment. Minor fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64562/new/ https://reviews.llvm.org/D64562 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-extra/cl

[PATCH] D64564: Loop pragma parsing. NFC.

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: samparker, dmgreen, Meinersbur. Yesterday I was a bit distracted by loop pragma parsing (D64471 ), but still am a bit today too (this patch). https://reviews.llvm.org/D64564 Files: clang/lib/Pa

[PATCH] D64329: [Clangd] Fixed SelectionTree bug for macros

SureYeaah updated this revision to Diff 209199. SureYeaah marked 6 inline comments as done. SureYeaah added a comment. Changed claimRange to use toHalfOpenFileRange Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64329/new/ https://reviews.llvm.org/D

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added a comment. In D64558#1580361 , @DavidTruby wrote: > I don't have commit access so can't commit this myself, could you do it for > me? Thanks Sure, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ ht

<    1   2   3   >