rnk added a comment.
I think the intention of this change was to ignore assembler flags in
pre-processing actions without warning about them. It implements that behavior
by running the code that gathers and validates assembler flags. The validation
is whats emitting the problematic errors. I don't think that's desirable, so
I'd recommend reverting for now.
================
Comment at: cfe/trunk/lib/Driver/ToolChains/Clang.cpp:3555
+ // in -E mode either for example, even though it's not really used either.
+ if (!isa<AssembleJobAction>(JA)) {
+ ArgStringList DummyArgs;
----------------
nickdesaulniers wrote:
> Should you be checking `!TC.IsIntegratedAssemblerDefault()` additionally?
I don't think so. We want to ignore assembler flags in a preprocessor action
even if we're not going to use the integrated assembler.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64527/new/
https://reviews.llvm.org/D64527
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
