[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5625 + "evaluate to 'true'">, + InGroup; + xbolva00 wrote: > aaron.ballman wrote: > > xbolva00 wrote: > > > aaron.ballman wrote: > > > > This one seems like it should be

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

kzhuravl added subscribers: b-sumner, kzhuravl. kzhuravl added a comment. + @b-sumner Comment at: cfe/trunk/lib/Headers/opencl-c.h:13638-13640 -#ifndef ATOMIC_VAR_INIT -#define ATOMIC_VAR_INIT(x) (x) -#endif //ATOMIC_VAR_INIT Any reason this piece of code got c

[PATCH] D63161: Devirtualize destructor of final class.

yamauchi updated this revision to Diff 206053. yamauchi marked 2 inline comments as done. yamauchi added a comment. Comments addressed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63161/new/ https://reviews.llvm.org/D63161 Files: lib/CodeGen/CGExprCXX.cpp

r364100 - Devirtualize destructor of final class.

Author: yamauchi Date: Fri Jun 21 13:04:29 2019 New Revision: 364100 URL: http://llvm.org/viewvc/llvm-project?rev=364100&view=rev Log: Devirtualize destructor of final class. Summary: Take advantage of the final keyword to devirtualize destructor calls. Fix https://bugs.llvm.org/show_bug.cgi?id=

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5625 + "evaluate to 'true'">, + InGroup; + aaron.ballman wrote: > xbolva00 wrote: > > aaron.ballman wrote: > > > xbolva00 wrote: >

[PATCH] D63161: Devirtualize destructor of final class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364100: Devirtualize destructor of final class. (authored by yamauchi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D63174: [clang][NewPM] Add RUNS for tests that produce slightly different IR under new PM

leonardchan added a comment. In D63174#1553096 , @craig.topper wrote: > I'm going to try to work on the X86 tests. Can we hold off on committing > those? Ok. For now I'll just commit the convergent.cl test separately. Repository: rG LLVM Github Mon

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: mgorny. Templates are added to create a stuctured HTML file. Commands in doxygen comments are still not han

r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

Author: rsmith Date: Fri Jun 21 13:20:21 2019 New Revision: 364102 URL: http://llvm.org/viewvc/llvm-project?rev=364102&view=rev Log: Fix __has_cpp_attribute expansion to produce trailing L and (where necessary) leading whitespace. Simplify unit test and extend to cover no_unique_address attribute

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

chandlerc added a comment. FWIW, I think we can wait for a bug to be filed or report come in with some functional test case before we change any behavior here. I'm just suggesting how to make the test better below. Comment at: llvm/lib/Passes/PassBuilder.cpp:665-668 +// W

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:665-668 +// We must also remove exception handling before attaching sample profile +// data. +MPM.addPass( +createModuleToPostOrderCGSCCPassAdaptor(PostOrderFunctionAttrsPass())); -

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan updated this revision to Diff 206065. leonardchan marked 2 inline comments as done. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63626/new/ https://reviews.llvm.org/D63626 Files: clang/

r364103 - PR42301: Abort cleanly if we encounter a huge source file rather than

Author: rsmith Date: Fri Jun 21 13:46:22 2019 New Revision: 364103 URL: http://llvm.org/viewvc/llvm-project?rev=364103&view=rev Log: PR42301: Abort cleanly if we encounter a huge source file rather than crashing. Ideally we wouldn't care about the size of a file so long as it fits in memory, but

r364104 - clang-format a block; NFC

Author: gbiv Date: Fri Jun 21 13:49:47 2019 New Revision: 364104 URL: http://llvm.org/viewvc/llvm-project?rev=364104&view=rev Log: clang-format a block; NFC The indentation of the return here was off, and confusing as a result. Cleaned up a bit extra while I was in the area. Modified: cfe/tr

[PATCH] D63256: [OpenCL] Split type and macro definitions into opencl-c-base.h

yaxunl added inline comments. Comment at: cfe/trunk/lib/Headers/opencl-c.h:13638 #if __OPENCL_C_VERSION__ >= CL_VERSION_2_0 -#ifndef ATOMIC_VAR_INIT -#define ATOMIC_VAR_INIT(x) (x) kzhuravl wrote: > Any reason this piece of code got completely removed? Removing

[PATCH] D63666: [clang-doc] Add templates to HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:59 + Items += + applyHTMLTemplate(HTMLTemplates::BlockItem, M.str().str().c_str()); +} Put `FIXME: Transition Members from llvm::SmallString to std::st

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak updated this revision to Diff 206070. llunak retitled this revision from "make -frewrite-includes handle __has_include wrapped in a macro" to "make -frewrite-includes also rewrite conditions in #if/#elif". llunak edited the summary of this revision. Repository: rC Clang CHANGES SINCE

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5625 + "evaluate to 'true'">, + InGroup; + xbolva00 wrote: > aaron.ballman wrote: > > xbolva00 wrote: > > > aaron.ballman wrote: >

[PATCH] D63508: make -frewrite-includes also rewrite conditions in #if/#elif

llunak added a comment. Implemented in the current version of the patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63508/new/ https://reviews.llvm.org/D63508 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 updated this revision to Diff 206075. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Analysis/misc-ps.c te

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

rsmith added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:223 +def note_constexpr_bit_cast_invalid_type : Note< + "cannot constexpr evaluate a bit_cast with a " + "%select{union|pointer|member pointer|volatile|struct with a reference member}0" -

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

rsmith added inline comments. Comment at: include/clang/AST/Decl.h:4303 + + StringLiteral *getSTLUuid() { return STLUuid; } +}; What does "STL" mean here? Comment at: include/clang/Sema/ParsedAttr.h:337-346 + /// Constructor for __declspec(u

[PATCH] D62825: [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:223 +def note_constexpr_bit_cast_invalid_type : Note< + "cannot constexpr evaluate a bit_cast with a " + "%select{union|pointer|member pointer|volatile|struct with a reference member

[clang-tools-extra] r364106 - [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

Author: mgehre Date: Fri Jun 21 14:30:25 2019 New Revision: 364106 URL: http://llvm.org/viewvc/llvm-project?rev=364106&view=rev Log: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code Summary: The fixit `int square(int /*num*/)` yields `error: parameter name omitted

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

This revision was automatically updated to reflect the committed changes. Closed by commit rL364106: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

NoQ added a comment. In D62883#1553248 , @Szelethus wrote: > - Add a `TODO:` in `trackExpressionValue` about maybe tracking conditions to > all bug locations, rather than only for tracked variables. What do you mean by "all bug locations"? ==

Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

Hello Richard, This commit added broken test to the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26522 . . . Failing Tests (2): Clang :: Preprocessor/has_attribute.cpp . . . Please have a look? The builder was already red and did not

[PATCH] D63636: [PowerPC][Altivec] Fix offsets for vec_xl and vec_xst

jsji added a comment. A few questions. Comment at: lib/Headers/altivec.h:16364 signed short *__ptr) { - return *(unaligned_vec_sshort *)(__ptr + __offset); + signed char *Adjusted = (signed char *)__ptr + __offset; + ret

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:21 namespace { Anonymous namespace is used for functions when LLVM Coding Guidelines tells using static for same purpose. Comment at: clang-to

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

Szelethus added a comment. In D62883#1554339 , @NoQ wrote: > In D62883#1553248 , @Szelethus wrote: > > > - Add a `TODO:` in `trackExpressionValue` about maybe tracking conditions > > to all bug locations, rather th

r364108 - Fix has_attribute.cpp test on Windows after r364102

Author: rnk Date: Fri Jun 21 15:28:52 2019 New Revision: 364108 URL: http://llvm.org/viewvc/llvm-project?rev=364108&view=rev Log: Fix has_attribute.cpp test on Windows after r364102 Modified: cfe/trunk/test/Preprocessor/has_attribute.cpp Modified: cfe/trunk/test/Preprocessor/has_attribute.cp

r364109 - Ensure Target Features always_inline error happens in C++ cases.

Author: erichkeane Date: Fri Jun 21 15:29:32 2019 New Revision: 364109 URL: http://llvm.org/viewvc/llvm-project?rev=364109&view=rev Log: Ensure Target Features always_inline error happens in C++ cases. A handful of C++ cases as reported in PR42352 didn't actually give an error when always_inlinin

Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

I added -P to remove the line markers which were introducing the colons. On Fri, Jun 21, 2019 at 2:58 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit added broken test to the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x8

r364110 - Remove binary finally accidentially committed in r364109

Author: erichkeane Date: Fri Jun 21 15:31:59 2019 New Revision: 364110 URL: http://llvm.org/viewvc/llvm-project?rev=364110&view=rev Log: Remove binary finally accidentially committed in r364109 Removed: cfe/trunk/test/CodeGenCXX/target-builtin-error.o Removed: cfe/trunk/test/CodeGenCXX/targe

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

dyung created this revision. dyung added reviewers: ro, rnk, jkorous. dyung added a project: clang. Herald added subscribers: dexonsmith, fedor.sergeev. This is a follow up to D63600 that attempts to fix the test to work on all platforms including Windows (which

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

dyung added a comment. In D63600#1554029 , @rnk wrote: > This causes the test to fail on Windows: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/7712 > > There seems to be something wrong with the blamelist, so it didn't send > email.

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

I see Reid has reverted your original fix so instead of directly submitting, I have put the patch up for review first at https://reviews.llvm.org/D63678. Douglas Yung -Original Message- From: Rainer Orth Sent: Friday, June 21, 2019 14:46 To: Yung, Douglas Cc: cfe-commits@lists.llvm.or

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

NoQ accepted this revision. NoQ added a comment. Aha, ok, got it. I guess the official term is "error node" (where "error" means "warning"). Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:1-8 +// RUN: %clang_analyze_cc1 %s -verify -DTRACKING_CONDITIONS

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

NoQ added a comment. It should be pretty easy to implement, just add your new visitor to the list of default visitors in `findValidReport()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 _

[PATCH] D63642: [analyzer] Add a debug analyzer config to place an event for each tracked condition

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha, yep, nice debug flag! Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:16 +// RUN: %clang_analyze_cc1 %s -verify \ +// RUN: -DTRACKING_CONDITIONS -DTR

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

rnk added a comment. I would almost prefer to XFAIL this on Solaris, I feel like the intent is clearer with echo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63678/new/ https://reviews.llvm.org/D63678 ___ cfe-commits mailing list cfe-com

Re: r363975 - [clang-tidy] Fail gracefully upon empty database fields

Hello Serge, This commit added broken test to the builder: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26525 . . . Failing Tests (2): Clang Tools :: clang-tidy/empty-database.cpp . . . Please have a look? The builder was already red and did n

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:307-308 + + + +f juliehockett wrote: > Emitting an extra div here? The first div is emitted by the Mai

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

Szelethus added a comment. Woohoo! Thanks for everything, this is the most fun I've had working on this project! Let's wait for @xazax.hun to have the final say. In D62883#1554494 , @NoQ wrote: > It should be pretty easy to implement, just add your new v

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

ro added a comment. In D63678#1554508 , @rnk wrote: > I would almost prefer to XFAIL this on Solaris, I feel like the intent is > clearer with echo. Please have a look at what the autoconf manual has to say on echo vs. printf: https://www.gnu.org/savan

[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:1-8 +// RUN: %clang_analyze_cc1 %s -verify -DTRACKING_CONDITIONS \ +// RUN: -analyzer-config track-conditions=true \ +// RUN: -

[PATCH] D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris

rnk added a comment. In D63678#1554513 , @ro wrote: > Please have a look at what the autoconf manual has to say on echo vs. printf: Yikes, fair enough. I actually really wish lit had some support for the here-document pattern: cat

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

nicolas added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D63617: [COFF, ARM64] Fix encoding of __debugbreak

TomTan abandoned this revision. TomTan added a comment. The fix in LLVM was merged as https://reviews.llvm.org/rL364115. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63617/new/ https://reviews.llvm.org/D63617 ___ cf

[PATCH] D63681: [clang-scan-deps] Introduce the DependencyScanning library with the thread worker code and better error handling

arphaman created this revision. arphaman added reviewers: Bigcheese, aganea. Herald added subscribers: tschuett, dexonsmith, jkorous, mgorny. Herald added a project: clang. This patch extracts out the code that will powers the fast scanning worker into a new file in a new DependencyScanning libra

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran updated this revision to Diff 206103. DiegoAstiazaran marked 4 inline comments as done. DiegoAstiazaran added a comment. Add FIXME comments for llvm::SmallString to std::string transition. Add check so ParagraphComment template is not generated if its content would be empty. Fix t

[PATCH] D63666: [clang-doc] Add templates to HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/HTMLGeneratorTest.cpp:313-314 + + + + Brief description. juliehockett wrote: > Emitting extra div/p here? Add a check in the comment generation bit to > ensure you're not em

r364119 - [ODRHash] Skip some typedef types.

Author: rtrieu Date: Fri Jun 21 17:32:19 2019 New Revision: 364119 URL: http://llvm.org/viewvc/llvm-project?rev=364119&view=rev Log: [ODRHash] Skip some typedef types. In some cases, a typedef only strips aways a keyword for a type, keeping the same name as the root record type. This causes some

[clang-tools-extra] r364120 - [NFC] Marking test added in r363975 as unsupported on Windows.

Author: dyung Date: Fri Jun 21 18:09:00 2019 New Revision: 364120 URL: http://llvm.org/viewvc/llvm-project?rev=364120&view=rev Log: [NFC] Marking test added in r363975 as unsupported on Windows. This test references a path that does not exist on Windows causing it to emit different output from wh

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63626/new/ https://reviews.llvm.org/D63626 _

r364123 - AMDGPU: Fix target builtins for gfx10

Author: arsenm Date: Fri Jun 21 18:30:00 2019 New Revision: 364123 URL: http://llvm.org/viewvc/llvm-project?rev=364123&view=rev Log: AMDGPU: Fix target builtins for gfx10 This wasn't setting some of the features from older generations. Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe

[PATCH] D63649: AMDGPU: Fix target builtins for gfx10

arsenm closed this revision. arsenm added a comment. r364123 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63649/new/ https://reviews.llvm.org/D63649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D63462: [analyzer] JsonSupport: Escape escapes

NoQ added a comment. I guess let's add a test for the unicode problem that you're seeing. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63462/new/ https://reviews.llvm.org/D63462 ___ cfe-commits mailing list cfe-comm

[PATCH] D63438: [analyzer] print() JSONify: ProgramPoint revision

NoQ added a comment. Pls commit? ^.^ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63438/new/ https://reviews.llvm.org/D63438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D63684: [analyzer] exploded-graph-rewriter: NFC: Extract some code into functions.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Even though this code is not duplicated yet, follow-up patches will de

[PATCH] D63685: [analyzer] exploded-graph-rewriter: Add support for range constraints.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D63684: [a

<    1   2