ro added a comment. In D63678#1554508 <https://reviews.llvm.org/D63678#1554508>, @rnk wrote:
> I would almost prefer to XFAIL this on Solaris, I feel like the intent is > clearer with echo. Please have a look at what the autoconf manual has to say on echo vs. printf: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/autoconf.html#Limitations-of-Builtins That's the reason configure has switched to use printf instead, which my testing in https://reviews.llvm.org/D63600 confirms: echo is a nightmare in cross-platform use. Besides, there are already many uses of `printf` in the testsuite, so there's no reason to be reluctant about this one. Besides, there's no reason whatsoever that the test wouldn't fail again on the next target due to issues with echo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63678/new/ https://reviews.llvm.org/D63678 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
