[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Sounds safe enough to me. I think that it would be nice to add a test that checks the hexagon flags as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D37813: clang-format: better handle namespace macros

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: unittests/Format/NamespaceEndCommentsFixerTest.cpp:526 EXPECT_EQ("namespace A {\n" " int i;\n" "} // namespace A", klimek wrote: > Typz wrote: > > Should

[PATCH] D62087: [analyzer] print() JSONify: Program state implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361983: [analyzer] print() JSONify: Program state implementation (authored by Charusso, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D62087?v

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

lebedev.ri added a comment. In D61912#1521352 , @Charusso wrote: > Hey @lebedev.ri, thanks for the review! > > In D61912#1521306 , @lebedev.ri > wrote: > > > All these patches bypassed cfe-commits. > > > Bypassed?

r361986 - [clang-format] Allow configuring list of function-like macros that resolve to a type

Author: typz Date: Wed May 29 09:30:47 2019 New Revision: 361986 URL: http://llvm.org/viewvc/llvm-project?rev=361986&view=rev Log: [clang-format] Allow configuring list of function-like macros that resolve to a type Summary: Adds a `TypenameMacros` configuration option that causes certain identi

[PATCH] D57184: [clang-format] Allow configuring list of function-like macros that resolve to a type

This revision was automatically updated to reflect the committed changes. Closed by commit rC361986: [clang-format] Allow configuring list of function-like macros that resolve to a… (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D57184?vs=201395&id=201962#t

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. >> In D61912#1521306 , @lebedev.ri >> wrote: >> >>> All these patches bypassed cfe-commits. >> >> >> Bypassed? It is only added when you push your stuff, which is happened as >> expected. > > That is pretty much the opposite

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

dblaikie added a comment. Might be easier as a few patches - renaming the existing option, adding the new one, then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name. (if I'm reading what this patch does) Comment at

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201968. yaqiji added a comment. Updated warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201969. yaqiji added a comment. Added check-fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationChe

[PATCH] D62606: [Driver] -static-pie: add -z text

sivachandra accepted this revision. sivachandra added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62606/new/ https://reviews.llvm.org/D62606 ___ cfe-

r361992 - Add curley brackets to case statement that declares a variable.

Author: erichkeane Date: Wed May 29 10:04:48 2019 New Revision: 361992 URL: http://llvm.org/viewvc/llvm-project?rev=361992&view=rev Log: Add curley brackets to case statement that declares a variable. Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenCUDA/device-var-init.cu:39 +static __device__ int d_s_v_i = 1; +// DEVICE: @_ZL7d_s_v_i = internal addrspace(1) global i32 1, + P

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Szelethus added a comment. In D61912#1521411 , @Charusso wrote: > >> In D61912#1521306 , @lebedev.ri > >> wrote: > >> > >>> All these patches bypassed cfe-commits. > >> > >> > >> Bypassed? It is only added when

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; ---

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. thanks, but that `static __device__` variable won't have shadow in host anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62603/new/ https://reviews.llvm.org/D62603 ___ cfe-

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201972. yaqiji added a comment. Remove cmake content Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/GlobalVariableDeclarati

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201971. yaqiji added a comment. Removed check-fixes for those without fixithint. Changed name of Y2Good to Y2Bad to match meaning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.o

r361994 - [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

Author: hliao Date: Wed May 29 10:23:27 2019 New Revision: 361994 URL: http://llvm.org/viewvc/llvm-project?rev=361994&view=rev Log: [CUDA][HIP] Skip setting `externally_initialized` for static device variables. Summary: - By declaring device variables as `static`, we assume they won't be addres

[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Charusso added a comment. In D61912#1521476 , @Szelethus wrote: > I think cfe-commits is added automatically if you add "Clang" to the > "Repository" field when creating a new Differential. Exactly, thanks! Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji updated this revision to Diff 201973. yaqiji added a comment. Added to check no fixit is generated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 Files: clang-tools-extra/clang-tidy/google/Global

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

This revision was automatically updated to reflect the committed changes. Closed by commit rC361994: [CUDA][HIP] Skip setting `externally_initialized` for static device variables. (authored by hliao, committed by ). Changed prior to commit: https://reviews.llvm.org/D62603?vs=201938&id=201975#to

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521484 , @hliao wrote: > thanks, but that `static __device__` variable won't have shadow in host > anymore. Why not? Your change only changes whether `externally_initialized` is applied to the variable during device-side

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. Note for the future -- it would be great if we could finish discussing the patch before landing it. I would still like to see the host-side test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62603/new/ https://reviews.llvm.org/D62603 __

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, Charusso, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, kuhar, whisperity, mgorny. Ex

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

craig.topper added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9308 case 'L': assert(!IsSpecial && "Can't use 'L' with 'W', 'N' or 'Z' modifiers"); assert(HowLong <= 2 && "Can't have modifier"); O should be mentioned here =

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

craig.topper added a comment. In D62580#1521277 , @erichkeane wrote: > A different (perhaps silly) question is why 'W' isn't sufficient? It > represents int64_t, which I wonder if is sufficient. I had asked in a separate conversation not to change the

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov updated this revision to Diff 201980. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Add a test for static variable template member Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62579/new/ https://rev

[clang-tools-extra] r361996 - [Index] Compute correct symbol kind for variable templates

Author: ibiryukov Date: Wed May 29 10:49:30 2019 New Revision: 361996 URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev Log: [Index] Compute correct symbol kind for variable templates Summary: The index library itself seems to never pass variable templates as input, however clangd does

r361996 - [Index] Compute correct symbol kind for variable templates

Author: ibiryukov Date: Wed May 29 10:49:30 2019 New Revision: 361996 URL: http://llvm.org/viewvc/llvm-project?rev=361996&view=rev Log: [Index] Compute correct symbol kind for variable templates Summary: The index library itself seems to never pass variable templates as input, however clangd does

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

This revision was automatically updated to reflect the committed changes. Closed by commit rC361996: [Index] Compute correct symbol kind for variable templates (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D62579?vs=201980&id=201981#toc Repository:

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

NoQ added a comment. > What do you mean by consistent spacing? I meant `BlockEntrance` vs. `Block Entrance`, etc. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62346/new/ https://reviews.llvm.org/D62346 ___ cfe-comm

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" You can use a raw string literal to make it more readable: https://en

[PATCH] D62611: [analyzer][Dominators] Add unittests

kuhar added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + Why not have a constructor that takes the cfg and constructs a domtree straight away? But this should proba

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

Charusso updated this revision to Diff 201988. Charusso marked 4 inline comments as done. Charusso added a comment. - Remove unintended spaces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62346/new/ https://reviews.llvm.org/D62346 Files: clang/include/clang/Analysis/ProgramPoint.h

r361997 - [analyzer] print() JSONify: getNodeLabel implementation

Author: charusso Date: Wed May 29 11:05:53 2019 New Revision: 361997 URL: http://llvm.org/viewvc/llvm-project?rev=361997&view=rev Log: [analyzer] print() JSONify: getNodeLabel implementation Summary: This patch also rewrites the ProgramPoint printing. Reviewers: NoQ, xazax.hun, ravikandhadai, ba

[PATCH] D62611: [analyzer][Dominators] Add unittests

NoQ added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:37 +TEST(CFGDominatorTree, DomTree) { + const char *Code = "enum Kind {\n" + " A\n" kuhar wrote: > You can use a raw string literal to make it more readable

[PATCH] D62346: [analyzer] print() JSONify: getNodeLabel implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC361997: [analyzer] print() JSONify: getNodeLabel implementation (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D62346?vs=201988&id=201990#toc Repository: rC

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D62507: [Dominators] PR42041: Skip nullpointer successors

Szelethus updated this revision to Diff 201994. Szelethus added a comment. Drastically improve the readability of the test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62507/new/ https://reviews.llvm.org/D62507 Files: clang/include/clang/Analysis/Analyses/Dominators.h clang

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

Szelethus updated this revision to Diff 201995. Szelethus added a comment. Cascade the test file readability improvement from the previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62551/new/ https://reviews.llvm.org/D62551 Files: clang/include/clang/Analysis/Analyses/Domi

r362000 - [analyzer][AST] print() JSONify: Stmt implementation

Author: charusso Date: Wed May 29 11:17:18 2019 New Revision: 362000 URL: http://llvm.org/viewvc/llvm-project?rev=362000&view=rev Log: [analyzer][AST] print() JSONify: Stmt implementation Summary: This patch also adds a function called `JsonFormat()` which: - Flattens the string so removes the ne

[PATCH] D62494: [analyzer][AST] print() JSONify: Stmt implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rC362000: [analyzer][AST] print() JSONify: Stmt implementation (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D62494?vs=201909&id=201996#toc Repository: rC Cla

r362002 - [analyzer] print() JSONify: Decl revision

Author: charusso Date: Wed May 29 11:21:14 2019 New Revision: 362002 URL: http://llvm.org/viewvc/llvm-project?rev=362002&view=rev Log: [analyzer] print() JSONify: Decl revision Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers: cfe-

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

alexbatashev added a comment. In D62580#1521234 , @erichkeane wrote: > 'O' is an interesting choice. Any real justification for it, or just "what > was available"? It definitely needs to be documented in the top of > Builtins.def however. O is for **

[PATCH] D62495: [analyzer] print() JSONify: Decl revision

This revision was automatically updated to reflect the committed changes. Closed by commit rL362002: [analyzer] print() JSONify: Decl revision (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D62496: [analyzer] print() JSONify: CFG implementation

Charusso added a comment. In D62496#1518696 , @NoQ wrote: > It's just for escaping weird symbols in pretty-prints, right? Fair enough! Yea, because it writes out both Decl and Stmt craziness. Repository: rC Clang CHANGES SINCE LAST ACTION https://

r362003 - [analyzer] print() JSONify: CFG implementation

Author: charusso Date: Wed May 29 11:29:31 2019 New Revision: 362003 URL: http://llvm.org/viewvc/llvm-project?rev=362003&view=rev Log: [analyzer] print() JSONify: CFG implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers:

r362004 - [WebAssembly] Support VPtr sanitizer for Emscripten

Author: tlively Date: Wed May 29 11:31:50 2019 New Revision: 362004 URL: http://llvm.org/viewvc/llvm-project?rev=362004&view=rev Log: [WebAssembly] Support VPtr sanitizer for Emscripten Summary: After https://github.com/emscripten-core/emscripten/pull/8651, Emscripten supports the full UBSan runt

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

This revision was automatically updated to reflect the committed changes. Closed by commit rL362004: [WebAssembly] Support VPtr sanitizer for Emscripten (authored by tlively, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D62496: [analyzer] print() JSONify: CFG implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362003: [analyzer] print() JSONify: CFG implementation (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D62615: [CodeComplete] Include more text into typed chunks of pattern completions

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a project: clang. To allow filtering on any of the words in the editors. In particular, the following completions were changed: - 'using namespace <#name#>' Typed text before: 'using', after: 'using name

[PATCH] D62579: [Index] Compute correct symbol kind for variable templates

ilya-biryukov added inline comments. Comment at: clang/lib/Index/IndexSymbol.cpp:99 + if (auto *VT = dyn_cast(D)) { +Info.Properties |= (SymbolPropertySet)SymbolProperty::Generic; kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > what about

r362005 - Fix an unused-variable error.

Author: hokein Date: Wed May 29 11:36:54 2019 New Revision: 362005 URL: http://llvm.org/viewvc/llvm-project?rev=362005&view=rev Log: Fix an unused-variable error. Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/Environment.cpp URL: htt

r362008 - [analyzer] print() JSONify: SVal implementation

Author: charusso Date: Wed May 29 11:38:52 2019 New Revision: 362008 URL: http://llvm.org/viewvc/llvm-project?rev=362008&view=rev Log: [analyzer] print() JSONify: SVal implementation Summary: - Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus Reviewed By: NoQ Subscribers

[PATCH] D62591: [OpenCL][PR42031] Prevent deducing addr space in type alias.

mantognini added inline comments. Comment at: lib/Sema/SemaType.cpp:7355 + // object. + (D.getContext() == DeclaratorContext::AliasDeclContext) || // Do not deduce addr space for types used to define a typedef and the I think this should also che

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95 + CFGPostDomTree PostDom; + PostDom.buildDominatorTree(cfg); + kuhar wrote: > Why not have a constructor that takes the cfg

[PATCH] D62497: [analyzer] print() JSONify: SVal implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL362008: [analyzer] print() JSONify: SVal implementation (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D62611: [analyzer][Dominators] Add unittests

Szelethus updated this revision to Diff 202004. Szelethus added a comment. Fixes according to reviewer comments, thanks! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62611/new/ https://reviews.llvm.org/D62611 Files: clang/unittests/Analysis/CFGBuilder.h clang/unittests/Analysis

r362009 - [analyzer] SATestBuild.py: Use driver for analyzing single-file tests.

Author: dergachev Date: Wed May 29 11:49:31 2019 New Revision: 362009 URL: http://llvm.org/viewvc/llvm-project?rev=362009&view=rev Log: [analyzer] SATestBuild.py: Use driver for analyzing single-file tests. Don't bother coming up with a -cc1 run-line ourselves. This, in particular, gets rid of a

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521503 , @tra wrote: > In D62603#1521484 , @hliao wrote: > > > thanks, but that `static __device__` variable won't have shadow in host > > anymore. > > > Why not? Your change only

[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. E.g. we now turn `while(<#cond#>){` into `while (<#cond#>) {` This slightly improves the final output. Should not affect clients th

r362011 - [analyzer] print() JSONify chain: Generic stmt_id

Author: charusso Date: Wed May 29 11:58:41 2019 New Revision: 362011 URL: http://llvm.org/viewvc/llvm-project?rev=362011&view=rev Log: [analyzer] print() JSONify chain: Generic stmt_id Summary: Some environment create less statements so make them generic. Modified: cfe/trunk/test/Analysis/du

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521503 , @tra wrote: > In D62603#1521484 , @hliao wrote: > > > thanks, but that `static __device__` variable won't have shadow in host > > anymore. > > > Why not? Your change only

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Conditional approval, commit with the comment fixed. Let me know if you need me to commit it for you. Comment at: clang/include/clang/Basic/Builtins.def:56 // N

r362013 - LLVM IR: update Clang tests for byval being a typed attribute.

Author: tnorthover Date: Wed May 29 12:13:29 2019 New Revision: 362013 URL: http://llvm.org/viewvc/llvm-project?rev=362013&view=rev Log: LLVM IR: update Clang tests for byval being a typed attribute. Since byval is now a typed attribute it gets sorted slightly differently by LLVM when the order o

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. >> NVCC also allows that: https://godbolt.org/z/t78RvM > > BTW, that code posted looks quite weird to me, how the code could make sense > by return a pointer of device variable? or a pointer of shadow host variable? Magic. :-) More practical example would be something like

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521788 , @tra wrote: > >> NVCC also allows that: https://godbolt.org/z/t78RvM > > > > BTW, that code posted looks quite weird to me, how the code could make > > sense by return a pointer of device variable? or a pointer

r362014 - [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece

Author: charusso Date: Wed May 29 12:21:59 2019 New Revision: 362014 URL: http://llvm.org/viewvc/llvm-project?rev=362014&view=rev Log: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece Summary: This new piece is similar to our macro expansion printing in HTML reports: On mouse-hove

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus created this revision. Szelethus added reviewers: kuhar, NoQ, dcoughlin, xazax.hun, rnkovacs, baloghadamsoftware, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus a

[PATCH] D60670: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece

This revision was automatically updated to reflect the committed changes. Closed by commit rC362014: [analyzer] [NFC] PathDiagnostic: Create PathDiagnosticPopUpPiece (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D60670?vs=200109&id=202021#toc Reposito

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

kuhar added a comment. You can easily get CD by calculating the PostDominanceFrontier. LLVM implements a templated IDF (Iterated Dominance Frontier) construction. A native implementation for llvm ir for reference, if you need: - https://github.com/seahorn/seahorn/blob/deep-dev-5.0/include/seaho

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521792 , @hliao wrote: > that should assume that variable is not declared with `static`. that's also > the motivation of this patch. cppreference defines internal linkage as 'The name can be referred to from all scopes i

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. `change()` is an all purpose function; the revision adds simple shortcuts for the specific operations of inserting (before/after) or removing source. Repository: rG LLVM Github Monorepo htt

[PATCH] D62619: [analyzer][Dominators] Add a control dependency tree builder + a new debug checker

Szelethus added a comment. In D62619#1521824 , @kuhar wrote: > You can easily get CD by calculating the PostDominanceFrontier. LLVM > implements a templated IDF (Iterated Dominance Frontier) construction. > A native implementation for llvm ir for referen

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

hliao added a comment. In D62603#1521832 , @tra wrote: > In D62603#1521792 , @hliao wrote: > > > that should assume that variable is not declared with `static`. that's also > > the motivation of this patch. > > > c

[PATCH] D62621: [LibTooling] Add insert/remove convenience functions for creating `ASTEdit`s.

ymandel updated this revision to Diff 202026. ymandel added a comment. added comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62621/new/ https://reviews.llvm.org/D62621 Files: clang/include/clang/Tooling/Refactoring/Transformer.h clang/

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

kparzysz added a comment. This commit stopped clang++ from finding libc++: main.cc: #include int main() { std::vector x; return x.size(); } $ clang++ main.cc -stdlib=libc++ -v clang version 9.0.0 (/w/src/llvm.org/tools/clang 754813c4737a444eeb4ea5b4070073dd251504cc) (/w

[PATCH] D62167: CodeView - add static data members to global variable debug info.

akhuang updated this revision to Diff 202027. akhuang added a comment. Herald added a subscriber: hiraditya. Append class name to static data member debug info name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62167/new/ https://reviews.llvm.org/

[PATCH] D62580: [OpenCL] Use long instead of long long in x86 builtins

Ka-Ka added a comment. What about a testcase? It shouldn't be hard to add a small testcase that demonstrate that the changed builtins now work when compiling OpenCL C code for x86. I don't think you have to add all changed builtins to the testcase (but a few to demonstrate the change). CHANGE

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 marked 2 inline comments as done. jcai19 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:52 + +void e() { + int pipefd[2]; srhines wrote: > jcai19 wrote: > > srhines wrote: > > > I'm not all that familiar wit

[PATCH] D62622: [CMake] Provide an option to use relative paths in debug info

phosek created this revision. phosek added reviewers: beanz, smeenai. Herald added subscribers: llvm-commits, cfe-commits, aprantl, mgorny. Herald added projects: clang, LLVM. CMake always uses absolute file paths in the generated compiler invocation which results in absolute file paths being embe

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

jcai19 updated this revision to Diff 202030. jcai19 added a comment. Add CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62049/new/ https://reviews.llvm.org/D62049 Files: clang-tools-extra/clang-tidy/android/AndroidTidyM

r362023 - [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'

Author: charusso Date: Wed May 29 13:13:29 2019 New Revision: 362023 URL: http://llvm.org/viewvc/llvm-project?rev=362023&view=rev Log: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false' Summary: - Reviewers: NoQ, alexfh Reviewed By: alexfh Subscribers: cfe-commits, xazax.hun, balogha

[PATCH] D61060: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false'

This revision was automatically updated to reflect the committed changes. Closed by commit rL362023: [analyzer] ConditionBRVisitor: Test 'add-pop-up-notes=false' (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362025 - [analyzer] ConditionBRVisitor: Remove duplicated code

Author: charusso Date: Wed May 29 13:18:07 2019 New Revision: 362025 URL: http://llvm.org/viewvc/llvm-project?rev=362025&view=rev Log: [analyzer] ConditionBRVisitor: Remove duplicated code Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ Subscribers: cfe-commits, xazax.hun, balogha

[PATCH] D62623: Reduce memory consumption of coverage dumps

serge-sans-paille created this revision. serge-sans-paille added reviewers: vsk, arphaman. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. serge-sans-paille edited the summary of this revision. Avoiding an intermediate join operation, which in turns removes the ne

[PATCH] D58199: [analyzer] ConditionBRVisitor: Remove duplicated code

This revision was automatically updated to reflect the committed changes. Closed by commit rL362025: [analyzer] ConditionBRVisitor: Remove duplicated code (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

r362026 - [analyzer] ConditionBRVisitor: MemberExpr support

Author: charusso Date: Wed May 29 13:29:02 2019 New Revision: 362026 URL: http://llvm.org/viewvc/llvm-project?rev=362026&view=rev Log: [analyzer] ConditionBRVisitor: MemberExpr support Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ Subscribers: cfe-commits, xazax.hun, baloghadams

[PATCH] D58206: [analyzer] ConditionBRVisitor: MemberExpr support

This revision was automatically updated to reflect the committed changes. Closed by commit rC362026: [analyzer] ConditionBRVisitor: MemberExpr support (authored by Charusso, committed by ). Changed prior to commit: https://reviews.llvm.org/D58206?vs=195073&id=202044#toc Repository: rC Clang

r362027 - [analyzer] ConditionBRVisitor: Boolean support

Author: charusso Date: Wed May 29 13:34:29 2019 New Revision: 362027 URL: http://llvm.org/viewvc/llvm-project?rev=362027&view=rev Log: [analyzer] ConditionBRVisitor: Boolean support Summary: - Reviewers: NoQ, george.karpenkov Reviewed By: NoQ, george.karpenkov Subscribers: cfe-commits, xazax.h

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

yaxunl added a comment. In D62603#1521832 , @tra wrote: > In D62603#1521792 , @hliao wrote: > > > that should assume that variable is not declared with `static`. that's also > > the motivation of this patch. > > >

[PATCH] D58207: [analyzer] ConditionBRVisitor: Boolean support

This revision was automatically updated to reflect the committed changes. Closed by commit rL362027: [analyzer] ConditionBRVisitor: Boolean support (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r362028 - Revert "LLVM IR: update Clang tests for byval being a typed attribute."

Author: tnorthover Date: Wed May 29 13:45:32 2019 New Revision: 362028 URL: http://llvm.org/viewvc/llvm-project?rev=362028&view=rev Log: Revert "LLVM IR: update Clang tests for byval being a typed attribute." The underlying LLVM change couldn't cope with llvm-link and broke LTO builds. Modified:

r362030 - [analyzer] Remove EndPath function as it is dead code

Author: charusso Date: Wed May 29 13:47:27 2019 New Revision: 362030 URL: http://llvm.org/viewvc/llvm-project?rev=362030&view=rev Log: [analyzer] Remove EndPath function as it is dead code Summary: - Reviewers: george.karpenkov Reviewed By: george.karpenkov Subscribers: baloghadamsoftware, cfe

[PATCH] D53720: [analyzer] Remove EndPath function as it is dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rL362030: [analyzer] Remove EndPath function as it is dead code (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D62623: Reduce memory consumption of coverage dumps

kwk added a comment. @serge-sans-paille testing it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62623/new/ https://reviews.llvm.org/D62623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62603: [CUDA][HIP] Skip setting `externally_initialized` for static device variables.

tra added a comment. In D62603#1521979 , @yaxunl wrote: > > I think `static __device__` globals would fall into the same category -- > > nominally they should not be visible outside of device-side object file, > > but in practice we do need to make them

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

jcai19 updated this revision to Diff 202052. jcai19 added a comment. Add CHECK-MESSAGES-NOT checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61967/new/ https://reviews.llvm.org/D61967 Files: clang-tools-extra/clang-tidy/android/AndroidTidyM

r362034 - [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

Author: ahatanak Date: Wed May 29 14:23:30 2019 New Revision: 362034 URL: http://llvm.org/viewvc/llvm-project?rev=362034&view=rev Log: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs clang was encoding pointers to typedefs as if they were pointers to structs because that i

<    1   2   3   >