[clang-tools-extra] r360115 - [clangd] add CLANG_ENABLE_CLANGD option to build clangd. Require threads.

Author: sammccall Date: Tue May 7 00:05:47 2019 New Revision: 360115 URL: http://llvm.org/viewvc/llvm-project?rev=360115&view=rev Log: [clangd] add CLANG_ENABLE_CLANGD option to build clangd. Require threads. Reviewers: gribozavr Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, k

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

CaseyCarter added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int std::vector v(array, array + 3); ---

[PATCH] D61518: [clangd] add CLANG_ENABLE_CLANGD option to build clangd. Require threads.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360115: [clangd] add CLANG_ENABLE_CLANGD option to build clangd. Require threads. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61518?vs=198026&id=198400#t

[PATCH] D61122: [clangd] Don't build clangd or run its tests when LLVM_ENABLE_THREADS is off, unless specifically directed to do so

sammccall abandoned this revision. sammccall added a comment. Superseded by rL360115 Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61122/new/ https://reviews.llvm.org/D61122

[clang-tools-extra] r360116 - [clangd] Move Rename into its own file, and add unit test. NFC

Author: sammccall Date: Tue May 7 00:11:56 2019 New Revision: 360116 URL: http://llvm.org/viewvc/llvm-project?rev=360116&view=rev Log: [clangd] Move Rename into its own file, and add unit test. NFC Reviewers: kadircet Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, jfb, cfe-comm

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rCTE360116: [clangd] Move Rename into its own file, and add unit test. NFC (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clangd/ClangdServer.cpp:264 Callback> CB) { - auto Action = [Pos](Path File, std::string NewName, + auto Action = [Pos](std::string File, std::string NewName,

r360117 - Improve function / variable disambiguation.

Author: rsmith Date: Tue May 7 00:36:07 2019 New Revision: 360117 URL: http://llvm.org/viewvc/llvm-project?rev=360117&view=rev Log: Improve function / variable disambiguation. Keep looking for decl-specifiers after an unknown identifier. Don't issue diagnostics about an error type specifier conf

[clang-tools-extra] r360118 - [clangd] Add test that r360116 accidentally fixed a duplicate-edits bug in rename. NFC

Author: sammccall Date: Tue May 7 00:45:41 2019 New Revision: 360118 URL: http://llvm.org/viewvc/llvm-project?rev=360118&view=rev Log: [clangd] Add test that r360116 accidentally fixed a duplicate-edits bug in rename. NFC Modified: clang-tools-extra/trunk/clangd/refactor/Rename.cpp clan

[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

sammccall added a comment. Incidentally, this was not NFC - it deduplicates edits and therefore works around a bug in the visitor! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61596/new/ https://reviews.llvm.org/D61596 _

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

JonasToth added a comment. > My understanding of the directory layout guidance in the docs is that > different styles get different directories. Yes, but for "the same check" we use aliases instead. When aliasing checks in different categories it is possible to change default configuration valu

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik added a comment. ...and increased CINDEX_VERSION_MINOR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. I think it makes more sense to expose semantical information in HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, and let this be serialized by the users of ClangdServer (as in D61497 ). This is what I'll perf

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik updated this revision to Diff 198403. nik added a comment. Herald added a project: clang. Adapted c-index-test.c and added function to libclang.exports. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 Files: include

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

nik accepted this revision. nik added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing

[clang-tools-extra] r360119 - [clangd] switchSourceHeader uses null not empty string as sentinel.

Author: sammccall Date: Tue May 7 00:55:35 2019 New Revision: 360119 URL: http://llvm.org/viewvc/llvm-project?rev=360119&view=rev Log: [clangd] switchSourceHeader uses null not empty string as sentinel. As far as I can see, only theia actually implements this, and it expects null. Modified:

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

owenpan created this revision. owenpan added a reviewer: sammccall. owenpan added a project: clang. Herald added a subscriber: cfe-commits. Also fix a typo for the SCSU byte order mark. Repository: rC Clang https://reviews.llvm.org/D61628 Files: clang/lib/Basic/SourceManager.cpp Index: c

r360120 - [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller

Author: leonardchan Date: Tue May 7 01:12:28 2019 New Revision: 360120 URL: http://llvm.org/viewvc/llvm-project?rev=360120&view=rev Log: [Sema] Add missing VisitMacroQualifiedTypeLoc to TypeSpecLocFiller To hopefully fix greenbot failures Modified: cfe/trunk/lib/Sema/SemaType.cpp Modified:

[PATCH] D61630: [clangd] Oops, switchSourceHeader still needs to return a URI.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61630 Files: clangd/ClangdLSPServer.cpp clan

[PATCH] D61631: [Tooling] Don't mmap the JSONCompilationDatabase, it's not correct for long-lived processes.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61631 Files: lib/Tooling/JSONCompilationDatabase.cpp Index: lib/Tooling/JSONCompilationDatabase.

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added a comment. In D61601#1492979 , @kadircet wrote: > I think it makes more sense to expose semantical information in > HoverInfo(like Name, Scope, Definition, etc), rather than formatted strings, > and let this be serialized by the users

[PATCH] D61630: [clangd] Oops, switchSourceHeader still needs to return a URI.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360121: [clangd] Oops, switchSourceHeader still needs to return a URI. (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61630?vs=198407&id=198409#toc Reposit

[clang-tools-extra] r360121 - [clangd] Oops, switchSourceHeader still needs to return a URI.

Author: sammccall Date: Tue May 7 01:30:32 2019 New Revision: 360121 URL: http://llvm.org/viewvc/llvm-project?rev=360121&view=rev Log: [clangd] Oops, switchSourceHeader still needs to return a URI. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #c

[PATCH] D61628: Fix a bug that reports UTF16 (LE) files as UTF32 (LE) ones

sammccall added a comment. This looks good, but did you intend to make a new diff? It looks like D61559 didn't land yet. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61628/new/ https://reviews.llvm.org/D61628 ___

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 198410. ilya-biryukov added a comment. - Move range and kind assignment out of the loop. - Log error on failed deserialization of markup kind. - s/Plaintext/PlainText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D61497: [clangd] Introduce a structured hover response

ilya-biryukov added a comment. Was passing by, just a small clarifying question... Comment at: clang-tools-extra/clangd/XRefs.h:73 + llvm::Optional> Parameters; + llvm::Optional> TemplateParameters; + What does `Type` mean for non-type and template template p

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:853 + Hover R; + switch (HoverContentFormat) { + case MarkupKin

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

Tyker added a comment. could you commit this for me ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60934/new/ https://reviews.llvm.org/D60934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D61631: [Tooling] Don't mmap the JSONCompilationDatabase, it's not correct for long-lived processes.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360122: [Tooling] Don't mmap the JSONCompilationDatabase, it's not correct for long… (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61631?vs=198408&id=198414

[PATCH] D61633: [Tooling] Add -x flags when inferring compile commands for files with no/invalid extension.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. We treat them as headers, as the motivating case is C++ standard library. Repository: rC Clang https://reviews.llvm.org/D61633 Files: lib/Tooling/In

r360122 - [Tooling] Don't mmap the JSONCompilationDatabase, it's not correct for long-lived processes.

Author: sammccall Date: Tue May 7 02:05:15 2019 New Revision: 360122 URL: http://llvm.org/viewvc/llvm-project?rev=360122&view=rev Log: [Tooling] Don't mmap the JSONCompilationDatabase, it's not correct for long-lived processes. Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang D

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

kadircet added a comment. > I'm happy to restructure the `HoverInfo` to your liking if the current one > seems problematic for any reason. It will just cause more code move on my side, no problems apart from that Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else +

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Protocol.cpp:707 + else +return false; + return true; kadircet wrote: > kadircet wrote: > > Maybe also vlog/elog the unknown kind? So that we can easily catch new > > additions to sp

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov updated this revision to Diff 198415. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Forgotten change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61601/new/ https://reviews.llvm.org/D61601 Files:

[PATCH] D61601: [clangd] Represent Hover result using FormattedString

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Planning to rebase this on top of D61497 and land afterwards in order to minimize merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:73 + llvm::Optional> Parameters; + llvm::Optional> TemplateParameters; + ilya-biryukov wrote: > What does `Type` mean for non-type and templa

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198420. kadircet marked an inline comment as done. kadircet added a comment. - Add comments for non-type params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://reviews.llvm.org/D61497 Files:

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added subscribers: llvm-commits, cfe-commits, mgrang, hiraditya. Herald added projects: clang, LLVM. POC for the rfc http://lists.llvm.org/pipermail/llvm-dev/2019-April/131973.html Repository: rG LLVM Github Monorepo

[PATCH] D61506: [OpenCL] Switch to C++17

Anastasia marked an inline comment as done. Anastasia added a comment. In D61506#1490555 , @rsmith wrote: > Per the OpenCL C++ 1.0 specification, section 2: > > > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 > > N 3690 langua

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: mgorny. Herald added a project: clang. ilya-biryukov added a parent revision: D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library. An tooling-focused alternative to the

r360132 - [ASTImporter] Import TemplateParameterLists in function templates.

Author: balazske Date: Tue May 7 03:55:11 2019 New Revision: 360132 URL: http://llvm.org/viewvc/llvm-project?rev=360132&view=rev Log: [ASTImporter] Import TemplateParameterLists in function templates. Summary: Correct missing import of TemplateParameterList in function decl. Reviewers: martong,

[PATCH] D61639: Add Triple::isSPIR() to simplify code

kpet created this revision. kpet added a reviewer: Anastasia. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61639 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Fronte

[PATCH] D60461: [ASTImporter] Import TemplateParameterLists in function templates.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360132: [ASTImporter] Import TemplateParameterLists in function templates. (authored by balazske, committed by ). Changed prior to commit: https://reviews.llvm.org/D60461?vs=194310&id=198431#toc Reposi

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet updated this revision to Diff 198436. gchatelet added a comment. Herald added a subscriber: jdoerfert. - Add documentation. - Fix permissive HasNoRuntimeAttribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61634/new/ https://reviews.ll

[PATCH] D61396: [hip] Fix ambiguity from `>>>` of CUDA.

hliao added a comment. @rsmith Do you have the chance to review this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61396/new/ https://reviews.llvm.org/D61396 ___ cfe-commits mailing list cfe-com

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

theraven added a comment. I wonder if a list of comma-separated names is the right approach. Would it make more sense to add a new attribute for each of the helpers, such as `#no-runtime-for-memcpy`? That should make querying simpler (one lookup in the table, rather than a lookup and a string

[PATCH] D55562: Atomics: support min/max orthogonally

t.p.northover updated this revision to Diff 198452. t.p.northover added a comment. Sorry, I managed to forget about this one somehow. I hadn't changed the 32-bit requirement, but I agree it shouldn't be there so this diff removes it and adds tests for the newly legal cases. Repository: rC Cl

[PATCH] D61497: [clangd] Introduce a structured hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:57 +// template class. +Type T; +std::string Name; Same about type template parameters. Probably just holds `class` or `typename`? Repository: rG LLVM Github Monorep

[PATCH] D61497: [clangd] Introduce a structured hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:73 + llvm::Optional> Parameters; + llvm::Optional> TemplateParameters; + kadircet wrote: > ilya-biryukov wrote: > > What does `Type` mean for non-type and template template parame

[PATCH] D33841: [clang-tidy] redundant keyword check

aaron.ballman added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); koldaniel wrote: > aaron.ballman wrote: > > koldaniel wrote: > > > aaron.ballman wrote: > > > > More tests that I figured

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198457. kadircet marked 2 inline comments as done. kadircet added a comment. I will start adding test cases(and most likely change the way I populate the struct at some places) if everyone is happy with current representation for `HoverInfo`. Repository:

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:57 +// template class. +Type T; +std::string Name; ilya-biryukov wrote: > Same about type template parameters. > Probably just holds `class` or `typename`? Exactly, adding co

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FormattedString.h:34 + /// markdown. + /// EXPECTS: Code does not contain newlines. + void appendInlineCode(std::string Code

[PATCH] D61350: [clang-tidy] New check calling out uses of +new in Objective-C code

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/AvoidNSObjectNewCheck.cpp:73 + // of -init. + const StringRef Receiver = + getReceiverString(Expr->getReceiverRange(), SM, LangOpts); We don't typically make local value t

r360147 - Allow field offset lookups in types with incomplete arrays within libclang.

Author: aaronballman Date: Tue May 7 07:00:49 2019 New Revision: 360147 URL: http://llvm.org/viewvc/llvm-project?rev=360147&view=rev Log: Allow field offset lookups in types with incomplete arrays within libclang. Patch thanks to Jorn Vernee Added: cfe/trunk/test/Index/print-type-size.c Mod

[PATCH] D60956: [Sema] Fix the lookup for a declaration conflicting with an enumerator

aaron.ballman added a comment. I found a few nits, but generally think this LG. However, I think @rsmith should sign off on it just in case I've misinterpreted something along the way. Comment at: lib/Sema/SemaDecl.cpp:16537 +// instead would cause us to miss using-decla

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in r360147, thank you for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 ___ cfe-commits mailing list cfe-co

[clang-tools-extra] r360151 - [clangd] Introduce intermediate representation of formatted text

Author: ibiryukov Date: Tue May 7 07:18:18 2019 New Revision: 360151 URL: http://llvm.org/viewvc/llvm-project?rev=360151&view=rev Log: [clangd] Introduce intermediate representation of formatted text Summary: That can render to markdown or plain text. Used for findHover requests. Reviewers: mal

[PATCH] D61497: [clangd] Introduce a structured hover response

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:53 +struct HoverInfo { + using Type = std::string; + struct Param { NIT: maybe go with `std::string Type` at a use-site instead? The scope of the name is large enough to make sing

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

ilya-biryukov updated this revision to Diff 198463. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Update a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58547/new/ https://reviews.llvm.org/D58547 Files:

[PATCH] D58547: [clangd] Introduce intermediate representation of formatted text

This revision was automatically updated to reflect the committed changes. Closed by commit rL360151: [clangd] Introduce intermediate representation of formatted text (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

r360152 - [OpenCL] Prevent mangling kernel functions.

Author: stulova Date: Tue May 7 07:22:34 2019 New Revision: 360152 URL: http://llvm.org/viewvc/llvm-project?rev=360152&view=rev Log: [OpenCL] Prevent mangling kernel functions. Kernel function names have to be preserved as in the original source to be able to access them from the host API side.

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

This revision was automatically updated to reflect the committed changes. Closed by commit rC360152: [OpenCL] Prevent mangling kernel functions. (authored by stulova, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60454?vs=197934&id=198467#toc

[PATCH] D61639: Add Triple::isSPIR() to simplify code

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61639/new/ https://reviews.llvm.org/D61639

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added a comment. (I only got about halfway through the implementation - it's missing a lot of comments I think ;-)) Comment at: clang-tools-extra/clangd/XRefs.cpp:539 -/// Generate a \p Hover object given the declaration \p D. -static Hover getHoverContents(const D

r360153 - [Tooling] Add -x flags when inferring compile commands for files with no/invalid extension.

Author: sammccall Date: Tue May 7 07:34:06 2019 New Revision: 360153 URL: http://llvm.org/viewvc/llvm-project?rev=360153&view=rev Log: [Tooling] Add -x flags when inferring compile commands for files with no/invalid extension. Summary: We treat them as headers, as the motivating case is C++ sta

[PATCH] D61497: [clangd] Introduce a structured hover response

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:53 +struct HoverInfo { + using Type = std::string; + struct Param { ilya-biryukov wrote: > NIT: maybe go with `std::string Type` at a use-site instead? > The scope of the name is larg

[PATCH] D61633: [Tooling] Add -x flags when inferring compile commands for files with no/invalid extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rC360153: [Tooling] Add -x flags when inferring compile commands for files with… (authored by sammccall, committed by ). Changed prior to commit: https://reviews.llvm.org/D61633?vs=198413&id=198469#toc R

r360155 - Add an explicit triple to this test to hopefully appease the build bots.

Author: aaronballman Date: Tue May 7 07:40:37 2019 New Revision: 360155 URL: http://llvm.org/viewvc/llvm-project?rev=360155&view=rev Log: Add an explicit triple to this test to hopefully appease the build bots. Modified: cfe/trunk/test/Index/print-type-size.c Modified: cfe/trunk/test/Index/

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. @jakehehrlich @compnerd ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attrib

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:216 +llvm::dbgs() +<< "$[collect-tokens]: " +<< syntax::Token(T).dumpForTests(SourceMgr) << "\n" what's "$[collect

r360156 - [ASTImporter] Corrected type of integer constant in a test.

Author: balazske Date: Tue May 7 07:53:04 2019 New Revision: 360156 URL: http://llvm.org/viewvc/llvm-project?rev=360156&view=rev Log: [ASTImporter] Corrected type of integer constant in a test. Modified: cfe/trunk/unittests/AST/ASTImporterTest.cpp Modified: cfe/trunk/unittests/AST/ASTImport

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

ilya-biryukov created this revision. ilya-biryukov added a reviewer: aaron.ballman. Herald added a subscriber: xazax.hun. Herald added a project: clang. The case when initialize_list hides behind an implicit case was not handled before. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

jdenny added reviewers: rsmith, aaron.ballman. jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. LGTM except for nits in the tests. I'm not close to C++ support in Clang, so please give other reviewers a few days to comment just in case. I'v

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

jkorous added a comment. Hi @VelocityRa, just FYI - it's considered fine to ping your reviewers once per week here if you've addressed their comments and there's no activity in the review. Sometimes people just get distracted by other things. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1493350 , @theraven wrote: > I wonder if a list of comma-separated names is the right approach. Would it > make more sense to add a new attribute for each of the helpers, such as > `#no-runtime-for-memcpy`? That shou

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. BTW, for a common use-case we can do the same trick that's being done for aggregate init: new X({1,2,3}, 123, {a}); into make_unique(X({1,2,3}, 123, {a})); I can try fixing this, but would want to land this fir

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

ldionne added a comment. In D49587#1493585 , @ldionne wrote: > I think the right way to do this was to use `install(export)`? Oh, and you are doing this, but in `llvm/runtimes`. Why don't we handle this per project? I don't think we should assume that t

[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

ldionne added a comment. I think the right way to do this was to use `install(export)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49587/new/ https://reviews.llvm.org/D49587 ___ cfe-commits mailing

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman added inline comments. Comment at: include/clang/AST/DeclBase.h:1139 + void dump(raw_ostream &Out, bool Deserialize = false, +ASTDumpOutputFormat OutputFormat = ADOF_Default) const; steveire wrote: > I think we've talked about this be

[PATCH] D60910: [WIP] Dumping the AST to JSON

aaron.ballman updated this revision to Diff 198477. aaron.ballman marked 14 inline comments as done. aaron.ballman added a comment. Updating based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60910/new/ https://reviews.llvm.org/D60910 Files: include/clang/AST/AST

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:130 + OS << llvm::formatv( + "['{0}'_{1}, '{2}'_{3}) => ['{4}'_{5}, '{6}'_{7})\n", + PrintToken(File.SpelledTokens[M.BeginSpelled]), M.BeginSpelled, sa

[PATCH] D61637: [Syntax] Introduce syntax trees

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Corpus.h:23 +/// token buffers, source manager, etc. +class Corpus { +public: I think plain SyntaxArena might be a better name here :-/ Corpus refers to texts (the use in dex is by an

[PATCH] D61475: Update an information about ReSharper C++ and clang-tidy custom binary integration

ZaMaZaN4iK added a comment. Can anyone merge it? I have no commit access Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61475/new/ https://reviews.llvm.org/D61475 ___ cfe-commits mailing list cfe-commits

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

steven_wu added a comment. The main concern for adding this `blacklist` was because of long term maintainability since the option is going to be embedded into bitcode. Looking at this specific option, I have no reason against because it doesn't affect embedded compiler flags. I added Tim to se

[PATCH] D60974: Clang IFSO driver action.

compnerd added inline comments. Comment at: clang/include/clang/Driver/Options.td:626 HelpText<"Use the LLVM representation for assembler and object files">; +def emit_ifso : Flag<["-"], "emit-interface-stubs">, Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub F

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

compnerd added a comment. @steven_wu - yeah, `-mred-zone`, `-mno-red-zone` does impact the ABI, at least on x86_64. It changes the way that the arguments are spilled and the stack layout. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61627/new/

[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

jdenny updated this revision to Diff 198488. jdenny retitled this revision from "[PragmaHandler][OpenMP] Expose `#pragma` location" to "[PragmaHandler] Expose `#pragma` location". jdenny edited the summary of this revision. jdenny set the repository for this revision to rG LLVM Github Monorepo. jd

[PATCH] D61642: [clang-tidy] Do not show incorrect fix in modernize-make-unique

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:302 if (const auto *ImplicitCE = dyn_cast(Arg->IgnoreImplicit())) { if (ImplicitCE->isStdIn

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

aaron.ballman added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:958 + +if (auto *Q = D->getQualifier()) + Q->print(Out, Policy); Don't use `auto` here as the type is not explicitly spelled out in the initialization. If possible, `const`-q

[PATCH] D61627: [clang driver] Allow -fembed-bitcode combined with -mno-red-zone

steven_wu added a comment. In D61627#1493674 , @compnerd wrote: > @steven_wu - yeah, `-mred-zone`, `-mno-red-zone` does impact the ABI, at > least on x86_64. It changes the way that the arguments are spilled and the > stack layout. Well, I am not con

[PATCH] D60974: Clang IFSO driver action.

plotfi marked 6 inline comments as done. plotfi added inline comments. Comment at: clang/include/clang/Driver/Options.td:626 HelpText<"Use the LLVM representation for assembler and object files">; +def emit_ifso : Flag<["-"], "emit-interface-stubs">, Flags<[CC1Option]>, Group

[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

lebedev.ri added a comment. It would have been better to submit this refactor as a new patch.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61509/new/ https://reviews.llvm.org/D61509 ___ cfe-commits m

[PATCH] D61370: Add a C2x mode and allow attributes in it

aaron.ballman added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61370/new/ https://reviews.llvm.org/D61370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D60974: Clang IFSO driver action.

compnerd added inline comments. Comment at: clang/include/clang/Driver/Options.td:626 HelpText<"Use the LLVM representation for assembler and object files">; +def emit_ifso : Flag<["-"], "emit-interface-stubs">, Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub F

[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

jdenny added a comment. In D61509#1493703 , @lebedev.ri wrote: > It would have been better to submit this refactor as a new patch.. Sorry, I didn't realize that was the norm. I can do that now if it would help. I can also revert changes to this patch

[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

lebedev.ri added a comment. In D61509#1493714 , @jdenny wrote: > In D61509#1493703 , @lebedev.ri > wrote: > > > It would have been better to submit this refactor as a new patch.. > > > Sorry, I didn't realize that

[PATCH] D61509: [PragmaHandler] Expose `#pragma` location

jdenny added a comment. In D61509#1493718 , @lebedev.ri wrote: > In D61509#1493714 , @jdenny wrote: > > > In D61509#1493703 , @lebedev.ri > > wrote: > > > > > It would have

Re: r360109 - Recommit r359859 "[Attribute/Diagnostics] Print macro if definition is an attribute declaration"

Hi Leonard, It appears that your patch is still triggering an assertion on GreenDragon: http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c Can you please have a look? Thanks, Jonas On Mon, May 6, 2019 at 8:17 PM Leonard

  1   2   >