kadircet added a comment.

> I'm happy to restructure the `HoverInfo` to your liking if the current one 
> seems problematic for any reason.

It will just cause more code move on my side, no problems apart from that



================
Comment at: clang-tools-extra/clangd/Protocol.cpp:707
+  else
+    return false;
+  return true;
----------------
kadircet wrote:
> Maybe also vlog/elog the unknown kind? So that we can easily catch new 
> additions to spec.
I was referring to the `else` case down below :D


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61601/new/

https://reviews.llvm.org/D61601



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to