ilya-biryukov created this revision.
ilya-biryukov added a reviewer: aaron.ballman.
Herald added a subscriber: xazax.hun.
Herald added a project: clang.
The case when initialize_list hides behind an implicit case was not
handled before.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D61642
Files:
clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
Index: clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
+++ clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
@@ -273,6 +273,12 @@
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: use std::make_unique instead
// CHECK-FIXES: std::make_unique<APair>(APair{T, 1});
+ // Check aggregate init with intermediate temporaries.
+ std::unique_ptr<APair> PAggrTemp = std::unique_ptr<APair>(new APair({T, 1}));
+ // CHECK-MESSAGES: :[[@LINE-1]]:38: warning: use std::make_unique instead
+ PAggrTemp.reset(new APair({T, 1}));
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::make_unique instead
+
// Test different kinds of initialization of the pointee, when the unique_ptr
// is initialized with braces.
Index: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
+++ clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
@@ -292,6 +292,8 @@
// Foo{1} => false
auto HasListIntializedArgument = [](const CXXConstructExpr *CE) {
for (const auto *Arg : CE->arguments()) {
+ Arg = Arg->IgnoreImplicit();
+
if (isa<CXXStdInitializerListExpr>(Arg) || isa<InitListExpr>(Arg))
return true;
// Check whether we implicitly construct a class from a
Index: clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
===================================================================
--- clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
+++ clang-tools-extra/test/clang-tidy/modernize-make-unique.cpp
@@ -273,6 +273,12 @@
// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: use std::make_unique instead
// CHECK-FIXES: std::make_unique<APair>(APair{T, 1});
+ // Check aggregate init with intermediate temporaries.
+ std::unique_ptr<APair> PAggrTemp = std::unique_ptr<APair>(new APair({T, 1}));
+ // CHECK-MESSAGES: :[[@LINE-1]]:38: warning: use std::make_unique instead
+ PAggrTemp.reset(new APair({T, 1}));
+ // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: use std::make_unique instead
+
// Test different kinds of initialization of the pointee, when the unique_ptr
// is initialized with braces.
Index: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
+++ clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp
@@ -292,6 +292,8 @@
// Foo{1} => false
auto HasListIntializedArgument = [](const CXXConstructExpr *CE) {
for (const auto *Arg : CE->arguments()) {
+ Arg = Arg->IgnoreImplicit();
+
if (isa<CXXStdInitializerListExpr>(Arg) || isa<InitListExpr>(Arg))
return true;
// Check whether we implicitly construct a class from a
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
