[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

liutianle added a comment. @RKSimon @craig.topper , could you please review again? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60552/new/ https://reviews.llvm.org/D60552 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall updated this revision to Diff 197058. sammccall added a comment. Zap test/Unit directory, put lit.cfg in unittests directly. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 Files: CMakeLists.txt

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

sammccall added a comment. Also for the record, none of the buildbots in zorg mention check-clang-tools. Bots run tests by enabling clang-tools-extra and then `check-all`, so this patch shouldn't change their behavior. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://r

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

ilya-biryukov added a comment. For the record: the tests pass in the shared build configuration. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. This looks nice and minimal, thanks! Happy to LGTM this, unless @sammccall want to take another look (e.g. to account for related information patch) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://rev

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added inline comments. Comment at: clangd/Diagnostics.cpp:115 + const SourceManager &SM = Info.getSourceManager(); + std::vector IncludeStack; + auto GetIncludeLoc = [&SM](SourceLocation SLoc) { replace `vector` with `SourceLocation` now that we

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall accepted this revision. sammccall marked an inline comment as done. sammccall added a comment. This revision is now accepted and ready to land. Rest is details only. Comment at: clang/include/clang/Tooling/Syntax/Tokens.h:59 + explicit Token(const clang::Token &T); +

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

gribozavr added a comment. Thank you for the quick fix! Comment at: test/Analysis/cxx-uninitialized-object.cpp:1155 +void __vector_size__LongTest() { + VectorSizeLong v; +} Could you also add tests where the vector member is being subscripted? for example, `

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

gribozavr added inline comments. Comment at: test/Analysis/cxx-uninitialized-object.cpp:1155 +void __vector_size__LongTest() { + VectorSizeLong v; +} gribozavr wrote: > gribozavr wrote: > > Could you also add tests where the vector member is being subscripted?

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359424: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Chang

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

gribozavr added a comment. > Also, IIUC the test case that I deleted wasn't actually supposed to produce > any diagnostics and the fact that it did was a bug. We could keep it as a > regression test but I think it has a rather low value. WDYT? What do you mean? The issue that the test is tryin

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197068. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/Diagnost

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Just readability/wording nits Comment at: clangd/Diagnostics.cpp:463 + // header. + auto ShouldAddDiag = [this](const Diag &D) { +if (mentionsMainFile(D)) -

[PATCH] D61103: [clang] Add tryToAttachCommentsToDecls method to ASTContext

gribozavr added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:584 +// terminating early. +for (auto CIt = RawComments.begin(); CIt != RawComments.end(); ++CIt) { + RawComment *C = *CIt; jkorous wrote: > gribozavr wrote: > > Scanning all c

[clang-tools-extra] r359428 - [clangd] Delete config.clangd_xpc_support from test/ to unbreak check-llvm-tools

Author: maskray Date: Mon Apr 29 02:36:54 2019 New Revision: 359428 URL: http://llvm.org/viewvc/llvm-project?rev=359428&view=rev Log: [clangd] Delete config.clangd_xpc_support from test/ to unbreak check-llvm-tools D61187 didn't delete config.clangd_xpc_support from test/ CLANGD_BUILD_XPC is defi

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197073. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/Diagnost

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

MaskRay added a comment. @arphaman @jkorous @thakis I committed https://reviews.llvm.org/rL359428 to fix the following build error. Can one of you check if the test is still built? Thanks! (I don't have a Mac...) if config.clangd_xpc_support: AttributeError: Testing

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 197077. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/Diagnostics.cpp clangd/Diagnostics.h clangd/unittests/Dia

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

This revision was automatically updated to reflect the committed changes. Closed by commit rL359432: [clangd] Surface diagnostics from headers inside main file (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:113 + // Note that FileSymbols counts References by incrementing it per each file + // mentioning the symbol, including headers. This contradicts with the kadircet wr

[PATCH] D61256: [clang-format][docs] Fix the Google C++ and Chromium style guide URLs

m4tx created this revision. m4tx added reviewers: djasper, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Google C++ and Chromium style guides are broken in the clang-format docs. This patch updates them. Repository: rG LLVM Github Monorepo https:/

[clang-tools-extra] r359432 - [clangd] Surface diagnostics from headers inside main file

Author: kadircet Date: Mon Apr 29 03:25:44 2019 New Revision: 359432 URL: http://llvm.org/viewvc/llvm-project?rev=359432&view=rev Log: [clangd] Surface diagnostics from headers inside main file Reviewers: ioeric, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, jdoerfert, cfe-commits Tags

[clang-tools-extra] r359434 - [clangd] Fix windows buildbot, remove stray file after r359424. NFC

Author: sammccall Date: Mon Apr 29 03:35:56 2019 New Revision: 359434 URL: http://llvm.org/viewvc/llvm-project?rev=359434&view=rev Log: [clangd] Fix windows buildbot, remove stray file after r359424. NFC Removed: clang-tools-extra/trunk/test/clangd/Unit/lit.site.cfg.py.in Modified: clang-

[PATCH] D61015: [LibTooing] Change Transformer's TextGenerator to a partial function.

ilya-biryukov added a comment. In D61015#1478886 , @ymandel wrote: > The problem is that validation can't* be done in the abstract. It has to be > done with respect to a specific match result. Unfortunately, the server won't > be layered directly on top

[PATCH] D60934: [clang] adding explicit(bool) from c++2a

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. ASTImporter.cpp and ASTStructuralEquivalence.cpp looks good to me now. I am resigning as a reviewer since I don't feel competent enough to review the rest of the change. CHANGES SINCE LAS

[clang-tools-extra] r359442 - [clangd] Fix unittests CMake rules

Author: sammccall Date: Mon Apr 29 04:47:52 2019 New Revision: 359442 URL: http://llvm.org/viewvc/llvm-project?rev=359442&view=rev Log: [clangd] Fix unittests CMake rules Modified: clang-tools-extra/trunk/clangd/test/CMakeLists.txt clang-tools-extra/trunk/clangd/unittests/CMakeLists.txt

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong accepted this revision. martong added a comment. Looks good, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

whisperity added a comment. @Szelethus I know the dependent patch D59464 will move `examples/analyzer-plugin` to `test/Analysis/plugins/...`, but this patch still seems to affect `examples/`. Are you sure this is the right diff? Because you are adding brand new

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

whisperity added a comment. I think this is good. Patch still marked as //Needs review// for some reason. 😦 Can we look up this `blocking review` thing? Perhaps this could be marked ready to roll once the dependency patch is ironed out. Comment at: lib/StaticAnalyzer/Frontend

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

whisperity added a comment. @dcoughlin How would removing the `USAGE` part of the dump and keeping only the list of options and their formatted help sound? That way, this option will not invite the user to directly call the analyzer. In D57858#1432714 ,

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:625 + "class shouldNotBeImported {};", Lang_CXX, "class realDecl {};", Lang_CXX, + "shouldNotBeImported", RedirectingImporter::Constructor); + auto *Imported = cast(To); ---

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, aaron.ballman, lebedev.ri, JonasToth. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: gamesh411, rnkovacs. Herald added a project: clang. Accidentally taking the size of a struct

r359448 - [libclang] Restore old clang_Cursor_isAnonymous behaviour

Author: yvvan Date: Mon Apr 29 06:44:07 2019 New Revision: 359448 URL: http://llvm.org/viewvc/llvm-project?rev=359448&view=rev Log: [libclang] Restore old clang_Cursor_isAnonymous behaviour D54996 Changed the behaviour of clang_Cursor_isAnonymous, but there is no alternative available to get the

[PATCH] D61232: [libclang] Restore old clang_Cursor_isAnonymous behaviour

This revision was automatically updated to reflect the committed changes. Closed by commit rL359448: [libclang] Restore old clang_Cursor_isAnonymous behaviour (authored by yvvan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D61260: [clang-tidy] Extend bugprone-sizeof-expression to check sizeof(pointers to structures)

whisperity added inline comments. Comment at: test/clang-tidy/bugprone-sizeof-expression.cpp:196 typedef const MyStruct TMyStruct; + typedef const MyStruct *PMyStruct; While I trust Clang and the matchers to unroll the type and still match, I'd prefer also

[PATCH] D61239: [libclang] Allow field offset lookups in types with incomplete arrays.

JornVernee added a comment. @yvvan Mind taking a look here as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61239/new/ https://reviews.llvm.org/D61239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. The current diff (196894) seems to have the same `std::setw` issue as the previous one. Here's what it's trying to compile: _MRTIMP2 _Smanip __cdecl setw(streamsize wide) { // manipulator to set width return (_Smanip(&swfun, wide)); } Her

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. Apologies, I meant to write "here's what Clang is trying to call" in the previous comment. It's clear from looking at MSVC's output that MSVC expects to return indirectly via X0, implying that `_Smanip` is not aggregate by MSVC's definition. CHANGES SINCE

r359453 - [libclang] Add missing export for clang_Cursor_isAnonymousRecordDecl

Author: yvvan Date: Mon Apr 29 07:13:11 2019 New Revision: 359453 URL: http://llvm.org/viewvc/llvm-project?rev=359453&view=rev Log: [libclang] Add missing export for clang_Cursor_isAnonymousRecordDecl Follow up for D61232 to fix build. Modified: cfe/trunk/tools/libclang/libclang.exports Mod

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10362 +void CGOpenMPRuntime::emitFunctionProlog(CodeGenFunction &CGF, const Decl *D){ + if (const auto *FD = dyn_cast(D)) { Bad formatting. Comment at: lib/CodeGen/CG

[clang-tools-extra] r359455 - [clangd] Add separate unit tests for CanonicalIncludes. NFC

Author: sammccall Date: Mon Apr 29 07:36:26 2019 New Revision: 359455 URL: http://llvm.org/viewvc/llvm-project?rev=359455&view=rev Log: [clangd] Add separate unit tests for CanonicalIncludes. NFC Added: clang-tools-extra/trunk/clangd/unittests/CanonicalIncludesTests.cpp Modified: clang-to

[PATCH] D61264: Fix inconsistency in calculating DIAG_START values

russell.gallop created this revision. russell.gallop added reviewers: xazax.hun, rsmith. russell.gallop added a project: clang. Herald added a subscriber: rnkovacs. The inconsistency was introduced at r313975. As DIAG_SIZE_CROSSTU and DIAG_SIZE_COMMENT are both 100 this should be NFC. Repositor

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added inline comments. Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1080 + if (const auto *Constructor = dyn_cast(RD)) +if (Constructor->isUserProvided()) + return true; So I think that the problem with this new check is that it does

r359459 - [OPENMP]Fix PR41617: crash on template instantiation.

Author: abataev Date: Mon Apr 29 08:51:36 2019 New Revision: 359459 URL: http://llvm.org/viewvc/llvm-project?rev=359459&view=rev Log: [OPENMP]Fix PR41617: crash on template instantiation. Fixed the crash on the template instantiation when trying to check the data locality in the current instantia

[PATCH] D59465: [analyzer] Add example plugin for checker option handling

Szelethus planned changes to this revision. Szelethus added a comment. In D59465#1482302 , @whisperity wrote: > @Szelethus I know the dependent patch D59464 > will move `examples/analyzer-plugin` to > `test/Analysis/plug

r359468 - [LibTooling] Fix unneeded use of unique_ptr where shared_ptr is expected.

Author: ymandel Date: Mon Apr 29 09:57:40 2019 New Revision: 359468 URL: http://llvm.org/viewvc/llvm-project?rev=359468&view=rev Log: [LibTooling] Fix unneeded use of unique_ptr where shared_ptr is expected. Summary: This fixes a few places in the Stencil implementation where a unique_ptr is cre

[PATCH] D61005: [LibTooling] Fix unneeded use of unique_ptr where shared_ptr is expected.

This revision was automatically updated to reflect the committed changes. Closed by commit rL359468: [LibTooling] Fix unneeded use of unique_ptr where shared_ptr is expected. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

juliehockett added a comment. This is also making our Mac builders fail on configuration, and looks like a directory wasn't included properly when a test moved to a subdirectory -- would you mind taking a look? The CMake command we're running is at the top of the attached log. CMake Error at

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

jkorous added a comment. @MaskRay @juliehockett I'll take a look. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] r359470 - [clangd] Fix serialization logic for Origin and Flags.

Author: kadircet Date: Mon Apr 29 10:25:58 2019 New Revision: 359470 URL: http://llvm.org/viewvc/llvm-project?rev=359470&view=rev Log: [clangd] Fix serialization logic for Origin and Flags. Modified: clang-tools-extra/trunk/clangd/index/Serialization.cpp clang-tools-extra/trunk/clangd/uni

[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

ymandel updated this revision to Diff 197146. ymandel added a comment. Updated comment to more explicity describe motivation for new signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61015/new/ https://reviews.llvm.org/D61015 Files: clang

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor updated this revision to Diff 197149. teemperor added a comment. - Refactored test according to Gábor's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 Files: clang/include/clang/AST/ASTImporter.h clang/lib/AST/ASTImporte

[PATCH] D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools.

jkorous added a comment. Patch with fix for XPC tests https://reviews.llvm.org/D61271 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61187/new/ https://reviews.llvm.org/D61187 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55229: [COFF] Statically link certain runtime library functions

rnk added a comment. In D55229#1479712 , @jfb wrote: > Looks like this might have broken bots: I replied on Thursday, but it looks like it didn't make it to Phab: > I thought I reverted it, did I not push that? Looking now, it seems I did push the reve

[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

vzakhari added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:176 install( - DIRECTORY ${output_dir} + FILES ${install_files} DESTINATION ${header_install_dir} vzakhari wrote: > This is going to flatten the headers' install directory structur

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang updated this revision to Diff 197158. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 Files: include/clang/AST/DeclCXX.h include/clang/CodeGen/CGFunctionInfo.h lib/CodeGen/CGCall.cpp lib/CodeGen/MicrosoftCXXABI.cpp lib/Sema/SemaDe

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

mgrang added a comment. Thanks @richard.townsend.arm . I have updated the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D61051: [analyzer] Treat functions without runtime branches as "small".

NoQ added a comment. In D61051#1481976 , @Charusso wrote: > Great patch! There is only a design problem: > You have negated every `isSmall()` condition looks like you could write > `isLarge()` instead but there is no connection between these functions. >

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

RKSimon added inline comments. Comment at: lib/Format/FormatTokenLexer.cpp:249 + Identifier->ColumnWidth += Question->ColumnWidth; + Identifier->Type = Identifier->Type; + Tokens.erase(Tokens.end() - 1); @MyDeveloperDay Should this be ``` Identifier->Type = Qu

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

scott.linder created this revision. scott.linder added reviewers: Anastasia, tra, yaxunl, rjmccall. Herald added subscribers: cfe-commits, tpr. Herald added a project: clang. For AMDGPU the visibility of these symbols (OpenCL kernels, CUDA `__global__` functions, and CUDA `__device__` variables)

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

efriedma added a comment. I'd like to see a few more tests to cover the interesting cases that came up during development of this patch: 1. The user-provided constructor issue: there should be testcases with an explicit user-provided constructor, a non-trivial constructor that's explicitly def

[clang-tools-extra] r359489 - [clangd][xpc] Fix XPC unittests

Author: jkorous Date: Mon Apr 29 12:41:30 2019 New Revision: 359489 URL: http://llvm.org/viewvc/llvm-project?rev=359489&view=rev Log: [clangd][xpc] Fix XPC unittests Fix build after recent changes in clangd tests & add xpc unittests to check-clangd target. Differential Revision: https://reviews.

[PATCH] D61271: [clangd][xpc] Fix XPC unittests

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE359489: [clangd][xpc] Fix XPC unittests (authored by jkorous, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra CHANGES SINCE L

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

efriedma added subscribers: mgrang, rsmith. efriedma added a comment. I was going to ask if local variables are also supposed to be aligned this way... but I guess there's no way for standard C++ code to tell without explicitly making weird alignment assumptions, so let's not worry about that.

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

craig.topper added a comment. We seem to be missing test cases in test/Driver/x86-target-feature.c to test the command line options work. And test/Preprocessor/x86_target_features.c to make sure -mavx512bf16 enables avx512vl and avx512bw. Also need tests to make sure "-mavx512bf16 -mno-avx512bw

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

owenpan created this revision. owenpan added reviewers: klimek, sammccall, MyDeveloperDay, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes PR41213 . Repository: rC Clang https://reviews.ll

[PATCH] D61225: [COFF, ARM64] Align global symbol by size for ARM64 MSVC ABI

riccibruno added a comment. Since this is target-specific, is it right to put this here ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61225/new/ https://reviews.llvm.org/D61225 ___ cfe-commits mailing list cfe-comm

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. Something like: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new

[PATCH] D61217: Fix PCH skipping to handle all Lexers

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61217/new/ https://reviews.llvm.org/D61217 ___ cfe-commits mailing list cfe-commit

r359502 - [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

Author: teemperor Date: Mon Apr 29 14:02:35 2019 New Revision: 359502 URL: http://llvm.org/viewvc/llvm-project?rev=359502&view=rev Log: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. Summary: We are currently implementing support in LLDB that reconstructs the STL te

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

teemperor added a comment. I'll land this as it seems only the tests are subject to change and I want to also land the dependencies of this patch. Please let me know if you want any other changes changes to the test and thanks for the review! CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

rnk added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689 if ((Context.getTargetInfo().getCXXABI().isMicrosoft() || - Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment()) && + Context.getTargetInfo().getTriple(

[PATCH] D59485: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359502: [ASTImporter] Add an ImportImpl method to allow customizing Import behavior. (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D59485?vs=197149&id=197180#

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

rnk created this revision. rnk added reviewers: hans, mstorsjo. Herald added a project: clang. This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is Windows". The question remains, however, if this is really the correct thing to do. We could, for example, only not consider

[PATCH] D61175: [MinGW] Don't let template instantiation declarations cover nested classes

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: lib/Sema/SemaTemplateInstantiate.cpp:2687-2689 if ((Context.getTargetInfo().getCXXABI().isMicrosoft() || - Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment()) &

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61278/new/ https://reviews.llvm.org/D61278 ___

[PATCH] D61281: [clang-format] Fixed self assignment

xbolva00 created this revision. xbolva00 added a reviewer: MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D61281 Files: lib/Format/FormatTokenLexer.cpp Index: lib/Format/FormatTokenLexer.cpp =

[PATCH] D61280: Variable auto-init: don't initialize aggregate padding of all aggregates

jfb created this revision. jfb added reviewers: glider, pcc, kcc. Herald added subscribers: cfe-commits, dexonsmith, jkorous. Herald added a project: clang. C guarantees that brace-init with fewer initializers than members in the aggregate will initialize the rest of the aggregate as-if it were st

r359506 - When skipping code at the start of a file during PCH use, Preprocessor::Lex

Author: mikerice Date: Mon Apr 29 14:21:17 2019 New Revision: 359506 URL: http://llvm.org/viewvc/llvm-project?rev=359506&view=rev Log: When skipping code at the start of a file during PCH use, Preprocessor::Lex is not used since it consumes all preprocessor directives until it returns a real token

[PATCH] D61274: [Sema][AST] Explicit visibility for OpenCL/CUDA kernels/variables

tra added a comment. A kernel functions in CUDA is actually two different functions. One is the real kernel we compile for the GPU, another is a host-side stub that launches the device-side kernel. On device side both clang and nvcc currently silently ignore `hidden` visibility and force the k

[PATCH] D61217: Fix PCH skipping to handle all Lexers

This revision was automatically updated to reflect the committed changes. Closed by commit rC359506: When skipping code at the start of a file during PCH use, Preprocessor::Lex (authored by mikerice, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith added a comment. > xbolva00 abandoned this revision. Do you not want to pursue this any more? This seems reasonable to me, and is in line with other cases where we have diagnostic flags as aliases to GCC's similar-but-not-quite-the-same flags (eg, GCC's `-Wnoexcept-type` doesn't fire in

r359507 - Simplify exclusion of nested classes from extern template instantiation, NFC

Author: rnk Date: Mon Apr 29 14:32:05 2019 New Revision: 359507 URL: http://llvm.org/viewvc/llvm-project?rev=359507&view=rev Log: Simplify exclusion of nested classes from extern template instantiation, NFC Summary: This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is Wind

[PATCH] D61278: Simplify exclusion of nested classes from extern template instantiation, NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rL359507: Simplify exclusion of nested classes from extern template instantiation, NFC (authored by rnk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

xbolva00 added a comment. Ok, reclaiming patch. Thanks for the review! If the patch is fine, please approve it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58841/new/ https://reviews.llvm.org/D58841 ___ cfe-commits mailing list cfe-comm

[PATCH] D58841: [Diagnostics] Support -Wtype-limits for GCC compatibility

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. In D58841#1483128 , @xbolva00 wrote: > Thanks for the review! If the patch is fine, please approve it. Sure thing! (Phab doesn't permit approving a p

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. So, @compnerd and I have discussed and we'd like to propose a yaml schema that can express what we need for ifsos for the Sections and the Symbols. For the Symbols we want: Symbols: - Name:_dataA Type:STT_OBJECT Section:

[PATCH] D60910: [WIP] Dumping the AST to JSON

steveire added a comment. Thanks for doing this! I'm glad you were able to do it without needing to change the traverser class. That's a good indicator. I think it would be great if there were somewhere to document the non-stability of the format and content here. Comment at

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

vsapsai added a comment. I see you've ended up implementing the intrinsics with inline assembly but are there any reasons not to do it with builtins like in this patch? The problem with inline assembly is that for some Apple platforms we require developers to emit bitcode. And inline assembly i

[PATCH] D58321: Support for relative vtables

leonardchan updated this revision to Diff 197196. leonardchan marked an inline comment as done. leonardchan retitled this revision from "[WIP] Support for relative vtables" to "Support for relative vtables". leonardchan added a comment. Ok. Formally requesting for code reviews now. - Made the fl

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

NoQ added inline comments. Comment at: test/Analysis/cxx-uninitialized-object.cpp:1155 +void __vector_size__LongTest() { + VectorSizeLong v; +} gribozavr wrote: > gribozavr wrote: > > gribozavr wrote: > > > Could you also add tests where the vector member is bei

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. I think I know the format that I'd like *roughly*. I haven't worked out how to handle COMDAT and section groups yet. Roland seems to think that COMDAT and section groups will be an issue but I'm working out the details with him to make sure I understand it. I'll ge

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. In D60974#1483164 , @plotfi wrote: > So, @compnerd and I have discussed and we'd like to propose a yaml schema > that can express what we need for ifsos for the Sections and the Symbols. > > ... Can you clarify is this is f

[PATCH] D60974: Clang IFSO driver action.

jakehehrlich added a comment. To clarify my format is for the unmerged format. The merged format should be the ELFStub internal representation found in llvm's TextAPI. The plan is to have at minimum .tbe and ELF stubs. I'm actively working on getting the ELF stub output which can then be conver

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483210 , @jakehehrlich wrote: > In D60974#1483164 , @plotfi wrote: > > > So, @compnerd and I have discussed and we'd like to propose a yaml schema > > that can express what we ne

[PATCH] D44387: [x86] Introduce the pconfig/encl[u|s|v] intrinsics

craig.topper added a comment. The main reason that we used inline assembly is due to the fixed register allocation for these instructions. We would have had to write out the register rules in the backend as a special case as seen in the getInstrWFourImplicitOps in https://reviews.llvm.org/D4438

[PATCH] D60974: Clang IFSO driver action.

plotfi added a comment. In D60974#1483209 , @jakehehrlich wrote: > I think I know the format that I'd like *roughly*. I haven't worked out how > to handle COMDAT and section groups yet. Roland seems to think that COMDAT > and section groups will be an

[PATCH] D61246: [analyzer][UninitializedObjectChecker] PR41611: Regard vector types as primitive

Szelethus updated this revision to Diff 197209. Szelethus added a comment. Add `TODO:`s about missing warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61246/new/ https://reviews.llvm.org/D61246 Files: lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h test

[PATCH] D61136: [Analyzer] IteratorChecker - Ensure end()>=begin() and refactor begin and end symbol creation

NoQ added a comment. In D61136#1480023 , @baloghadamsoftware wrote: > Abstract iterator positions are represented by symbolic expressions because > we must be able to do simple calculations with them. This has nothing to do > with iterator objects repre

r359512 - Make test more robust by writing stdout/stderr to different files.

Author: dyung Date: Mon Apr 29 15:57:15 2019 New Revision: 359512 URL: http://llvm.org/viewvc/llvm-project?rev=359512&view=rev Log: Make test more robust by writing stdout/stderr to different files. Our internal build bots were failing this test randomly as the stderr output was emitted to the fi

  1   2   >