richard.townsend.arm added inline comments.
================ Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1080 + if (const auto *Constructor = dyn_cast<CXXConstructorDecl>(RD)) + if (Constructor->isUserProvided()) + return true; ---------------- So I think that the problem with this new check is that it doesn't check all of the constructors. I replaced it with for (auto it = RD->ctor_begin(); it != RD->ctor_end(); ++it) { if (it->isUserProvided()) return true; } And that seems to resolve the `setw` problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits