ABataev added inline comments.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10362
+void CGOpenMPRuntime::emitFunctionProlog(CodeGenFunction &CGF, const Decl *D){
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
----------------
Bad formatting.
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
+ if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) {
+ HasEmittedDeclareTargetRegion = true;
----------------
No need for the braces
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364
+ if (const auto *FD = dyn_cast<FunctionDecl>(D)) {
+ if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) {
+ HasEmittedDeclareTargetRegion = true;
----------------
ABataev wrote:
> No need for the braces
What if `declare target` is used only for variabes but not for the functions?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60568/new/
https://reviews.llvm.org/D60568
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
