[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

jdenny added a comment. > Just wanted to give a bit more visibility to the underrated technology of > writing -verify=a,b,c instead of the #ifdefclutter. It's great to see this getting more use. > It's also a bit wonky because it seems that you have to write an exponential > number of flags to

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

jdenny added a comment. In D60732#1469026 , @jdenny wrote: > Sometimes you can avoid an explosion of FileCheck prefixes using -D. I'm not > aware of anything like -D for -verify. I mean a -D that expands a variable within an expected diagnostic. Repo

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + gtbercea wrote: > ABataev wrote: > > gtbercea wrote: > > > gtbercea w

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov updated this revision to Diff 195425. ilya-biryukov added a comment. - Simplify rawByExpanded by using a helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59887/new/ https://reviews.llvm.org/D59887 Files: clang/include

[PATCH] D60539: Add -std=c++14 language standard option to tests that require C++14 default

sammccall added a comment. In D60539#1469012 , @nemanjai wrote: > > Do you need to build clangd? We explicitly don't aim to support building > > everywhere clang can be built, maybe we should just disable in this case? > > Our environment includes various

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. fantastic Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:644 + /// Flag for keeping track of weather a target region has been emitted. + bool hasEmittedTargetRegion = false; + ABataev wrote: > gtbercea

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8975 +CGM.Error(Clause->getBeginLoc(), + "Target region emitted before requires directive."); + HasRequiresUnifiedSharedMemory = true; The message speaks abou

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman added a comment. In D60455#1468714 , @bader wrote: > In D60455#1468386 , @Fznamznon wrote: > > > > Ok, my question is whether you are planning to duplicate the same logic > > > as for OpenCL kernel wh

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks ok - thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59923/new/ https://reviews.llvm.org/D59923

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri requested changes to this revision. lebedev.ri added inline comments. This revision now requires changes to proceed. Comment at: llvm/unittests/ADT/APSIntTest.cpp:188-194 + EXPECT_FALSE(CharBoundaryUnder.isNegative()); + EXPECT_TRUE(CharBoundaryUnder.isNonNegative())

[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

jdenny added a comment. Is there anything I can do to help this patch make progress? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59168/new/ https://reviews.llvm.org/D59168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D60776: [clang-tidy] Add test support for the fix description.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/test/clang-tidy/check_clang_tidy.py:109 check_notes_prefix = 'CHECK-NOTES' + file_check_suffix +check_fix_descriptions_pr

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/unittests/ADT/APSIntTest.cpp:188-194 + EXPECT_FALSE(CharBoundaryUnder.isNegative()); + EXPECT_TRUE(CharBoundaryUnder.isNonNegative()); + EXPECT_TRUE(CharBoundaryUnder.isStrictlyPositive());

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri marked an inline comment as done. lebedev.ri added inline comments. Comment at: llvm/unittests/ADT/APSIntTest.cpp:162 +TEST(APSIntTest, UnsignedHighBit) { + APSInt False(APInt(1, 0)); Can you please duplicate this whole test but for signed `APSInt`?

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call. Repository: rG

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:381 + # Don't allow 'clang' or 'llvm' namespaces + if module == 'llvm' or module == 'clang': +namespace = module + '_check' We don't have the `clang` module. No need to

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

craig.topper added a comment. Wondering if it would be better to assert for asking for the sign of an unsigned APSInt. I could see a caller just wanting to get the msb for some reason and not knowing that isNegative won’t work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny updated this revision to Diff 195452. jdenny added a comment. Duplicate new APSInt test but for signed type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 Files: clang/test/OpenMP/distribute_collapse_messages.cpp clang/test/OpenMP/d

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469295 , @craig.topper wrote: > Wondering if it would be better to assert for asking for the sign of an > unsigned APSInt. I could see a caller just wanting to get the msb for some > reason and not knowing that isN

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469301 , @lebedev.ri wrote: > In D59712#1469295 , @craig.topper > wrote: > > > Wondering if it would be better to assert for asking for the sign of an > > unsigned APSInt. I coul

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469358 , @jdenny wrote: > In D59712#1469301 , @lebedev.ri > wrote: > > > In D59712#1469295 , @craig.topper > > wrote: > > > > > Wonde

[PATCH] D60335: Use -fomit-frame-pointer when optimizing PowerPC code

kernigh added a comment. I'm stuck. I didn't put a test in this patch because I can't run the tests yet. So far, I can build a clang executable but can't build the rest of the project. I won't run the tests without a complete build, and I won't edit the tests without running them. I had diffic

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang created this revision. akhuang added reviewers: hans, rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. This emits labels around heapallocsite calls and S_HEAPALLOCSITE debug info in codeview. Currently only changes FastISel,

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195475. akhuang added a comment. remove comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-in

[PATCH] D58094: Fix -Wnonportable-include-path suppression for header maps with absolute paths.

vsapsai added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58094/new/ https://reviews.llvm.org/D58094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195478. akhuang added a comment. more typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-info-c

r358537 - Modify test to use -S instead of -c so that it works when an external assembler is used that is not present.

Author: dyung Date: Tue Apr 16 15:52:05 2019 New Revision: 358537 URL: http://llvm.org/viewvc/llvm-project?rev=358537&view=rev Log: Modify test to use -S instead of -c so that it works when an external assembler is used that is not present. Modified: cfe/trunk/test/Driver/modules.cpp Modifi

[PATCH] D60233: [clang-scan-deps] initial outline of the tool that runs preprocessor to find dependencies over a JSON compilation database

jkorous added inline comments. Comment at: tools/clang-scan-deps/ClangScanDeps.cpp:39 + bool runInvocation(std::shared_ptr Invocation, + FileManager *Files, + std::shared_ptr PCHContainerOps, `Files` -> `FileMgr` might be

r358538 - [NFC] Remove unused function (Sema::pushExternalDeclIntoScope)

Author: leonardchan Date: Tue Apr 16 15:59:39 2019 New Revision: 358538 URL: http://llvm.org/viewvc/llvm-project?rev=358538&view=rev Log: [NFC] Remove unused function (Sema::pushExternalDeclIntoScope) Modified: cfe/trunk/include/clang/Sema/Sema.h cfe/trunk/lib/Sema/SemaDecl.cpp Modified:

[PATCH] D60800: [MS] Emit S_HEAPALLOCSITE debug info

akhuang updated this revision to Diff 195480. akhuang added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60800/new/ https://reviews.llvm.org/D60800 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/debug-inf

[PATCH] D58033: Add option for emitting dbg info for call sites

aprantl added a comment. And if we plan to enable it by default, too, perhaps not adding a driver option (CC1 only) is preferable, since we need to maintain compatibility with driver options indefinitely. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58033/new/ https://reviews.llvm.or

[PATCH] D53076: [analyzer] ConditionBRVisitor: Enhance to write out more information

NoQ accepted this revision. NoQ added a comment. Yay!! I'm happy with this change and redirected all my wrath on its dependencies. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53076/new/ https://reviews.llvm.org/D53076 ___ cfe-commits mai

[PATCH] D60807: Test for Oz fail

vitalybuka created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. -Oz builds are usually significantly large than -Os build Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60807 Files: clang/test/CodeGen/oz.cpp __

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm updated this revision to Diff 195495. bd1976llvm added a comment. No longer shortening "dependent libraries" to "deplibs" except for the .deplibs section (as this takes up bytes on disk). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60274/new/ https://reviews.llvm.org/D6027

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ updated this revision to Diff 195497. NoQ added a comment. Fix comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60808/new/ https://reviews.llvm.org/D60808 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h clang/lib/StaticAnalyzer/Core/BugReporte

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, a.sidorin, szepet, kristof.beyls, javed.absar. Herald added a project: clang. NoQ up

[PATCH] D60807: Test for Oz fail

pcc added a comment. Interesting, it looks like the difference here is almost entirely due to different inlining decisions. And according to the tool I posted here: http://lists.llvm.org/pipermail/llvm-dev/2019-April/131811.html in the few functions in which we made the same inlining decisions,

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak updated this revision to Diff 195498. ahatanak added a comment. Keep a list of pairs of BlockDecl and SourceLocation and, after the body of an ObjC method is parsed, emit a diagnostic if a SourceLocation in the list is inside an escaping block. Repository: rC Clang CHANGES SINCE LA

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

NoQ added a comment. In D60732#1469026 , @jdenny wrote: > The original patch added documentation to `-cc1 -help`. Doxygen for > VerifyDiagnosticConsumer is another possibility except it currently doesn't > mention command-line usage at all. Maybe it sh

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:49 +// Bind(Zero) +Store StX0 = +StMgr.Bind(StInit, LX0, Zero).getStore(); a_sidorin wrote: > This can fit one line. Just wan

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195500. NoQ added a comment. Fxd constructors and destructors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60742/new/ https://reviews.llvm.org/D60742 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/string.c clang/unitte

r358544 - [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

Author: maskray Date: Tue Apr 16 18:46:27 2019 New Revision: 358544 URL: http://llvm.org/viewvc/llvm-project?rev=358544&view=rev Log: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf Summary: When -gsplit-dwarf is used together with other -g options, in most cases the

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rL358544: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repositor

[clang-tools-extra] r358549 - clangd: Change Windows.h to windows.h.

Author: pcc Date: Tue Apr 16 20:02:18 2019 New Revision: 358549 URL: http://llvm.org/viewvc/llvm-project?rev=358549&view=rev Log: clangd: Change Windows.h to windows.h. This makes the file more cross compilation friendly. Modified: clang-tools-extra/trunk/clangd/Threading.cpp Modified: clan

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

jdenny added a comment. In D59712#1469392 , @lebedev.ri wrote: > In D59712#1469358 , @jdenny wrote: > > > In D59712#1469301 , @lebedev.ri > > wrote: > > > > > In D59712#1469

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added a comment. In D59806#1469257 , @aaron.ballman wrote: > LGTM! You can either land this now and refactor after the AST matcher lands, > or you can wait until the AST matcher lands and land this patch after -- your > call. I will plan

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:2580 +if (const BlockDecl *BD = CurContext->getInnerMostBlockDecl()) + if (!getDiagnostics().isIgnored(diag::warn_implicitly_retains_self, Loc)) +ImplicitlyRetainedSelfLocs.push_back({

[PATCH] D60808: [analyzer] pr41335: NoStoreFuncVisitor: Fix crash when no-store event is in a body-farmed function.

NoQ added a comment. Hmm, i think i'd love to know why doesn't the uninitialized variable checker fire on the if-statement as farmed by the body farm: 592 // Signature: 593 // _Bool OSAtomicCompareAndSwapPtr(void *__oldValue, 594 // void *__newValue,

[PATCH] D59712: [APSInt][OpenMP] Fix isNegative, etc. for unsigned types

lebedev.ri added a comment. In D59712#1469693 , @jdenny wrote: > In D59712#1469392 , @lebedev.ri > wrote: > > > In D59712#1469358 , @jdenny wrote: > > > > > In D59712#146930

[clang-tools-extra] r358561 - [clangd] lower_bound -> bsearch, NFC

Author: sammccall Date: Wed Apr 17 00:00:36 2019 New Revision: 358561 URL: http://llvm.org/viewvc/llvm-project?rev=358561&view=rev Log: [clangd] lower_bound -> bsearch, NFC Modified: clang-tools-extra/trunk/clangd/index/Symbol.cpp clang-tools-extra/trunk/clangd/index/dex/PostingList.cpp

<    1   2