lebedev.ri added a comment. In D59712#1469295 <https://reviews.llvm.org/D59712#1469295>, @craig.topper wrote:
> Wondering if it would be better to assert for asking for the sign of an > unsigned APSInt. I could see a caller just wanting to get the msb for some > reason and not knowing that isNegative won’t work. Yes, i, too, would think an assert is much better solution (since i literally just tripped over this in this review.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59712/new/ https://reviews.llvm.org/D59712 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
