craig.topper added a comment.

Wondering if it would be better to assert for asking for the sign of an 
unsigned APSInt. I could see a caller just wanting to get the msb for some 
reason and not knowing that isNegative won’t work.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59712/new/

https://reviews.llvm.org/D59712



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to