[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split

baloghadamsoftware added a comment. Ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53701/new/ https://reviews.llvm.org/D53701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D55007: [Analyzer] Constraint Manager - Calculate Effective Range for Differences

baloghadamsoftware added a comment. Herald added a subscriber: Charusso. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55007/new/ https://reviews.llvm.org/D55007 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D57860: [analyzer] Validate checker option names and values

baloghadamsoftware added a comment. In D57860#1432728 , @dcoughlin wrote: > I think it would be better if the default for compatibility mode were 'true'. > That way this change will be backwards compatible and clients who want to > enforce stricter check

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added a comment. In D55170#1431854 , @MyDeveloperDay wrote: > > I'm sorry for not having a positive answer here, but I'm not in favor of > > this change. The style rule looks like it introduces arbitrary complexity > > at a point where I don't un

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Index.h:59 +return sizeof(*this) + Arena.getTotalMemory() + + sizeof(value_type) * Relations.size(); + } -

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk added a comment. @klimek I agree that the rule is somewhat arbitrary. However, it's the style rule of an established codebase with many users (I don't have a concrete number, but the project has 1400 stars on github ). I've found this patch useful when c

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, mgrang, jkorous, MaskRay, ioeric. Herald added a project: clang. For counting number of references clangd was relying on merging every duplication of a symbol. Unf

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

hans added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp This requires (a recent version of) Win 10 or late

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6390 +/// Given OpenMP directive, matches the first clause (out of all specified), +/// that matches InnerMatcher. +/// Other comments usually don't explain the interactions with

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

lebedev.ri marked 4 inline comments as done. lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said m

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ioeric added a comment. I'm not sure if FileIndex is the correct layer to make decision about how References is calculated. Currently, we have two use cases in clangd 1) one slab per TU and 2) one slab per file. It seems to me that we would want different strategies for the two use cases, so it

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the OpenMPClau

[PATCH] D59463: [ASTMatchers][OpenMP] OpenMP Structured-block-related matchers

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6389 +/// Given OpenMP directive, matches if it is an OpenMP standalone directive, +/// i.e. an executable directive with no structured block. "Matches standalone OpenMP direct

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

lebedev.ri marked 5 inline comments as done. lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said m

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the OpenMPClau

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

lebedev.ri marked 3 inline comments as done. lebedev.ri added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said m

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable directives. +/// I.e. those returned by OMPExecutableDirective::getStructuredBloc

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > I don't think risk is what matters - in the end it's about cost, and cost is > a very technical reason I'm really sorry I'm not trying to be difficult its just over the years I keep seeing this being said in reviews? but what is the cost? I assume you don't

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

gribozavr added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6456 + // Note that we have recieved a *matcher* for the clause, not the + // OpenMPClauseKind. We now need to extract the 'return' type of said matcher, + // and convert it to the OpenMPClau

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin marked an inline comment as done. ikudrin added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp hans

[PATCH] D57112: [ASTTypeTraits][ASTMatchers][OpenMP] OMPClause handling

aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:6400 +/// \endcode +AST_MATCHER_P(OMPExecutableDirective, hasClause, internal::Matcher, + InnerMatcher) { gribozavr wrote: > Looking at other similar matches, th

[PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

teemperor created this revision. teemperor added reviewers: martong, balazske, a.sidorin, shafik. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. We are currently implementing support in LLDB that reconstructs the STL templates from the target program in the expres

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Moved testing of the default header into the Driver test and also added a test line for C++ mode in printf test. Follow up from https://reviews.llvm.org/D59219 https://reviews.llvm.or

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits. Feel free to fix and commit without further review if you'd like. Comment at: docs/ReleaseNotes.rst:141 + +- New `-callbacks`

[PATCH] D57571: [clang-tidy] A new OpenMP module

aaron.ballman added a comment. While I'm okay with this, I would mildly prefer it if landed with at least one check rather than entirely empty (IIRC, that's how we'd added new modules in the past). Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5757

[libunwind] r356365 - Creating release candidate final from release_800 branch

Author: hans Date: Mon Mar 18 05:53:32 2019 New Revision: 356365 URL: http://llvm.org/viewvc/llvm-project?rev=356365&view=rev Log: Creating release candidate final from release_800 branch Added: libunwind/tags/RELEASE_800/final/ - copied from r356364, libunwind/branches/release_80/ ___

[libclc] r356365 - Creating release candidate final from release_800 branch

Author: hans Date: Mon Mar 18 05:53:32 2019 New Revision: 356365 URL: http://llvm.org/viewvc/llvm-project?rev=356365&view=rev Log: Creating release candidate final from release_800 branch Added: libclc/tags/RELEASE_800/final/ - copied from r356364, libclc/branches/release_80/ _

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

ioeric created this revision. ioeric added reviewers: kadircet, gribozavr. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Previously, when the renamed spelling is ambiguous, we simply use the full-qualfied name (with leading "::"). This patch makes it try adding a

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

aaron.ballman added a comment. In D59467#1432675 , @Tyker wrote: > if likely/unlikely can be applied to any statement or label what should be > generated when it is applied to a statement that don't have any conditional > branch ? should it be ignored ?

[PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

balazske added a comment. I do not know if "Shim" is the correct name for this, maybe "Strategy" is better? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59485/new/ https://reviews.llvm.org/D59485 ___ cfe-commits ma

[clang-tools-extra] r356366 - [pp-trace] Delete -ignore and add a new option -callbacks

Author: maskray Date: Mon Mar 18 06:30:17 2019 New Revision: 356366 URL: http://llvm.org/viewvc/llvm-project?rev=356366&view=rev Log: [pp-trace] Delete -ignore and add a new option -callbacks Summary: -ignore specifies a list of PP callbacks to ignore. It cannot express a whitelist, which may be

[PATCH] D59296: [pp-trace] Delete -ignore and add a new option -callbacks

MaskRay updated this revision to Diff 191075. MaskRay retitled this revision from "[pp-trace] Delete -ignore and add generalized -callbacks" to "[pp-trace] Delete -ignore and add a new option -callbacks". MaskRay edited the summary of this revision. MaskRay added a comment. Add a test with space

[PATCH] D59296: [pp-trace] Delete -ignore and add a new option -callbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rL356366: [pp-trace] Delete -ignore and add a new option -callbacks (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGE

[PATCH] D59485: [ASTImporter] Allow adding a shim to the ASTImporter

balazske added a comment. The replace of `Import` calls may work if the internal state of the `ASTImporter` is updated correctly from the 'shim' object (especially if not every Decl is handled by the shim). For this to work some of the state of `ASTImporter` that was intended to be internal mus

[PATCH] D45978: dllexport const variables must have external linkage.

zahiraam added a comment. In D45978#1431057 , @aaron.ballman wrote: > LGTM! Would you mind committing the changes please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added a comment. Before i do address any further bike^W review notes in other reviews in this path stack, i want to finish with this review. If **this** change doesn't stick, rest is pointless waste of everyone's time. @ABataev please do tell if there is any outstanding issues here. I

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

bader added a comment. I see seven OpenCL C tests using -finclude-default-header option and AFAIK, only test/Driver/include-default-header.cl doesn't parse it. Could you also update OpenCL C tests? I think clang/test/Headers/opencl-c-header.cl and test/Driver/include-default-header.cl fully cov

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

baloghadamsoftware added a comment. Ping! Any news regarding this patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57108/new/ https://reviews.llvm.org/D57108 ___ cfe-commits mailing list cfe-commits

[PATCH] D57855: [analyzer] Reimplement checker options

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Aside from little comment it seems OK. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:200 +#undef PACKAGE_OPTION +#undef GET_PACKAGE_OPTI

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

baloghadamsoftware added a comment. In D58367#1425922 , @Szelethus wrote: > As I understand it, this solution could be used to entirely get rid of the > current bugreporter visitor structure (at least for checkers), right? The > discussion seems to concl

[PATCH] D57108: [clang-tidy] diagnose possibiltiy to add 'noexcept' in modernize-use-noexcept

JonasToth added a comment. In D57108#1433087 , @baloghadamsoftware wrote: > Ping! Any news regarding this patch? Its on the todolist, but i currently have many things to do in my real life, so no time for clang-tidy development :( Repository: rCTE

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191093. Anastasia added a comment. Better wording CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp test

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Variadic macros are used for debugging and therefore it is desirable to accept the code that uses them. There was a discussion about this in OpenCL spec bugs: https://github.com/Khrono

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191094. Anastasia added a comment. Fixed comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files: docs/UsersManual.rst include/clang/Basic/DiagnosticLexKinds.td lib/Lex/PPDirectives.cpp test/

[PATCH] D59457: [analyzer][NFC] Use capital variable names in CheckerRegistry

baloghadamsoftware added a comment. Please rename the patch. Its name does not really express its content. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59457/new/ https://reviews.llvm.org/D59457 ___ cfe-commits mail

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 191095. mikhail.ramalho added a comment. Fixes: - `FindZ3.cmake` format . - Wrong `SMTExpr` namespace in `SMTConstraintManager.h`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: clang/CMak

[PATCH] D59458: [analyzer][NFC] Clang-format CheckerRegistry

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. No patch should be committed without clang-formatting anyway... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59458/new/ https://review

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-co

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added a comment. As far as I'm concerned, I don't have any major revision requests. I haven't reviewed the unit tests (I'm planning to), but for non-test code, I don't have any further comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/

[PATCH] D59493: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added subscribers: cfe-commits, jdoerfert, dmgreen, zzheng. Herald added a project: clang. [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint)) For both !{!"llvm.loop.unroll

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

kzhuravl added a comment. Backend change will be posted later today. I am currently working on adding backend tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 ___ cfe-commits mailing list cfe-

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

kzhuravl created this revision. kzhuravl added reviewers: b-sumner, rampitec, t-tye. Herald added subscribers: jfb, tpr, dstuttard, yaxunl, wdng. kzhuravl added a comment. Backend change will be posted later today. I am currently working on adding backend tests. https://reviews.llvm.org/D59494

[PATCH] D59493: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! The wording in spec is confusing btw because it says: > This attribute qualifier can be used to specify full unrolling or partial > unrolling by a specified amount. May b

[PATCH] D54978: Move the SMT API to LLVM

delcypher added a comment. In D54978#1432178 , @ddcc wrote: > In D54978#1431935 , @delcypher wrote: > > > Would one of you be able to file a bug against Z3 to fix this? I am no > > longer in a position to contribut

[PATCH] D59493: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

Anastasia added a comment. PS, I am just saying that I guess leaving this to the compiler is more helpful than explicitly requiring the full unroll. However, spec contradicts itself by first mentioning the full unroll and then stating that compiler will determines the unrolling factor. Reposi

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

Anastasia updated this revision to Diff 191100. Anastasia added a comment. Moved testing of default header in C++ mode to test/Headers/opencl-c-header.cl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59486/new/ https://reviews.llvm.org/D59486 Files: test/Driver/include-default-header

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith added a comment. In D59388#1431314 , @jkorous wrote: > Hi Duncan, thanks for working on better interfaces in clang! > > I am just wondering - is it safe to have the lifetime of a single object on > heap managed by two different `IntrusiveRefCnt

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/Driver/include-default-header.cl:2 +// RUN: %clang -save-temps -x cl -Xclang -cl-std=CL2.0 -Xclang -finclude-default-header -emit-llvm -S -### %s 2>&1 | FileCheck %s +// RUN: %clang -sa

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

dexonsmith updated this revision to Diff 191104. dexonsmith added a comment. Document the default VFS used by the `FileManager`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 Files: clang-tools-extra/clangd/Compiler.cpp clang/include/clang

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

dexonsmith added a comment. In D59377#1431203 , @jkorous wrote: > In D59377#1430002 , @dexonsmith > wrote: > > > ... since I noticed that FileManager ... > > > This kind of implies that we should move the comment f

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Tooling/Core/Lookup.cpp:165 +if (UnspelledScopes.empty()) { + Disambiguated = "::" + Disambiguated; +} else { maybe ret

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith updated this revision to Diff 191105. dexonsmith added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59388/new/ https://reviews.llvm.org/D59388 Files: clang-tools-extra/clang-move/ClangMove.cpp clang-tools-extra/clang-tidy/ClangTidy.cpp clang-tools-e

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev added a comment. The OpenMP part looks good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/ https://reviews.llvm.org/D59214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

ioeric marked 2 inline comments as done. ioeric added inline comments. Comment at: lib/Tooling/Core/Lookup.cpp:165 +if (UnspelledScopes.empty()) { + Disambiguated = "::" + Disambiguated; +} else { kadircet wrote: > maybe return or break afterwards? I

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker updated this revision to Diff 191115. Tyker added a comment. i think we are suppose to hook likely/unlikely on builtin_expected, for if, for, while, switch. but i have no idea how we could hook it if we need to support catch. i added a revision with likely/unlikely and the correct semanti

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7973 + if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { +if (Scope != SyncScope::OpenCLAllSVMDevices) + Name = Twine(Twine(Name) + Twine("-")).str(); if (!Name.empty()

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. Could you provide a little bit more comments what are you doing in this patch? It would be good t have a detailed description of the codegen scheme. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2390 } + case OMPRTL__tgt_target_data_mapper: { +//

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

rnk added a comment. Apparently I wrote this comment long ago and never hit send. Comment at: lib/CodeGen/CGDeclCXX.cpp:484 AddGlobalCtor(Fn, 65535, COMDATKey); +if (getTarget().getCXXABI().isMicrosoft()) { + // In The MS C++, MS add template static data member in

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 191128. akhuang added a comment. fix some typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py

r356385 - [AMDGPU] Add the missing clang change of the experimental buffer fat pointer

Author: hliao Date: Mon Mar 18 11:11:37 2019 New Revision: 356385 URL: http://llvm.org/viewvc/llvm-project?rev=356385&view=rev Log: [AMDGPU] Add the missing clang change of the experimental buffer fat pointer Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp cfe/trunk/test/CodeGen/target-d

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. OpenCL C++ part looks good. Thanks! Comment at: test/Headers/opencl-c-header.cl:57-65 char f(char x) { -#if __OPENCL_C_VERSION__ != CL_VERSION_2_0 +#if !defined(__OPENCL_CPP_V

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CGDeclCXX.cpp:484 AddGlobalCtor(Fn, 65535, COMDATKey); +if (getTarget().getCXXABI().isMicrosoft()) { + // In The MS C++, MS add template

r356388 - [OPENMP] Set scheduling for doacross loops as schedule, 1.

Author: abataev Date: Mon Mar 18 11:40:00 2019 New Revision: 356388 URL: http://llvm.org/viewvc/llvm-project?rev=356388&view=rev Log: [OPENMP] Set scheduling for doacross loops as schedule, 1. The default scheduling for doacross loops is changed from static to static, 1. Modified: cfe/trunk/

Re: r311065 - Further refactoring of the constant emitter. NFC.

It looks like this change introduced a small bug; Specifically, the following cast test: - if (auto PT = dyn_cast(DestTy)) { ... + // If we're producing a pointer, this is easy. + if (auto destPtrTy = cast(destTy)) { Since the cast can fail, shouldn't you prefer dyn_cast<>(), which can re

[PATCH] D59394: [Sema] De-duplicate some availability checking logic

erik.pilkington requested review of this revision. erik.pilkington added a comment. In D59394#1430221 , @ldionne wrote: > I can confirm this fixed my original problem. It's also close to the patch I > attempted writing myself earlier this week -- but this

[PATCH] D59440: add steps to preprocess file and reduce command line args

rnk added inline comments. Comment at: clang/utils/creduce-clang-crash.py:106-117 + # Check that an empty file is not interesting + # file_to_reduce is hardcoded into the test, so this is a roundabout + # way to run it on an empty file + _, tmpfile = tempfile.mkstemp() + _,

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 14:39, Don Hinton wrote: It looks like this change introduced a small bug; Specifically, the following cast test: - if (auto PT = dyn_cast(DestTy)) { ... + // If we're producing a pointer, this is easy. + if (auto destPtrTy = cast(destTy)) { Since the cast can fail, s

r356397 - [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

Author: epilk Date: Mon Mar 18 12:23:45 2019 New Revision: 356397 URL: http://llvm.org/viewvc/llvm-project?rev=356397&view=rev Log: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics These diagnose overflowing calls to subset of fortifiable functions. Some functions, like sprintf or strcpy

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rC356397: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D58797?vs=190549&id=191142#toc Repository: rC Cl

Re: r311065 - Further refactoring of the constant emitter. NFC.

Hi John: I found this investigating the cast assert noted here: http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html I subsequently did quick grep and found a number of cases in clang+llvm (didn't find any in other projects) . I'm happy to fix these in mass, i.e., s/cast/dyn_cast/, but

[PATCH] D58548: IR: Support parsing numeric block ids, and emit them in textual output.

jyknight added a comment. Sorry, forgot to re-ping this in a timely manner. :) The discussion on mailing list concluded positively, so waiting for an LG here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58548/new/ https://reviews.llvm.org/D58548

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

jyknight accepted this revision. jyknight added a comment. Looks good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59346/new/ https://reviews.llvm.org/D59346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. LGTM; I wonder if it makes sense to have predefined macro for the C++ tag (or perhaps just a regular macro for use in libcxxabi?) Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D59448: [WebAssembly] Change wasm.throw's first argument to an immediate

craig.topper added a comment. Shouldn't the definition in BuiltinsWebAssembly.def be updated to include an 'I' in the type string so that this will be properly diagnosed in the frontend? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59448/new/ https://reviews.ll

[PATCH] D59455: Thread safety analysis: Add note for unlock kind mismatch

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: include/clang/Analysis/Analyses/ThreadSafety.h:127 + SourceLocation LocLocked,

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 191152. mikhail.ramalho added a comment. Updated script to parse Z3's headers and changed the workflow to handle cross compilation cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: cla

[PATCH] D54978: Move the SMT API to LLVM

ddcc added inline comments. Comment at: llvm/cmake/modules/FindZ3.cmake:92 + + set(Z3_VERSION_STRING ${Z3_MAJOR}.${Z3_MINOR}.${Z3_MAJOR}) + unset(z3_version_str) Should be ${Z3_MAJOR}.${Z3_MINOR}.${Z3_BUILD_NUMBER} CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Hi all, I just updated the CMake script to get the version by parsing the header, however, I just found a potential issue in the previous approach: if we have incompatible libs in the path (32-bits libs when compiling in 64-bit mode) the CMake config will succe

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

paquette created this revision. paquette added reviewers: rsmith, jyknight. Herald added a project: clang. Since these are only ever run once, they can be marked as cold. On top of that, since they're only ever run once, they might as well be minsize. I observed a 0.21% code size improvement in

[PATCH] D59455: Thread safety analysis: Add note for unlock kind mismatch

aaronpuchert added inline comments. Comment at: include/clang/Analysis/Analyses/ThreadSafety.h:127 + SourceLocation LocLocked, SourceLocation Loc) {} aaron.ballman wrote: > Can yo

[PATCH] D57645: [C++2a] Fix PR40576: Turn destroying delete off prior to C++2a. Add -fdestroying-delete

EricWF abandoned this revision. EricWF added a comment. Herald added a subscriber: jdoerfert. This is the wrong approach. Abandoning. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57645/new/ https://reviews.llvm.org/D57645 _

[PATCH] D59509: Make static constructors + destructors minsize + cold (except for in -O0)

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/static-attr.cpp:4 + +// WITHOUT-NOT: cold minsize noinline +// WITH: define internal void @__cxx_global_var_init() [[ATTR:#[0-9]]] This is fragile, it may have false-negative if they appear in other

[PATCH] D58827: [Sema][NFCI] Don't allocate storage for the various CorrectionCandidateCallback unless we are going to do some typo correction

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think this is worth the complexity of the repeated clone methods. lgtm Comment at: lib/Sema/SemaType.cpp:5911 ExprResult AddrSpace = S.ActOnIdExpression( - S.getC

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added a comment. Should it be downgraded to a warning about an extension instead of just removing it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-commits@

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

shafik accepted this revision. shafik added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D59457: [analyzer][NFC] Use capital variable names in CheckerRegistry

xazax.hun added a comment. I did not check the patch yet but wanted to point out that we might not want to rush about renaming all the variables until the community decides on the coding guideline, see https://reviews.llvm.org/D59251 Repository: rC Clang CHANGES SINCE LAST ACTION https://

[PATCH] D59455: Thread safety analysis: Add note for unlock kind mismatch

aaron.ballman added inline comments. Comment at: include/clang/Analysis/Analyses/ThreadSafety.h:127 + SourceLocation LocLocked, SourceLocation Loc) {} aaronpuchert wrote: > aaron.

Re: r311065 - Further refactoring of the constant emitter. NFC.

On 18 Mar 2019, at 15:38, Don Hinton wrote: Hi John: I found this investigating the cast assert noted here: http://lists.llvm.org/pipermail/cfe-dev/2019-March/061685.html I subsequently did quick grep and found a number of cases in clang+llvm (didn't find any in other projects) . I'm happy t

r356423 - [X86] Add gcc rotate intrinsics to ia32intrin.h

Author: ctopper Date: Mon Mar 18 15:25:57 2019 New Revision: 356423 URL: http://llvm.org/viewvc/llvm-project?rev=356423&view=rev Log: [X86] Add gcc rotate intrinsics to ia32intrin.h This is another attempt at what Erich Keane tried to do in r355322. This adds rolb, rolw, rold, rolq and their ror

  1   2   >