[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

Reid Kleckner via Phabricator via cfe-commits Mon, 18 Mar 2019 11:21:49 -0700

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.


lgtm



================
Comment at: lib/CodeGen/CGDeclCXX.cpp:484
     AddGlobalCtor(Fn, 65535, COMDATKey);
+    if (getTarget().getCXXABI().isMicrosoft()) {
+      // In The MS C++, MS add template static data member in the linker
----------------
rnk wrote:
> We might really want isOSBinFormatCOFF, since I think the same issue affects 
> Windows Itanium with -OPT:REF and LLD.
On reflection, it's probably best not to mess with mingw for now. Let's just 
commit this as is.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58160/new/

https://reviews.llvm.org/D58160



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58160: MS ABI: adding template static member in the linker directive section to make sure init function can be called before main.

Reply via email to