dexonsmith added a comment. In D59377#1431203 <https://reviews.llvm.org/D59377#1431203>, @jkorous wrote:
> In D59377#1430002 <https://reviews.llvm.org/D59377#1430002>, @dexonsmith > wrote: > > > ... since I noticed that FileManager ... > > > This kind of implies that we should move the comment from `FileManager` > constructor implementation to the header thus making it an explicit part of > the interface contract. > > // If the caller doesn't provide a virtual file system, just grab the real > // file system. > > > Maybe https://reviews.llvm.org/D59388 would be the right place to do it. Good call; since I'm relying on it in this patch I've updated this patch to document it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
