[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. In D58418#1430160 , @thakis wrote: > Why is this needed for index-while-building? My mental model for > index-while-building is that that streams out build index metadata as part of > the regular compile. Why does that require wa

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 190789. LegalizeAdulthood added a comment. Herald added a subscriber: jdoerfert. To avoid passing lots of state to/from extracted functions, extract a class instead and use member variables for most of the state CHANGES SINCE LAST ACTION https:/

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. From what I can tell this looks OK as you seem to be mainly only passing down the boolean, my guess is that while most people don't use the -lines directly that often but it pr

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

lebedev.ri added a comment. Starting to look good i think. Comment at: docs/ReleaseNotes.rst:88 +- New alias :doc:`abseil-make-unique + ` to :doc:`modernize-make-unique Also add a new entry about the new option for `modernize-make-unique`. CHANGES SINCE LA

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. So @russellmcc you've been bumping along this road nicely for 6 months, doing what people say... pinging every week or so in order to get your code reviewed, and you are getti

[PATCH] D58882: [Diagnostics] Address of a standard library function

xbolva00 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58882/new/ https://reviews.llvm.org/D58882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

klimek added a comment. In D40988#1430502 , @MyDeveloperDay wrote: > So @russellmcc you've been bumping along this road nicely for 6 months, > doing what people say... pinging every week or so in order to get your code > reviewed, and you are getting n

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, reuk, JonasToth, alexfh, krasimir, russellmcc. MyDeveloperDay added a project: clang-tools-extra. Herald added a subscriber: jdoerfert. An addendum to D59087: [clang-format] [PR25010] AllowShortIfStatementsOn

[PATCH] D40988: Clang-format: add finer-grained options for putting all arguments on one line

MyDeveloperDay added a comment. > nobody being able to make changes Nobody IS able to make changes, but not because of complexity! We discourage away potential contributors/maintainers by leaving their reviews for weeks/months/years, not just not letting them in, not even discussing them.. M

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov marked 5 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FuzzyMatch.cpp:74 static bool isAwful(int S) { return S < AwfulScore / 2; } -static constexpr int PerfectBonus = 3; // Perfect per-pattern-char score. +stati

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov updated this revision to Diff 190796. ilya-biryukov added a comment. - Added comments - Add a test case for 'onmes' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 Files: clang-tools-extra/c

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/XRefs.h:62 +/// Find the record type references at \p Pos. +const CXXRecordDecl *findRecordTypeAt(ParsedAST &AST, Position Pos); + nridge wrote: > ilya-biryukov wrote: > > This method looks

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks Nathan! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56370/new/ https://reviews.llvm.org/D56370 ___

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov added a comment. The only important comment is about test coverage Comment at: clang-tools-extra/clangd/AST.cpp:84 +if (auto STL = TL.getAs()) { + std::vector ArgLocs; + for (unsigned I = 0; I < STL.getNumArgs(); I++) kadircet wrote:

[PATCH] D57532: [Index] Make sure c-index-test finds libc++ on Mac

ilya-biryukov added a comment. Lost this one after vacation, sorry. Still need to figure out why the test is failing. Any help appreaciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57532/new/ https://reviews.llvm.org/D57532

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil updated this revision to Diff 190798. carwil added a comment. Done. I've added an extra parameter over what you might expect as classifyArgumentTypes doesn't seem to consider AAPCS16, whereas classifyReturnTypes does. I've also renamed the variable to make the distinction between it and t

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1644 +llvm::raw_ostream &OS) { + A.getTypeSourceInfo()->getType().print(OS, PP); +} kadircet wrote: > ilya-biryukov wrote: > > kadircet wrote: > > > il

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ioeric added inline comments. Comment at: clang-tools-extra/clangd/FuzzyMatch.cpp:285 + if (Pat[P] == Word[W] || + (WordRole[W] == Head && (IsPatSingleCase || PatRole[P] == Head))) ++S; ilya-biryukov wrote: > ioeric wrote: > > could you explain the int

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. (The result looks great) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 ___

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1655 + case TemplateArgument::ArgKind::Expression: + case TemplateArgument::ArgKind::Pack: +A.getArgument().print(PP, OS); ilya-biryukov wrote: > Now that you mentioned other kinds of

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 190800. kadircet marked 11 inline comments as done. kadircet added a comment. - Add more tests - Replace switch with if - Use SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://review

r356250 - Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

Author: d0k Date: Fri Mar 15 04:09:41 2019 New Revision: 356250 URL: http://llvm.org/viewvc/llvm-project?rev=356250&view=rev Log: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types We already handle pointers and references, member ptrs are just another specia

[PATCH] D59387: Make getFullyQualifiedName qualify both the pointee and class type for member ptr types

This revision was automatically updated to reflect the committed changes. Closed by commit rL356250: Make getFullyQualifiedName qualify both the pointee and class type for member… (authored by d0k, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov updated this revision to Diff 190803. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. Address comments: - Shorten the comment to fit it into a single line. - Added a comment about single-case patterns Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FuzzyMatch.cpp:285 + if (Pat[P] == Word[W] || + (WordRole[W] == Head && (IsPatSingleCase || PatRole[P] == Head))) ++S; ioeric wrote: > ilya-biryukov wrote: > > ioeric wrote: > >

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov updated this revision to Diff 190804. ilya-biryukov added a comment. - A better name for the new test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 Files: clang-tools-extra/clangd/Fuz

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. In D58418#1430490 , @jkorous wrote: > In D58418#1430160 , @thakis wrote: > > > Why is this needed for index-while-building? My mental model for > > index-while-building is that that streams

[clang-tools-extra] r356254 - Rename directory housing clang-change-namespace to be eponymous

Author: nico Date: Fri Mar 15 04:54:01 2019 New Revision: 356254 URL: http://llvm.org/viewvc/llvm-project?rev=356254&view=rev Log: Rename directory housing clang-change-namespace to be eponymous Makes the name of this directory consistent with the names of the other directories in clang-tools-ext

[PATCH] D59361: [CUDA][Windows] Partial fix for bug 38811 (Step 1 of 3)

This revision was automatically updated to reflect the committed changes. Closed by commit rC356255: [CUDA][Windows] Partial fix for bug #38811 (Step 1 of 3) (authored by emankov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59361?vs=190607&id=190809#toc Repository: rC

r356255 - [CUDA][Windows] Partial fix for bug #38811 (Step 1 of 3)

Author: emankov Date: Fri Mar 15 05:05:36 2019 New Revision: 356255 URL: http://llvm.org/viewvc/llvm-project?rev=356255&view=rev Log: [CUDA][Windows] Partial fix for bug #38811 (Step 1 of 3) Partial fix for the clang Bug https://bugs.llvm.org/show_bug.cgi?id=38811 "Clang fails to compile with CU

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added a comment. This mostly looks good, one high level comment: I believe it makes sense to deduplicate SymbolIDs for RelationSlab. Up until now, we mostly had only one occurence of a SymbolID in a Slab, but RelationSlab does not follow that assumption. Also can you add a few tests aft

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr requested changes to this revision. gribozavr added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:27 +/// be invoked even if the directory is empty. +class DirectoryWatcher { +public:

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/Index.cpp:35 +auto *Array = Arena.Allocate(Rels.size()); +std::uninitialized_copy(Rels.begin(), Rels.end(), Array); +Result.emplace_back(Entry.first, Use `ArrayRef::copy()`, f

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:43 +public: + using value_type = std::pair>; + using const_iterator = std::vector::const_iterator; gribozavr wrote: > `struct Relation`? And in the comments for it, please expla

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a warning is raised from the expansion of a system macro that involves pasted token, there was still situations were they were not skip

[clang-tools-extra] r356261 - [clangd] Tune the fuzzy-matching algorithm

Author: ibiryukov Date: Fri Mar 15 07:00:49 2019 New Revision: 356261 URL: http://llvm.org/viewvc/llvm-project?rev=356261&view=rev Log: [clangd] Tune the fuzzy-matching algorithm Summary: To reduce the gap between prefix and initialism matches. The motivation is producing better scoring in one p

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

This revision was automatically updated to reflect the committed changes. Closed by commit rL356261: [clangd] Tune the fuzzy-matching algorithm (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' + We typically use `| count 0` instead of an expli

[clang-tools-extra] r356264 - [clangd] Remove includes of "gmock-matchers.h". NFC

Author: ibiryukov Date: Fri Mar 15 07:30:07 2019 New Revision: 356264 URL: http://llvm.org/viewvc/llvm-project?rev=356264&view=rev Log: [clangd] Remove includes of "gmock-matchers.h". NFC For consistency with most of the test code. Modified: clang-tools-extra/trunk/unittests/clangd/ExpectedT

[PATCH] D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic.

JonasToth added a comment. What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59318/new/ https://reviews.llvm.org/D59318

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

aaron.ballman added a comment. I think the release notes should be updated to mention that a previously-supported option has been removed and that there's a new option available as a replacement; I don't think we have any other docs for pp-trace to worry about updating, do we? ==

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

JonasToth added a comment. From my side its LGTM, but I would let @serge-sans-paille accept, as he is probably more familiar with python then I am. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 __

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

bader added a comment. > May be test/Driver/include-default-header.cl would make more sense to show > the intent? test/Headers/opencl-c-header.cl sounds like good candidate. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59219/new/ https://reviews.llvm.org/D59219

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin created this revision. ikudrin added reviewers: ioeric, bkramer, hans, thakis, rsmith, zturner. Herald added a project: clang. This patch partially reverts D46942 . If the source file path contains directory junctions, and we resolve them when printing di

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59233/new/ https://reviews.llvm.org/D59233 ___ cf

[PATCH] D59418: [OpenMP][Offloading] Extract common functionality

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added a project: OpenMP. Herald added a project: clang. This patch introduces the CGOpenMPRuntimeTarget class to collect helpers and functionality common to all target offloadin

[PATCH] D59420: [NFC][OpenMP] Move runtime function generation to the target codegen

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added projects: OpenMP, clang. jdoerfert added a parent revision: D59418: [OpenMP][Offloading] Extract common functionality. This commit simply moves the runtime function gener

[PATCH] D59421: [OpenMP][Offloading] Allow to build the TRegion interface functions

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added projects: OpenMP, clang. This patch adds the TRegion interface functions to the ones we can build through the common OpenMP target offloading class. This is a preperation

[PATCH] D59328: [OpenMP][Offloading][2/3] Codegen for target regions (TRegions)

jdoerfert updated this revision to Diff 190840. jdoerfert added a comment. Remove code extracted into separate commits, see D59418 , D59420 , and D59421 . Repository: rG LLVM Github Monorepo C

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

shafik accepted this revision. shafik added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. I realize this isn't the correct solution, but would any would-be reviewers like to comment on the problem? Whether it's here or on the Bugzilla report https://bugs.llvm.org/show_bug.cgi?id=39287, as a newcomer to Clang modules I could use some help understanding whet

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus planned changes to this revision. Szelethus marked 3 inline comments as done. Szelethus added a comment. Alright, I'll de-clutter this patch a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 _

r356277 - [HIP-Clang] propagate -mllvm options to opt and llc

Author: aaronenyeshi Date: Fri Mar 15 10:31:51 2019 New Revision: 356277 URL: http://llvm.org/viewvc/llvm-project?rev=356277&view=rev Log: [HIP-Clang] propagate -mllvm options to opt and llc Change the HIP Toolchain to pass the OPT_mllvm options into OPT and LLC stages. Added a lit test to verif

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. I'll look more closely into the details, but just a high-level question now: why would we want to make this optional and not simply surface these extra diagnostics? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356277: [HIP-Clang] propagate -mllvm options to opt and llc (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D59316?vs=190474&id=190850#toc Repository: rC

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, I

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

jkorous added a comment. @ilya-biryukov could you please give details about the quality metric you are using and some description of posted measurements? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 _

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Mar 8, 2019 at 5:06 PM Aaron Ballman wrote: > > On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman > > wrote: > >> > >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > >> > > >> > > >> > Indeed, and the existing import_mo

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added a comment. Looks very polished, thanks! Will have to sink the change in a bit, will come back with more comments on Monday. In the meantime, a few initial comments and suggestions. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:54 +/// bo

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/lib/Sema/SemaChecking.cpp:338 + case Builtin::BI__builtin___vsnprintf_chk: { +DiagID = diag::warn_memcpy

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added a project: OpenMP. This commit implements the existing void** buffer used to share arguments between threads in a team with a byte-wise buffer. For now, the void** buffer

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert updated this revision to Diff 190861. jdoerfert marked an inline comment as done. jdoerfert added a comment. Rebase onto D59424 and fix errors caused by the wrong use of ident_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added a comment. > What is this buffer used for? [...] I'll copy your comment and respond in this review D59424 . Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +///

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

CodaFi created this revision. CodaFi added reviewers: georgemorgan, mehdi_amini, kristina. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls, javed.absar, dberris. Herald added a project: clang. D33259 hard-coded a linker flag relative to a linker

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

jkorous added a comment. In D59377#1430002 , @dexonsmith wrote: > ... since I noticed that FileManager ... This kind of implies that we should move the comment from `FileManager` constructor implementation to the header thus making it an explicit part o

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, j

[PATCH] D59423: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3)

This revision was automatically updated to reflect the committed changes. Closed by commit rC356291: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3) (authored by emankov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D59423?vs=

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert updated this revision to Diff 190866. jdoerfert marked an inline comment as done. jdoerfert added a comment. Fix the set/release use case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59424/new/ https://reviews.llvm.org/D59424 Files: o

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as not done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + > Wh

r356291 - [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3)

Author: emankov Date: Fri Mar 15 12:04:46 2019 New Revision: 356291 URL: http://llvm.org/viewvc/llvm-project?rev=356291&view=rev Log: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3) Partial fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". [Synopsis] __sptr

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > > What is this buffer used for? Tra

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1429580 , @yaxunl wrote: > Here we are looking at the code which emulates a "linker" for HIP toolchain. > The offloading action builder requests the offloading toolchain have a > linker, but amdgpu does not have a real l

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert updated this revision to Diff 190868. jdoerfert added a comment. Fix a typo (use of wrong variable) and improve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 Files: openmp/libomptarge

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, bader. Herald added subscribers: jdoerfert, ebevhan, yaxunl. Not sure it's the right approach but the idea is that we would like to accept vector contraction syntax from OpenCL C. This commit fixes Sema checks when creating a

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431238 , @arsenm wrote: > In D59316#1429580 , @yaxunl wrote: > > > Here we are looking at the code which emulates a "linker" for HIP > > toolchain. The offloading action builder r

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, +

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

efriedma accepted this revision. efriedma added a reviewer: t.p.northover. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/TargetInfo.cpp:6023 + // Variadic functions should always marshal to the base standard. + b

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added a comment. In D59302#1431045 , @ilya-biryukov wrote: > I'll look more closely into the details, but just a high-level question now: > why would we want to make this optional and not simply surface these extra > diagnostics? The optional

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431253 , @yaxunl wrote: > In D59316#1431238 , @arsenm wrote: > > > In D59316#1429580 , @yaxunl wrote: > > > > > Here we are looking at the

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, j

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote:

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431276 , @arsenm wrote: > In D59316#1431253 , @yaxunl wrote: > > > In D59316#1431238 , @arsenm wrote: > > > > > In D59316#1429580

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431284 , @yaxunl wrote: > In D59316#1431276 , @arsenm wrote: > > > In D59316#1431253 , @yaxunl wrote: > > > > > In D59316#1431238

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

jkorous added a comment. Hi Duncan, thanks for working on better interfaces in clang! I am just wondering - is it safe to have the lifetime of a single object on heap managed by two different `IntrusiveRefCntPtr` instances? Comment at: clang/lib/Frontend/ASTUnit.cpp:1693

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote:

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, +

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

r356296 - [coroutines][PR40978] Emit error for co_yield within catch block

Author: modocache Date: Fri Mar 15 13:25:49 2019 New Revision: 356296 URL: http://llvm.org/viewvc/llvm-project?rev=356296&view=rev Log: [coroutines][PR40978] Emit error for co_yield within catch block Summary: As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an error to use the `c

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

This revision was automatically updated to reflect the committed changes. Closed by commit rC356296: [coroutines][PR40978] Emit error for co_yield within catch block (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D59076?vs=190740&id=190890#toc Reposit

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache added a comment. Great, thanks for the reviews, everyone! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. In D58418#1430630 , @thakis wrote: > In D58418#1430490 , @jkorous wrote: > > > In D58418#1430160 , @thakis wrote: > > > > > Why is this needed for in

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 190893. mikhail.ramalho added a comment. Update Z3 script to use cmake's `try_run` in order to retrieve the version from the lib. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: clang/CMake

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Hi all, Sorry for the massive delay, but I just updated the `FindZ3` script to retrieve the version from the lib. I changed it to use `try_run` instead of `try_compile` so we can get the version number. I tried to use @brzycki code to get the version from the h

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

lebedev.ri added a reviewer: dexonsmith. lebedev.ri added a comment. In D59196#1429393 , @riccibruno wrote: > I am not an expert in the serialization code (just did some modifications), > but this seems reasonable to me. That's my thoughts too.. Unless

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431302 , @arsenm wrote: > > ML workloads are extremely unlikely to use a call. We should have an > execution tests with noinline somewhere to stress this I compiled and ran a test with noinline function and I saw fu

  1   2   >