[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Charusso added a comment. In general I think it would be cool to think all of the problems in the same time as these really depends on the `CoreEngine` and how we operates with `ExplodedNodes`. In D58367#1405185 , @NoQ wrote: > In particular, the implem

[PATCH] D53701: [Analyzer] Instead of recording comparisons in interator checkers do an eager state split

baloghadamsoftware updated this revision to Diff 187732. baloghadamsoftware added a comment. `processComparison()` refactored. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53701/new/ https://reviews.llvm.org/D53701 Files: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp Index: lib/S

[PATCH] D57896: Variable names rule

MyDeveloperDay added a comment. In D57896#1402280 , @zturner wrote: > Since someone already accepted this, I suppose I should mark require changes > to formalize my dissent As it was Chris @lattner who accepted it, is your request for changes just base

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58492 Files: clangd/Threading.cpp Index: clangd/T

[clang-tools-extra] r354558 - [clangd] Handle another incomplete-type diagnostic case in IncludeFixer.

Author: ioeric Date: Thu Feb 21 01:33:49 2019 New Revision: 354558 URL: http://llvm.org/viewvc/llvm-project?rev=354558&view=rev Log: [clangd] Handle another incomplete-type diagnostic case in IncludeFixer. Modified: clang-tools-extra/trunk/clangd/IncludeFixer.cpp clang-tools-extra/trunk/u

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187738. kadircet added a comment. - Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: include/clang/Index/IndexingAction.h lib/Index/IndexDecl.cpp lib/Index/IndexSy

r354560 - [clang][Index] Enable indexing of Template Type Parameters behind a flag

Author: kadircet Date: Thu Feb 21 01:52:33 2019 New Revision: 354560 URL: http://llvm.org/viewvc/llvm-project?rev=354560&view=rev Log: [clang][Index] Enable indexing of Template Type Parameters behind a flag Summary: clangd uses indexing api to provide references and it was not possible to perfor

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC354560: [clang][Index] Enable indexing of Template Type Parameters behind a flag (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58293?vs=187738&id=187739#toc

[clang-tools-extra] r354561 - [clangd] Enable indexing of template type parameters

Author: kadircet Date: Thu Feb 21 01:55:00 2019 New Revision: 354561 URL: http://llvm.org/viewvc/llvm-project?rev=354561&view=rev Log: [clangd] Enable indexing of template type parameters Summary: Fixes https://bugs.llvm.org/show_bug.cgi?id=36285 Reviewers: ilya-biryukov Subscribers: ioeric, Ma

[PATCH] D58294: [clangd] Enable indexing of template type parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354561: [clangd] Enable indexing of template type parameters (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58294?vs=187371&id=187741#toc Repository: rCTE

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. Could you add some text into the docs/ReleaseNotes.rst to say you are adding a new option take a look at https://clang.llvm.org/extra/ReleaseNotes.html#improvements-to-clang-tidy for an example CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:15 #include #define DEBUG_TYPE "format-formatter" Nice! its the irony of clang-format code is that its not clang formatte

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

MyDeveloperDay added a comment. Could I ask if you don't want to pursue this review that you Abandon it. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58178/new/ https://reviews.llvm.org/D58178 ___ cfe-

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added a comment. Could you add a line in the docs/ReleaseNotes.rst to say what you are adding CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function templates are not handled well currently. We want t

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:649 LLVMStyle.AllowShortIfStatementsOnASingleLine = false; + LLVMStyle.AllowShortLambdasOnASingleLine = FormatStyle::SLS_All; LLVMStyle.AllowShortLoopsOnASingleLine = false; What

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

wipascal added a comment. In D10833#1394154 , @dyhe83 wrote: > In D10833#970906 , @milianw wrote: > > > still looks good to me. can someone else please review and commit this? > > > ping please Repository: rC C

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet created this revision. kadircet added reviewers: ilya-biryukov, sammccall. Herald added subscribers: cfe-commits, arphaman, mgrang, jkorous, MaskRay, ioeric. Herald added a project: clang. Clangd was reporting implicit symbols, like results of implicit cast expressions during code naviga

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

gmit added a comment. In D58178#1405397 , @MyDeveloperDay wrote: > Could I ask if you don't want to pursue this review that you Abandon it. Sure, I already wanted that, but I don't see any options that would result in closing the issue. Could you, plea

[PATCH] D41720: [clang-tidy] Add a -show-color flag.

jhasse added a comment. What are you thoughts about using an environment variable for this? Due to the number of differently named flags, it's often hard to configure a CI system to display color in every tool. (I'm trying to push for a standard for this, see https://bixense.com/clicolors/) C

[PATCH] D58178: [clang-tidy] RawStringLiteralCheck: isRawStringLiteral doesn't check all erroneous cases

MyDeveloperDay added a comment. In D58178#1405430 , @gmit wrote: > In D58178#1405397 , @MyDeveloperDay > wrote: > > > Could I ask if you don't want to pursue this review that you Abandon it. > > > Sure, I already w

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

ilya-biryukov added a reviewer: hokein. ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. Haojian is the author, so adding him as a reviewer. LGTM from my side Co

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay updated this revision to Diff 187748. MyDeveloperDay added a comment. Add to release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 Files: docs/ClangFormat.rst docs/ClangFormatStyleOptions.rst docs/ReleaseNotes.rst

[PATCH] D57768: [SYCL] Add SYCL device compilation flow.

bader updated this revision to Diff 187751. bader added a comment. Applied comments from @ABataev. - Split changes into two patches. This part contains front-end option enabling device specific macro. Changes adding driver option will be sent in a separate patch. - Added LIT test Repository:

r354568 - [OpenCL] Simplify LLVM IR generated for OpenCL blocks

Author: asavonic Date: Thu Feb 21 03:02:10 2019 New Revision: 354568 URL: http://llvm.org/viewvc/llvm-project?rev=354568&view=rev Log: [OpenCL] Simplify LLVM IR generated for OpenCL blocks Summary: Emit direct call of block invoke functions when possible, i.e. in case the block is not passed as a

[PATCH] D58446: [CodeComplete] Collect visited contexts when scope specifier is invalid.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58446/new/ https://reviews.llvm.org/D58446 ___

[PATCH] D58388: [OpenCL] Simplify LLVM IR generated for OpenCL blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC354568: [OpenCL] Simplify LLVM IR generated for OpenCL blocks (authored by asavonic, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58388/new/ https://revie

[PATCH] D58446: [CodeComplete] Collect visited contexts when scope specifier is invalid.

ioeric updated this revision to Diff 187756. ioeric added a comment. - Cleanup unit tests (forgot to run... sorry) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58446/new/ https://reviews.llvm.org/D58446 Files: lib/Sema/SemaCodeComplete.cpp unittests/Sema/Co

[PATCH] D58446: [CodeComplete] Collect visited contexts when scope specifier is invalid.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354570: [CodeComplete] Collect visited contexts when scope specifier is invalid. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

r354570 - [CodeComplete] Collect visited contexts when scope specifier is invalid.

Author: ioeric Date: Thu Feb 21 03:22:58 2019 New Revision: 354570 URL: http://llvm.org/viewvc/llvm-project?rev=354570&view=rev Log: [CodeComplete] Collect visited contexts when scope specifier is invalid. Summary: This will allow completion consumers to guess the specified scope by putting toget

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai created this revision. nemanjai added a reviewer: rsmith. Herald added a subscriber: jdoerfert. Herald added a project: clang. When the `Preprocessor (PP)` in compiler instance is going away, we should clear the cache of any pointers that it owns as they will be destroyed. This is one p

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

hokein added a comment. +1 on removing the implicit references, sometimes it gives very confusing results. Comment at: clangd/XRefs.cpp:113 struct DeclInfo { const Decl *D; This structure is not used anymore, remove it. Comment at: cla

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Since commit 56f5487e4387a69708f70724d00e9e076153 [modules] Round-trip -Werror flag through explicit module build. the behavior of CXTranslationUnit_KeepGoing changed: Unresolved #i

[PATCH] D58501: [libclang] Fix CXTranslationUnit_KeepGoing

nik updated this revision to Diff 187765. nik added a comment. Fixed minor typo. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58501/new/ https://reviews.llvm.org/D58501 Files: include/clang/Basic/Diagnostic.h lib/Basic/DiagnosticIDs.cpp test/Index/Inputs/

[PATCH] D58502: [ASTImporter] Fix redecl failures of Class and ClassTemplate

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of classes and class templates are not handled well

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

ilya-biryukov added a reviewer: gribozavr. ilya-biryukov added a subscriber: gribozavr. ilya-biryukov added a comment. Not an expert on MacOS threading APIs, only checked this builds on Mac. @gribozavr could you confirm using these APIs is the right thing to do on Mac? Comment

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

ilya-biryukov added inline comments. Comment at: clangd/Threading.cpp:125 +#elif defined(__APPLE__) + // https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/getpriority.2.html + setpriority(PRIO_DARWIN_THREAD, 0,

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. I think what you would really want to do is mark the masks as `inline constexpr`, but sadly inline variables are C++17 only. I have seen some ways to emulate inline variables but I am not sure whether it is worth doing so in this case. CHANGES SINCE LAST ACTION h

[PATCH] D57662: [clang-tidy] Parallelise clang-tidy-diff.py

alexfh added a comment. A few more comments. Comment at: clang-tidy/tool/clang-tidy-diff.py:58 + with lock: +sys.stdout.write((' '.join(command)).decode('utf-8') + '\n' + stdout.decode('utf-8') + '\n') +if stderr: nit: let's wrap this to 8

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405615 , @riccibruno wrote: > I think what you would really want to do is mark the masks as `inline > constexpr`, but sadly inline variables are C++17 only. I have seen some ways > to emulate inline variables but I a

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet updated this revision to Diff 187778. kadircet marked 2 inline comments as done. kadircet added a comment. - Add more test cases - Get rid of number of parameters check in implicitness control Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:469 auto AST = TestTU::withCode(T.code()).build(); // Ordered assertions are deliberate: we expect a predictable order. + EXPECT_THAT(locateSymbolAt(AST,

[PATCH] D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow.

ABataev added inline comments. Comment at: clang/test/Preprocessor/sycl-macro.cpp:1 +// RUN: %clang_cc1 %s -fsycl-is-device -E -dM | FileCheck %s + Add a test that without this option `__SYCL_DEVICE_ONLY__` is not defined Repository: rG LLVM Github Monorepo

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Do you have permissions on the repo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58186/new/ https://reviews.llvm.org/D58186

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia created this revision. Anastasia added reviewers: AlexeySotkin, hans. Herald added subscribers: jdoerfert, ebevhan, yaxunl. https://reviews.llvm.org/D58504 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === -

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle updated this revision to Diff 187783. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55250/new/ https://reviews.llvm.org/D55250 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h c

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle marked an inline comment as done. malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:816 +// If the client supports Markdown, convert from plaintext here. +if (*H && HoverSupportsMarkdown) { + (*H)->contents.kind

[clang-tools-extra] r354585 - [clangd] Only report explicitly typed symbols during code navigation

Author: kadircet Date: Thu Feb 21 06:48:33 2019 New Revision: 354585 URL: http://llvm.org/viewvc/llvm-project?rev=354585&view=rev Log: [clangd] Only report explicitly typed symbols during code navigation Summary: Clangd was reporting implicit symbols, like results of implicit cast expressions dur

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia marked an inline comment as done. Anastasia added a subscriber: ABataev. Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the C

[PATCH] D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768 ___

[PATCH] D57768: [SYCL] Add clang front-end option to enable SYCL device compilation flow.

bader updated this revision to Diff 187785. bader added a comment. Add check that SYCL specific macro is not enabled by default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57768/new/ https://reviews.llvm.org/D57768 Files: clang/include/clang/

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

hokein accepted this revision. hokein added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:462 Foo a = $1^str; - Foo b = Foo($2^str); + Foo b = F$9^oo($2^str); Foo c = $3^f(); nit: keep the number in sort.

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the Clang C/C++/Objective-C/OpenCL frontend

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

ABataev added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the Clang C/C++/Objective-C/OpenCL frontend, part of the LLVM Compiler Infrastructure, re

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354585: [clangd] Only report explicitly typed symbols during code navigation (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58495?vs=187786&id=187788#toc Re

[PATCH] D58495: [clangd] Only report explicitly typed symbols during code navigation

kadircet updated this revision to Diff 187786. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58495/new/ https://reviews.llvm.org/D58495 Files: clangd/XRefs.cp

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. In D57914#1405665 , @pgousseau wrote: > In D57914#1405615 , @riccibruno > wrote: > > > I think what you would really want to do is mark the masks as `inline > > constexpr`, but sadly in

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:816 +// If the client supports Markdown, convert from plaintext here. +if (*H && HoverSupportsMarkdown) { + (*H)->contents.kind = MarkupKind::Markdown; ---

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the Clang C/C++/Objective-C/OpenCL frontend

[PATCH] D58509: [CodeGen] Fix string literal address space casting.

hliao created this revision. hliao added a reviewer: yaxunl. Herald added subscribers: cfe-commits, jvesely. Herald added a project: clang. - If a string literal is reused directly, need to add necessary address space casting if the target requires that. Repository: rG LLVM Github Monorepo h

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

AlexeySotkin added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- Why the "C" is removed ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

r354593 - [CUDA]Delayed diagnostics for the asm instructions.

Author: abataev Date: Thu Feb 21 07:51:30 2019 New Revision: 354593 URL: http://llvm.org/viewvc/llvm-project?rev=354593&view=rev Log: [CUDA]Delayed diagnostics for the asm instructions. Summary: Adapted targetDiag for the CUDA and used for the delayed diagnostics in asm constructs. Works for both

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354593: [CUDA]Delayed diagnostics for the asm instructions. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

AlexeySotkin added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- AlexeySotkin wrote: > Why the "C" is removed ? Should we call the section like: "

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

kkwli0 added inline comments. Comment at: docs/ReleaseNotes.rst:14 -This document contains the release notes for the Clang C/C++/Objective-C +This document contains the release notes for the Clang C/C++/Objective-C/OpenCL frontend, part of the LLVM Compiler Infrastructure, rel

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405781 , @riccibruno wrote: > In D57914#1405665 , @pgousseau wrote: > > > In D57914#1405615 , @riccibruno > > wrote: > > > > > I think

r354596 - Revert "[CUDA]Delayed diagnostics for the asm instructions."

Author: abataev Date: Thu Feb 21 08:40:21 2019 New Revision: 354596 URL: http://llvm.org/viewvc/llvm-project?rev=354596&view=rev Log: Revert "[CUDA]Delayed diagnostics for the asm instructions." This reverts commit r354593 to fix the problem with the crash on windows. Removed: cfe/trunk/test

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: jdoerfert, dexonsmith, jkorous. This patch avoids copying blocks that initialize or are assigned to local auto variables to the heap when the local auto

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. To define the masks as `constexpr` variables you will have to make at least `bitPosToMask`, `operator|`, `operator&` and `operator~`. Unfortunately `constexpr` functions in c++11 are rather restricted. It seems to me however that you could do the following: 1. Wait

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. More explicitly something like: in `Sanitizer.h`: template struct SanitizerMasks { static const SanitizerMask SomeMask; /* and so on for each mask*/ }; template const SanitizerMask SanitizerMasks::SomeMask = the definition; And then you can write

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. I'm not a code owner here but we seem to be lacking people who are either available, able, willing or allowed to approve code reviews for some of the code in the clang-tooling (not just clang format). The code owners do an extremely good job at doing a deep revi

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. In D28462#1405711 , @klimek wrote: > In D28462#1405360 , @MyDeveloperDay > wrote: > > > I'm not a code owner here but we seem to be lacking people who are either > > available, able

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1405855 , @MyDeveloperDay wrote: > In D28462#1405711 , @klimek wrote: > > > In D28462#1405360 , > > @MyDeveloperDay wrote: > > > > > I'm n

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added a comment. In D28462#1405360 , @MyDeveloperDay wrote: > I'm not a code owner here but we seem to be lacking people who are either > available, able, willing or allowed to approve code reviews for some of the > code in the clang-tooling (not

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. > Yes, we are, and as you said, it needs a set of patches to learn the code > base enough to contribute, to build up trust. This is easiest when the code > base is currently under active development, but many people consider > clang-format "good enough" minus bug

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1405955 , @riccibruno wrote: > More explicitly something like: > > in `Sanitizer.h`: > > template struct SanitizerMasks { > static const SanitizerMask SomeMask; > /* and so on for each mask*/ > }; > > t

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

peter.smith added a comment. Thanks for the update. To summarise I'd like to keep the integrated and non-integrated assembler in synch for Linux like Android, even at the risk of adding an fpu when it isn't needed. I think that given how difficult it is to not use NEON, I think the mfloat-abi=s

[PATCH] D58492: [clangd] Add thread priority lowering for MacOS as well

gribozavr added a comment. macOS supports `pthread_setschedparam()` that we call on Linux, why not reuse the same code path? https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man3/pthread_setschedparam.3.html Repository: rCTE Clang Tools Extra CHA

[PATCH] D58518: [HIP] change kernel stub name

yaxunl created this revision. yaxunl added reviewers: t-tye, tra. Add .stub to kernel stub function name so that it is different from kernel name in device code. This is necessary to let debugger find correct symbol for kernel https://reviews.llvm.org/D58518 Files: lib/CodeGen/CGCUDANV.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added a subscriber: bevinh. leonardchan added a comment. Herald added a subscriber: jdoerfert. *ping* @bevinh @rjmccall @bjope Any other comments on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay added a comment. Note to self...Underdevelopment: - adding support for => (JSBigArrow) for C# Lambas - adding support for $"liternal {string} with arguments" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58404/new/ https://reviews.llvm.org/D58404 _

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

probinson added inline comments. Comment at: include/clang/AST/Decl.h:1482 + bool getIsArgumentModified() const { +return IsArgumentModified; There should be a comment here. The style in this class appears to omit the 'get' word from the name of the gette

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187821. tmroeder marked an inline comment as done. tmroeder added a comment. Changed the CondIsTrue RHS as suggested. Left the `auto` based on the conclusion of the discussion. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187823. tmroeder added a comment. Fix a mistake in the comment. CondIsTrue only matters if the value *is* condition dependent, not *is not* condition dependent. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ http

[PATCH] D58186: Sync some doc changes ClangFormatStyleOptions.rst with doc comments in `Format.h`

rdwampler added a comment. In D58186#1405687 , @sylvestre.ledru wrote: > Do you have permissions on the repo? No, I would need someone to commit this for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) aaron.ballman wrote: > a_sidorin wrote: > > aaron.ballman wrote: > > > `bool CondIsTrue = E->isCondi

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 187827. tmroeder marked an inline comment as done. tmroeder added a comment. Reverted to the original semantics of CondIsTrue Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58292/new/ https://reviews.llvm.org/D58292 Files:

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

vsk added reviewers: bricci, rsmith. vsk added a comment. + rsmith, + bricci for review. I was under the impression that space inside VarDecl was quite constrained. Pardon the likely naive question, but: is there any way to make the representation more compact (maybe sneak a bit into ParmVarDec

[PATCH] D58518: [HIP] change kernel stub name

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. My guess is that this is needed because HIP debugger can see symbols from both host and device executables at the same time. Is that so? If that's the case, I guess HIP may have similar naming probl

[PATCH] D58292: Add support for importing ChooseExpr AST nodes.

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:6160 + // condition-dependent. + bool CondIsTrue = false; + if (!E->isConditionDependent()) tmroeder wrote: > aaron.ballman wrote: > > a_sidorin wrote: > > > aaron.ballman wrote: > > > >

r354608 - [test] Fix typo: 's/ ot / to /' [NFC]

Author: mgrang Date: Thu Feb 21 11:11:15 2019 New Revision: 354608 URL: http://llvm.org/viewvc/llvm-project?rev=354608&view=rev Log: [test] Fix typo: 's/ ot / to /' [NFC] Modified: cfe/trunk/test/CodeGenCXX/cxx11-special-members.cpp Modified: cfe/trunk/test/CodeGenCXX/cxx11-special-members.c

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: docs/ReleaseNotes.rst:228 -OpenCL C Language Changes in Clang +OpenCL Language Changes in Clang -- AlexeySotkin wrote: > AlexeySotkin wrote

[PATCH] D58518: [HIP] change kernel stub name

yaxunl marked an inline comment as done. yaxunl added a comment. In D58518#1406124 , @tra wrote: > My guess is that this is needed because HIP debugger can see symbols from > both host and device executables at the same time. Is that so? > > If that's the

[PATCH] D58509: [CodeGen] Fix string literal address space casting.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58509/new/ https://reviews.llvm.org/D58509 __

[PATCH] D58523: [OpenMP 5.0] Parsing/sema support for to and from clauses with mapper modifier

lildmh created this revision. lildmh added reviewers: ABataev, hfinkel, Meinersbur, kkwli0. lildmh added a project: OpenMP. Herald added subscribers: cfe-commits, jdoerfert, guansong. Herald added a project: clang. This patch implements the parsing and sema support for OpenMP to and from clauses

[PATCH] D58518: [HIP] change kernel stub name

t-tye added a comment. Yes this relates to supporting the debugger. For the same function being present on both host and device, having the same name is correct as the debugger must set a breakpoint at both places. This is similar to needing to set a breakpoint at every place a function is inli

r354610 - [CodeGen] Fix string literal address space casting.

Author: hliao Date: Thu Feb 21 11:40:20 2019 New Revision: 354610 URL: http://llvm.org/viewvc/llvm-project?rev=354610&view=rev Log: [CodeGen] Fix string literal address space casting. Summary: - If a string literal is reused directly, need to add necessary address space casting if the target re

[PATCH] D58509: [CodeGen] Fix string literal address space casting.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354610: [CodeGen] Fix string literal address space casting. (authored by hliao, committed by ). Herald added a subscriber: ebevhan. Changed prior to commit: https://reviews.llvm.org/D58509?vs=187797&id=

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl updated this revision to Diff 187832. yaxunl added a comment. I would like to fix the validation issue only and leave the overload resolution issue for future. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56411/new/ https://reviews.llvm.org/D56411 Files: lib/Sema/SemaCUDA.cp

  1   2   3   >