ilya-biryukov added a reviewer: hokein.
ilya-biryukov accepted this revision.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

Haojian is the author, so adding him as a reviewer. LGTM from my side



================
Comment at: unittests/clangd/XRefsTests.cpp:416
+        void foo() {
+          auto x = m^akeX();
+        }
----------------
Does that mean we're not showing constructor results in:
```
X foo^(something);
```


It's the only thing that I would miss. OTOH, I also think it should be attached 
to the parentheses and it's not the case now.

Anyhow, not a huge deal.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58495/new/

https://reviews.llvm.org/D58495



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to