hokein accepted this revision. hokein added inline comments.
================ Comment at: unittests/clangd/XRefsTests.cpp:462 Foo a = $1^str; - Foo b = Foo($2^str); + Foo b = F$9^oo($2^str); Foo c = $3^f(); ---------------- nit: keep the number in sort. ================ Comment at: unittests/clangd/XRefsTests.cpp:482 + EXPECT_THAT(locateSymbolAt(AST, T.point("9")), + // First one is calss definition, second is the constructor. + ElementsAre(Sym("Foo"), Sym("Foo"))); ---------------- s/calss/class Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58495/new/ https://reviews.llvm.org/D58495 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits