[PATCH] D56429: fix python3 compability issue

roxma created this revision. roxma added reviewers: ilya-biryukov, mgorny. Herald added subscribers: cfe-commits, arphaman. Herald added a reviewer: serge-sans-paille. The file contents could be of str type. Should use byte length instead of str length, otherwise utf-8 encoded files may not get pr

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

jlebar added a comment. Without reading the patch in detail (sorry) but looking mainly at the testcase: It looks like we're not checking how overloading and `__host__ __device__` functions play into this. Maybe there are some additional edge-cases to explore/check. Just some examples: Will w

[PATCH] D56429: fix python3 compability issue

serge-sans-paille added inline comments. Comment at: bindings/python/clang/cindex.py:2998 +for i,(name,contents) in enumerate(unsaved_files): +if hasattr(contents, "read"): +contents = contents.read() Why did you re

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

hokein added a comment. Thanks, mostly good to me. just a few nits. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:72 +TestName.consume_front(kDisabledTestPrefix); +if (TestName.find('_') != std::string::npos) { + Check->diag(TestNameToken->

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180625. MyDeveloperDay added a comment. Sorry to add another revision but, rerunning no-discard checker on LLVM code base threw up other [[nodiscard]] placements which whilst they MAY be correct, I don't think we should handle in this first pass. - c

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire updated this revision to Diff 180626. steveire added a comment. Run clang-format Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56415/new/ https://reviews.llvm.org/D56415 Files: clang-query/QueryParser.cpp clang-query/QueryParser.h Ind

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire marked an inline comment as done. steveire added a comment. Thanks, I ran clang-format, and I'd rather let it be the rulemaker, rather than try to add newlines in the lambdas :). Comment at: clang-query/QueryParser.cpp:36 + if (Line.front() == '#') { +Line = {};

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. Hey Aleksei! Thank you for the input! ODR violations being warnings would be beneficial from the code maintenance point of view, as we would not have to resort to duplicate some (if not most) of them as errors. There is also a flexibility advantage in the diagnostics,

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

gamesh411 added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55646/new/ https://reviews.llvm.org/D55646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:1 +//===--- AvoidUnderscoreInGoogletestNameCheck.cpp - clang-tidy-===// +// nit: space after tidy and before --- Comment a

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + nit: is there a reason here why you say C++14 when the code checks for C++11?

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 2 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + MyDeveloperDay wrote: > nit

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo created this revision. smateo added a reviewer: ABataev. smateo added a project: OpenMP. Herald added a subscriber: cfe-commits. There is a minor issue in how the implicit data-sharings for nested tasks are computed. For the following example: int x; #pragma omp task shared(x) #pra

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:543 + + if (!(S.Flags & Symbol::IndexedForCodeCompletion)) +return Insert(S); ilya-biryukov wrote: > Most of the fields updated at the bottom

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

smateo updated this revision to Diff 180631. smateo added a comment. Adding more context Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56430/new/ https://reviews.llvm.org/D56430 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/task_messages.cpp Index: test/OpenM

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:1 +// RUN: %check_clang_tidy %s modernize-use-trailing-return %t -- -- --std=c++14 + bernhardmgruber wrote: > MyDeveloperDay wrote: > > nit: is there a reason here

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; bernhardmgruber wrote: > JonasT

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous updated this revision to Diff 180640. jkorous retitled this revision from "[clangd][WIP] XPC transport layer, framework, test-client" to "[clangd] XPC transport layer, framework, test-client". jkorous edited the summary of this revision. jkorous added a comment. added one more assert R

r350619 - [X86] Add shift-by-immediate tests for non-immediate/out-of-range values

Author: rksimon Date: Tue Jan 8 04:59:15 2019 New Revision: 350619 URL: http://llvm.org/viewvc/llvm-project?rev=350619&view=rev Log: [X86] Add shift-by-immediate tests for non-immediate/out-of-range values As noted on PR40203, for gcc compatibility we need to support non-immediate values in the

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

riccibruno marked an inline comment as done. riccibruno added a comment. I have no more remark, but since I am just a new contributor to clang I am sure people will have more to say about this patch. Thanks ! Comment at: lib/AST/Expr.cpp:2091 +

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350622: [Sema] Diagnose array access preceding the array bounds even when the base type… (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https:

r350622 - [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

Author: brunoricci Date: Tue Jan 8 05:52:54 2019 New Revision: 350622 URL: http://llvm.org/viewvc/llvm-project?rev=350622&view=rev Log: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete. When the type of the base expression after IgnoreParenCasts is i

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:45 +std::string(Message) + +" (no FixIt provided, function argument list end is inside macro)"); +return {}; MyDeveloperDay wrote: > bernhar

[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

erichkeane updated this revision to Diff 180650. erichkeane marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56391/new/ https://reviews.llvm.org/D56391 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/microsoft-no-common-align.c Index: test/CodeGen/m

[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM, thanks Erich. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56391/new/ https://reviews.llvm.org/D56391 ___ cfe-commits mailing l

r350625 - [AST] Pack CXXDependentScopeMemberExpr

Author: brunoricci Date: Tue Jan 8 06:17:00 2019 New Revision: 350625 URL: http://llvm.org/viewvc/llvm-project?rev=350625&view=rev Log: [AST] Pack CXXDependentScopeMemberExpr Use the newly available space in the bit-fields of Stmt. Additionally store FirstQualifierFoundInScope as a trailing obje

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC350625: [AST] Pack CXXDependentScopeMemberExpr (authored by brunoricci, committed by ). Changed prior to commit: https://reviews.llvm.org/D56367?vs=180407&id=180651#toc Repository: rC Clang CHANGES

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNonVirtualDtor : DiagGroup<"delete-non-virtual-dtor">; +def DeleteAbstractNonVirtualDtor : DiagGroup<"delete-abstract-non-virtual-dtor", +

[PATCH] D56430: Incorrect implicit data-sharing for nested tasks

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:680 + +bool isParallelRegion(OpenMPDirectiveKind DKind) { + return isOpenMPParallelDirective(DKind) || isOpenMPTeamsDirective(DKind); Better to rename it to `isImplicitTaskingRegion` Repository

[PATCH] D56438: [Modules] Allow modulemap path change for implicitly built modules

yamaguchi created this revision. yamaguchi added reviewers: rsmith, dblaikie. Previous code was comparing the location of "modulemap which is currently loaded and gives a definition of current module" and "the location of the modulemap where the current implicit module was built". This check was

r350627 - [AST][NFC] Pack CXXNoexceptExpr and SubstNonTypeTemplateParmExpr

Author: brunoricci Date: Tue Jan 8 06:44:34 2019 New Revision: 350627 URL: http://llvm.org/viewvc/llvm-project?rev=350627&view=rev Log: [AST][NFC] Pack CXXNoexceptExpr and SubstNonTypeTemplateParmExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per CXXNoexcept

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

r.stahl created this revision. r.stahl added reviewers: NoQ, xazax.hun, martong, a.sidorin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, rnkovacs, szepet, baloghadamsoftware, whisperity, mgorny. Herald added a reviewer: george.karpenkov. Herald added a rev

[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. Unfortunately, yaml::Input::setCurrentDocument() and yaml::Input::nextDocument() are internal APIs, the way we use them may cause a nullptr accessing when

[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this. A few questions for the long-term: - Should we consider removing the YAML support altogether? - If we want to keep, are there non-private APIs that

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think this is a good approach to solving the problem, so let's go this route. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56407/new/ https://

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Some nits inline. Otherwise looks good to me. Comment at: include/clang/CrossTU/CrossTranslationUnit.h:32 class FunctionDecl; +class VarDecl; class NamedDecl; ---

[PATCH] D56407: Implement the TreeStructure interface through the TextNodeDumper

erichkeane added a comment. In D56407#1349672 , @aaron.ballman wrote: > I think this is a good approach to solving the problem, so let's go this > route. Yeah, I agree here. This ends up being a really clean solution. Repository: rC Clang CHANGES

[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

hokein added a comment. In D56442#1349666 , @ilya-biryukov wrote: > LGTM. Thanks for fixing this. > > A few questions for the long-term: > > - Should we consider removing the YAML support altogether? The motivation of the YAML is for debugging purpose (

[clang-tools-extra] r350633 - [clangd] Fix a crash when reading an empty index file.

Author: hokein Date: Tue Jan 8 07:24:47 2019 New Revision: 350633 URL: http://llvm.org/viewvc/llvm-project?rev=350633&view=rev Log: [clangd] Fix a crash when reading an empty index file. Summary: Unfortunately, yaml::Input::setCurrentDocument() and yaml::Input::nextDocument() are internal APIs,

[PATCH] D56442: [clangd] Fix a crash when reading an empty index file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350633: [clangd] Fix a crash when reading an empty index file. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://revi

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

JonasToth added a comment. No problem, thats why we test on real projects first, because there is always something hidden in C++ :) Is there a test for the lambdas? Comment at: clang-tidy/modernize/UseNodiscardCheck.cpp:39 +AST_MATCHER(CXXMethodDecl, isConversionDecl) { + //

[PATCH] D56314: [clangd] Don't store completion info if the symbol is not used for code completion.

ilya-biryukov added inline comments. Comment at: clangd/index/SymbolCollector.cpp:543 + + if (!(S.Flags & Symbol::IndexedForCodeCompletion)) +return Insert(S); hokein wrote: > ilya-biryukov wrote: > > Most of the fields updated at the bottom aren't useful. H

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

JonasToth added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:23 + +constexpr char kDisabledTestPrefix[] = "DISABLED_"; + Please use `llvm::StringLiteral` Comment at: clang-tidy/google/AvoidUnderscoreIn

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

r.stahl added a comment. Thanks for the quick response! Will wait a couple days to see if someone else has something to add. But I think something is wrong here... When trying to "arc diff" I got the following error: Exception Command failed with error #1! COMMAND svn propget 'svn:mi

[PATCH] D56441: [analyzer][CrossTU][NFC] Generalize to external definitions instead of external functions

martong accepted this revision. martong added a comment. Looks good to me (but xazax's comments are valid)! Thank you. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56441/new/ https://reviews.llvm.org/D56441 ___ cfe-

r350634 - [OPENMP]Fix PR40191: Do not allow orphaned cancellation constructs.

Author: abataev Date: Tue Jan 8 07:53:42 2019 New Revision: 350634 URL: http://llvm.org/viewvc/llvm-project?rev=350634&view=rev Log: [OPENMP]Fix PR40191: Do not allow orphaned cancellation constructs. Prohibited use of the orphaned cancellation directives. Modified: cfe/trunk/lib/Sema/SemaO

[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default

martong added a comment. Just a quick note. We are pretty sure that `StructuralEquivalency` can have false positive results, i.e. it can report two decls as nonequivalent falsely. My understanding is that we should report an error only if we are absolutely certain that an error has happened, th

Re: r350634 - [OPENMP]Fix PR40191: Do not allow orphaned cancellation constructs.

Thanks! On Tue, Jan 8, 2019 at 6:57 PM Alexey Bataev via cfe-commits wrote: > > Author: abataev > Date: Tue Jan 8 07:53:42 2019 > New Revision: 350634 > > URL: http://llvm.org/viewvc/llvm-project?rev=350634&view=rev > Log: > [OPENMP]Fix PR40191: Do not allow orphaned cancellation constructs. > >

[PATCH] D56415: NFC: Port QueryParser to StringRef

aaron.ballman added inline comments. Comment at: clang-query/QueryParser.cpp:36 + if (Line.front() == '#') { +Line = {}; return StringRef(); steveire wrote: > kristina wrote: > > I don't think this is the best way of handling it, in fact I'm pretty > >

Re: r346652 - Make clang-based tools find libc++ on MacOS

It looks like clang now looks for libc++ headers in -internal-isystem Release+Asserts/bin/include/c++/v1 , compared to -internal-isystem Release+Asserts/include/c++/v1. `make install` puts the libc++ headers in Release+Asserts/include, the old location. Was this an intentional change? As-is, this

r350635 - [AST][NFC] Pack CXXScalarValueInitExpr

Author: brunoricci Date: Tue Jan 8 08:08:54 2019 New Revision: 350635 URL: http://llvm.org/viewvc/llvm-project?rev=350635&view=rev Log: [AST][NFC] Pack CXXScalarValueInitExpr Use the newly available space in the bit-fields of Stmt. This saves one pointer per CXXScalarValueInitExpr. NFC. Modifi

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for the lambdas? test/clang-tidy/modernize-use-nodis

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

aaron.ballman added inline comments. Comment at: include/clang/AST/TextNodeDumper.h:28 const comments::FullComment *> { + TextTreeStructure &TreeStructure; raw_ostream &OS; steveire wrote: > steveire wrote: > > stev

r350636 - Don't emit DW_AT_enum_class unless it's actually an 'enum class'.

Author: probinson Date: Tue Jan 8 08:28:11 2019 New Revision: 350636 URL: http://llvm.org/viewvc/llvm-project?rev=350636&view=rev Log: Don't emit DW_AT_enum_class unless it's actually an 'enum class'. Finishes off the functional part of PR36168. Differential Revision: https://reviews.llvm.org/D

[PATCH] D56393: [DebugInfo] Don't emit DW_AT_enum_class unless it's actually an 'enum class'.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC350636: Don't emit DW_AT_enum_class unless it's actually an 'enum class'. (authored by probinson, committed by ). Changed

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:33 + if (Line.empty()) +return StringRef(Line.begin(), 0); aaron.ballman wrote: > Why not just return `Line`? It is the pre-existing behavior

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for t

[PATCH] D56415: NFC: Port QueryParser to StringRef

aaron.ballman added inline comments. Comment at: clang-query/QueryParser.cpp:33 + if (Line.empty()) +return StringRef(Line.begin(), 0); steveire wrote: > aaron.ballman wrote: > > Why not just return `Line`? > It is the pre-existing behavior to return a zer

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:33 + if (Line.empty()) +return StringRef(Line.begin(), 0); aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > Why not just

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5520 +ExprResult Acc = + SemaRef.ActOnIntegerConstant(SourceLocation(), 0).get(); +for (unsigned int Cnt = 0; Cnt < NestedLoopCount; Cnt++) { No need for `.get()` here =

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:33 + if (Line.empty()) +return StringRef(Line.begin(), 0); steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > > aaron.ballman wro

[PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

sammccall created this revision. sammccall added reviewers: aaron.ballman, JonasToth. Herald added a subscriber: cfe-commits. This fixes ASTContext's parent map for nodes in such classes (e.g. operator()). https://bugs.llvm.org/show_bug.cgi?id=39949 In order to do this, we remove the TraverseLamb

[PATCH] D56415: NFC: Port QueryParser to StringRef

steveire marked an inline comment as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:37 +Line = {}; return StringRef(); } aaron.ballman wrote: > steveire wrote: > > aaron.ballman wrote: > > > Why not just return `Line` he

[PATCH] D56415: NFC: Port QueryParser to StringRef

aaron.ballman added inline comments. Comment at: clang-query/QueryParser.cpp:33 + if (Line.empty()) +return StringRef(Line.begin(), 0); steveire wrote: > steveire wrote: > > aaron.ballman wrote: > > > steveire wrote: > > > > aaron.ballman wrote: > > > > >

r350638 - Fix use-after-free bug in Tooling.

Author: alexfh Date: Tue Jan 8 08:55:13 2019 New Revision: 350638 URL: http://llvm.org/viewvc/llvm-project?rev=350638&view=rev Log: Fix use-after-free bug in Tooling. Summary: `buildASTFromCodeWithArgs()` was creating a memory buffer referencing a stack-allocated string. This diff changes the i

[PATCH] D55765: Fix use-after-free bug in Tooling.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350638: Fix use-after-free bug in Tooling. (authored by alexfh, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55765/

r350639 - Revert "Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor"

Author: epilk Date: Tue Jan 8 09:04:38 2019 New Revision: 350639 URL: http://llvm.org/viewvc/llvm-project?rev=350639&view=rev Log: Revert "Split -Wdelete-non-virtual-dtor into -Wdelete-abstract-non-virtual-dtor" This reverts commit r350585. There was some late post-commit review on phab. Remove

[PATCH] D56415: NFC: Port QueryParser to StringRef

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the nits pointed out; you can fix and commit without another round of review. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

ilya-biryukov added a comment. Most comments are NITs, the major one that I'd suggest paying most attention to is about rewriting newer results with an older ones. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. T

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

erik.pilkington reopened this revision. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. This revision is now accepted and ready to land. I reverted my commit in r350639. Comment at: include/clang/Basic/DiagnosticGroups.td:108-109 def DeleteNo

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay updated this revision to Diff 180687. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. Address review comments - add more lambda tests - add nested lambda test - remove hasParent() call, (seems isConversionOperator()) seems to detect the CXXMethods

[PATCH] D56445: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

ldionne created this revision. ldionne added a reviewer: ahatanak. Herald added subscribers: cfe-commits, dexonsmith, jkorous, christof. r306722 added diagnostics when aligned allocation is used with deployment targets that do not support it, but the first macosx supporting aligned allocation was

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

mgorny added a comment. Ping. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56062/new/ https://reviews.llvm.org/D56062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

mgorny added a comment. Ping again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r350641 - Rename DIFlagFixedEnum to DIFlagEnumClass. NFC

Author: probinson Date: Tue Jan 8 09:52:29 2019 New Revision: 350641 URL: http://llvm.org/viewvc/llvm-project?rev=350641&view=rev Log: Rename DIFlagFixedEnum to DIFlagEnumClass. NFC Modified: cfe/trunk/test/CodeGen/debug-info-enum.cpp cfe/trunk/test/CodeGenCXX/debug-info-enum-class.cpp

[PATCH] D56405: Split -Wdelete-non-virtual-dtor into two groups

erik.pilkington updated this revision to Diff 180690. erik.pilkington added a comment. This revision is now accepted and ready to land. Split -Wdelete-non-virtual-dtor into -Wdelete-non-abstract-non-virtual-dtor and -Wdelete-abstract-non-virtual-dtor. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

ilya-biryukov created this revision. ilya-biryukov added reviewers: arphaman, thakis. Herald added a reviewer: EricWF. Herald added a subscriber: christof. By using '..' instead of fs::parent_path. The intention of the code was to go from 'path/to/clang/bin' to 'path/to/clang/include'. In most ca

Re: r346652 - Make clang-based tools find libc++ on MacOS

Hi Nico, This is clearly a bug, it's supposed to search in a sibling directory. Are you running clang as './clang' in the scripts? The code seems to break in that case, https://reviews.llvm.org/D56446 should fix this. On Tue, Jan 8, 2019 at 5:12 PM Nico Weber wrote: > It looks like clang now l

r350642 - __has_feature(pragma_clang_attribute_namespaces) should be __has_extension

Author: epilk Date: Tue Jan 8 10:24:39 2019 New Revision: 350642 URL: http://llvm.org/viewvc/llvm-project?rev=350642&view=rev Log: __has_feature(pragma_clang_attribute_namespaces) should be __has_extension Thanks to Richard Smith for pointing this out. Modified: cfe/trunk/docs/LanguageExten

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. In D55433#1349709 , @JonasToth wrote: > No problem, thats why we test on real projects first, because there is always > something hidden in C++ :) > > Is there a test for the lambdas? test/clang-tidy/modernize-use-nodis

Re: r350572 - Add a __has_feature check for namespaces on #pragma clang attribute.

On 1/7/19 4:43 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 16:12, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: On 1/7/19 3:51 PM, Richard Smith wrote: On Mon, 7 Jan 2019 at 13:57, Erik Pilkington via cfe-commits mailto:cfe-commits@lists.llvm.org>>

[PATCH] D55337: NFC: Move dumpDeclRef to NodeDumper

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Once D56407 lands, the rebased changes here LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55337/new/ http

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:46 +auto IdentifierInfo = MacroNameToken.getIdentifierInfo(); +if (!IdentifierInfo) { + return; Please elide braces. Repository: rCTE Cla

[PATCH] D56446: [Driver] Fix libcxx detection on Darwin with clang run as ./clang

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. That makes sense, LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56446/new/ https://reviews.llvm.org/D56446 ___

Re: r346652 - Make clang-based tools find libc++ on MacOS

That looks like it should help. Thanks for the quick fix! On Tue, Jan 8, 2019 at 1:11 PM Ilya Biryukov wrote: > Hi Nico, > > This is clearly a bug, it's supposed to search in a sibling directory. > Are you running clang as './clang' in the scripts? The code seems to > break in that case, https:

[PATCH] D56424: [clang-tidy] Add check for underscores in googletest names.

MyDeveloperDay added inline comments. Comment at: clang-tidy/google/AvoidUnderscoreInGoogletestNameCheck.cpp:27 +static bool isGoogletestTestMacro(StringRef MacroName) { + static const llvm::StringSet<> MacroNames = {"TEST", "TEST_F", "TEST_P", +

[PATCH] D56391: Limit COFF 'common' emission to <=32 alignment types.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350643: Limit COFF 'common' emission to <=32 alignment types. (authored by erichkeane, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56391/new/ https://rev

r350644 - [NFC] Don't over-eagerly check block alignment

Author: jfb Date: Tue Jan 8 10:51:38 2019 New Revision: 350644 URL: http://llvm.org/viewvc/llvm-project?rev=350644&view=rev Log: [NFC] Don't over-eagerly check block alignment Alignment of __block isn't relevant to this test, remove its checking. Modified: cfe/trunk/test/CodeGenCXX/trivial-

r350643 - Limit COFF 'common' emission to <=32 alignment types.

Author: erichkeane Date: Tue Jan 8 10:44:22 2019 New Revision: 350643 URL: http://llvm.org/viewvc/llvm-project?rev=350643&view=rev Log: Limit COFF 'common' emission to <=32 alignment types. As reported in PR33035, LLVM crashes if given a common object with an alignment of greater than 32 bits. T

r350645 - Fix opencl test broken on windows by r350643.

Author: erichkeane Date: Tue Jan 8 11:10:43 2019 New Revision: 350645 URL: http://llvm.org/viewvc/llvm-project?rev=350645&view=rev Log: Fix opencl test broken on windows by r350643. Windows doesn't allow common with alignment >32 bits, so these tests were broken in windows mode. This patch make

[PATCH] D56445: [Sema] Teach Clang that aligned allocation is not supported with macosx10.13

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM. We should probably check that alignedAllocMinVersion returns the correct versions for other OSes too, but this patch is fine. Repository: rC Clang CHANGES SINCE LAST ACTION ht

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet updated this revision to Diff 180706. kadircet marked 23 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55224/new/ https://reviews.llvm.org/D55224 Files: clangd/SourceCod

[PATCH] D55224: [clangd] Introduce loading of shards within auto-index

kadircet added inline comments. Comment at: clangd/index/Background.cpp:259 + // if this thread sees the older version but finishes later. This should + // be rare in practice. + DigestIt.first->second = Hash; ilya-biryukov wrote: > kadircet wrote:

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180709. gtbercea added a comment. Invert accumulation direction. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: docs/OpenMPSupport.rst include/clang/Basic/LangOptions.d

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 180710. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. Update encoding, rebase to HEAD Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D55483 Files: include/clang

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180711. gtbercea added a comment. Fix update. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_codegen.cpp test/OpenMP/for_simd_co

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:5523 SourceLocation UpdLoc = IS.IncSrcRange.getBegin(); - // Build: Iter = (IV / Div) % IS.NumIters - // where Div is product of previous iterations' IS.NumIters. - ExprResult Iter; - if

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

gtbercea updated this revision to Diff 180713. gtbercea added a comment. Remove redundant initalization. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/for_codegen.cpp tes

[PATCH] D56413: [OpenMP] Avoid remainder operations for loop index values on a collapsed loop nest.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56413/new/ https://reviews.llvm.org/D56413 ___ cfe-commits ma

  1   2   >