xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land.
Some nits inline. Otherwise looks good to me. ================ Comment at: include/clang/CrossTU/CrossTranslationUnit.h:32 class FunctionDecl; +class VarDecl; class NamedDecl; ---------------- Unrelated change? ================ Comment at: include/clang/CrossTU/CrossTranslationUnit.h:106 - /// This function loads a function definition from an external AST - /// file and merge it into the original AST. + /// This function loads a function or variable definition from an + /// external AST file and merges it into the original AST. ---------------- These comment changes might better be in the next patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56441/new/ https://reviews.llvm.org/D56441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits