riccibruno marked an inline comment as done. riccibruno added a comment. I have no more remark, but since I am just a new contributor to clang I am sure people will have more to say about this patch. Thanks !
================ Comment at: lib/AST/Expr.cpp:2091 + : PLoc.getColumn(); + return APValue(IntVal); + } ---------------- > What's your objection here? That I used int64_t or getIntWidth()? I've > reworked this bit of > code. Let me know if it's still problematic. It was just a very small remark saying that you were doing unsigned -> signed -> unsigned for no apparent reason. Anyway the current way looks fine to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37035/new/ https://reviews.llvm.org/D37035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
