[clang-tools-extra] r346638 - [clangd] Fix compile on very old glibc

Author: sammccall Date: Mon Nov 12 00:17:49 2018 New Revision: 346638 URL: http://llvm.org/viewvc/llvm-project?rev=346638&view=rev Log: [clangd] Fix compile on very old glibc Modified: clang-tools-extra/trunk/clangd/Threading.cpp Modified: clang-tools-extra/trunk/clangd/Threading.cpp URL: h

r346639 - clang-cl: Add documentation for /Zc:dllexportInlines-

Author: hans Date: Mon Nov 12 00:38:10 2018 New Revision: 346639 URL: http://llvm.org/viewvc/llvm-project?rev=346639&view=rev Log: clang-cl: Add documentation for /Zc:dllexportInlines- Differential revision: https://reviews.llvm.org/D54319 Modified: cfe/trunk/docs/UsersManual.rst cfe/tru

[PATCH] D54319: clang-cl: Add documentation for /Zc:dllexportInlines-

This revision was automatically updated to reflect the committed changes. Closed by commit rL346639: clang-cl: Add documentation for /Zc:dllexportInlines- (authored by hans, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54319?vs=1733

r346640 - Release notes: Mention clang-cl's /Zc:dllexportInlines- flag

Author: hans Date: Mon Nov 12 00:42:21 2018 New Revision: 346640 URL: http://llvm.org/viewvc/llvm-project?rev=346640&view=rev Log: Release notes: Mention clang-cl's /Zc:dllexportInlines- flag Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llv

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 173622. calixte added a comment. Update ReleaseNotes Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/Back

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 173623. calixte added a comment. Forgot the ellipsis in the release notes. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/ReleaseNotes.rst docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOption

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

richardmembarth added a comment. There are external tools (e.g. hipacc ) that generate Clang AST. This AST uses `LangAS` annotations and emits incorrect memory space specifiers for CUDA when pretty-printed. Repository: rC Clang https://reviews.llvm.org/D54258 ___

r346642 - [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

Author: calixte Date: Mon Nov 12 01:12:27 2018 New Revision: 346642 URL: http://llvm.org/viewvc/llvm-project?rev=346642&view=rev Log: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov Summary: These options are taking regex separat

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

This revision was automatically updated to reflect the committed changes. Closed by commit rC346642: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to… (authored by calixte, committed by ). Changed prior to commit: https://reviews.llvm.org/D52034?vs=173623&id=173627#toc

[PATCH] D54269: Introduce shard storage to auto-index.

sammccall added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. nit: i'd suggest doing the writes *after* updating the index, as the latter is user-fa

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. In https://reviews.llvm.org/D52273#1294767, @malaperle wrote: > What is the goal for doing this without the AST? Is the goal to not have to > keep the AST and save memory? We don't have AST for index completions. Repository: rCTE Clang Tools Extra https://re

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/clang++ -stdlib=libc++ -target x86_64-apple-darwin -

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:13 +// RUN: cp "%s" "%t/test.cpp" +// RUN: clang-tidy "%t/test.cpp" + This should check a diagnostic rather than rely on the error code, I think Repository: rCTE Clang Tool

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173630. ilya-biryukov added a comment. - Updated the test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector test/clang-tidy/clang-tidy-mac-libcxx.cpp Index:

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/c

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t",

[PATCH] D54416: [GCOV] fix test after patch rL346642

calixte created this revision. calixte added a reviewer: marco-c. Herald added a subscriber: cfe-commits. Test is failing under windows, so fix it Repository: rC Clang https://reviews.llvm.org/D54416 Files: test/CodeGen/code-coverage-filter.c Index: test/CodeGen/code-coverage-filter.c ==

r346644 - [GCOV] fix test after patch rL346642

Author: calixte Date: Mon Nov 12 01:52:14 2018 New Revision: 346644 URL: http://llvm.org/viewvc/llvm-project?rev=346644&view=rev Log: [GCOV] fix test after patch rL346642 Summary: Test is failing under windows, so fix it. Should fix: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/c

[PATCH] D54416: [GCOV] fix test after patch rL346642

This revision was automatically updated to reflect the committed changes. Closed by commit rL346644: [GCOV] fix test after patch rL346642 (authored by calixte, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54416 Files: cfe/trunk/test/

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

Hmm, maybe I misunderstood your initial request for this. The current implementation does what the warnings says: If the compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored. This suggests to the user that it's a bad idea, but they can go ahead if they want to. It sounds like you'

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet updated this revision to Diff 173633. gchatelet marked 2 inline comments as done. gchatelet added a comment. - Address comments + fix hex values display Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguidelines/NarrowingConversionsChec

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

alexfh added inline comments. Comment at: unittests/clang-tidy/AddConstTest.cpp:733 + StringRef T = "template void f(T v) \n"; + StringRef S = "{ T target = v; }"; + auto Cat = [&T](StringRef S) { return (T + S).str(); }; It would be interesting to see test c

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173635. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Check for a diagnostic inside the found library Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

gchatelet added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:178 + return; +// Conversions to unsigned integer are well defined and follow modulo 2 +// arithmetic. JonasToth wrote: > gchatelet wrote: > > Jon

[PATCH] D52273: [clangd] Initial implementation of expected types

ioeric added inline comments. Comment at: clangd/ExpectedTypes.cpp:27 +return llvm::None; + auto *VD = llvm::dyn_cast(R.Declaration); + if (!VD) maybe add a comment what `ValueDecl` covers roughly? E.g. functions, classes, variables etc.

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. sammccall wrote: > nit: i'd suggest doing the writes *after* updating the index, as the

[PATCH] D53830: [clang-tidy]: Abseil: new check 'abseil-upgrade-duration-conversions'

alexfh added inline comments. Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:33-36 + anyOf(hasAncestor( +functionTemplateDecl(HasMatchingDependentDescendant)), +hasAncestor( +class

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

On Mon, Nov 12, 2018 at 4:58 AM Hans Wennborg wrote: > Hmm, maybe I misunderstood your initial request for this. > > The current implementation does what the warnings says: If the > compiler falls back to cl.exe, /Zc:dllexportInlines- will be ignored. > This suggests to the user that it's a bad i

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

grimar updated this revision to Diff 173643. grimar retitled this revision from "[Clang] - Add -fdwarf-fission=split,single option." to "[Clang] - Add '-gsplit-dwarf[=split,=single]' version for '-gsplit-dwarf' option.". grimar edited the summary of this revision. grimar added a comment. Thanks,

[PATCH] D54253: [OpenCL][NFC] Improve test coverage of test/Index/opencl-types.cl

AlexeySachkov added a comment. If I understand correctly, not all extensions are available on non-x86 targets and some declarations are marked as `(invalid)` - that is the only difference I saw Repository: rC Clang https://reviews.llvm.org/D54253 _

[clang-tools-extra] r346648 - [clangd] Remember to serialize AnyScope in FuzzyFindRequest json.

Author: ioeric Date: Mon Nov 12 04:24:08 2018 New Revision: 346648 URL: http://llvm.org/viewvc/llvm-project?rev=346648&view=rev Log: [clangd] Remember to serialize AnyScope in FuzzyFindRequest json. Modified: clang-tools-extra/trunk/clangd/index/Index.cpp Modified: clang-tools-extra/trunk/cl

[PATCH] D54326: [AST] Pack CXXThrowExpr, CXXDefaultArgExpr and CXXDefaultInitExpr

riccibruno updated this revision to Diff 173652. Repository: rC Clang https://reviews.llvm.org/D54326 Files: include/clang/AST/ExprCXX.h include/clang/AST/Stmt.h lib/AST/ExprCXX.cpp lib/Serialization/ASTReaderStmt.cpp Index: lib/Serialization/ASTReaderStmt.cpp

[PATCH] D45444: [clang-tidy] implement new check for const-correctness

JonasToth updated this revision to Diff 173653. JonasToth added a comment. - Merge branch 'master' into check_const Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45444 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp

[PATCH] D54269: Introduce shard storage to auto-index.

sammccall added inline comments. Comment at: clangd/index/Background.cpp:252 + +auto Hash = FilesToUpdate.lookup(Path); +// Put shards into storage for subsequent use. kadircet wrote: > sammccall wrote: > > nit: i'd suggest doing the writes *after* updati

[PATCH] D52984: [analyzer] Checker reviewer's checklist

xazax.hun updated this revision to Diff 173654. xazax.hun added a comment. - Use the term `checker` instead of `check`. https://reviews.llvm.org/D52984 Files: www/analyzer/checker_dev_manual.html Index: www/analyzer/checker_dev_manual.html

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

ilya-biryukov updated this revision to Diff 173659. ilya-biryukov added a comment. - Check with a clang-tidy warning instead of a clang error Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 Files: test/clang-tidy/Inputs/mock-libcxx/include/c++/v1/mock_vector test/clang

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov updated this revision to Diff 173660. ilya-biryukov added a comment. - Added a test with a compiler path relative to the working dir Repository: rC Clang https://reviews.llvm.org/D54310 Files: include/clang/Lex/HeaderSearchOptions.h lib/Frontend/CreateInvocationFromCommandL

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

MTC added a comment. I'm totally fine with this patch personally. However I am not familiar with this part, so can't give substantial help :). Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p collect

[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.

hokein updated this revision to Diff 173662. hokein marked 3 inline comments as done. hokein added a comment. Update the patch based on offline discussion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54300 Files: clangd/index/SymbolCollector.cpp clangd/index/SymbolCollec

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen created this revision. sdesmalen added reviewers: ributzka, rjmccall, rnk, aaron.ballman. Herald added subscribers: arphaman, kristof.beyls, javed.absar. This is the Clang patch to complement the following LLVM patches: https://reviews.llvm.org/D51477 https://reviews.llvm.org/D51479

[PATCH] D54300: [clangd] Respect shouldIndexFile when collecting symbols.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:217 +bool shouldIndexFile(const Decl& D, const SymbolCollector::Options &Opts, + llvm::DenseMap *FilesToIndexCache) { ioeric wrote: > nit: this is very easily confuse

r346652 - Make clang-based tools find libc++ on MacOS

Author: ibiryukov Date: Mon Nov 12 05:55:55 2018 New Revision: 346652 URL: http://llvm.org/viewvc/llvm-project?rev=346652&view=rev Log: Make clang-based tools find libc++ on MacOS Summary: When they read compiler args from compile_commands.json. This change allows to run clang-based tools, like c

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

sdesmalen added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1101 case CC_AAPCS: + case CC_AArch64VectorCall: return llvm::dwarf::DW_CC_LLVM_AAPCS; I wasn't really sure whether this requires a corresponding DW_CC_LLVM_AAVPCS record in LLVM,

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

This revision was automatically updated to reflect the committed changes. Closed by commit rL346652: Make clang-based tools find libc++ on MacOS (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54310 Files: cfe/tr

[PATCH] D54311: Add a test checking clang-tidy can find libc++ on Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE346653: Add a test checking clang-tidy can find libc++ on Mac (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D54311?vs=173659&id=173664#toc Repository: rC

[clang-tools-extra] r346653 - Add a test checking clang-tidy can find libc++ on Mac

Author: ibiryukov Date: Mon Nov 12 05:56:09 2018 New Revision: 346653 URL: http://llvm.org/viewvc/llvm-project?rev=346653&view=rev Log: Add a test checking clang-tidy can find libc++ on Mac Reviewers: sammccall, arphaman, EricWF Reviewed By: sammccall Subscribers: christof, cfe-commits Differe

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. I think this commit is fine without tests. The new method remains internal to the file but follow-up commits add public interface and tests. I'll push the commits separately. I'll not be squashing them. Repository: rC Clang https://reviews.llvm.org/D54402 __

[PATCH] D52273: [clangd] Initial implementation of expected types

ilya-biryukov added a comment. @ioeric, thanks for the review round! Answering the most important comments, will shortly send changes to actually address the rest. Comment at: clangd/ExpectedTypes.cpp:40 + +llvm::Optional encodeType(ASTContext &Ctx, QualType T) { + assert(!T.

[PATCH] D54404: Exclude matchers which can have multiple results

steveire added a comment. I acknowledge and share the future-proofing concern. We could possibly use something trait-based instead and put the trait beside the matcher definition in ASTMatchers.h, but that doesn't really solve the problem. It only moves the problem. Repository: rC Clang ht

[PATCH] D54269: Introduce shard storage to auto-index.

kadircet added inline comments. Comment at: clangd/index/Background.h:39 + retrieveShard(llvm::StringRef ShardIdentifier, FileDigest Hash) const = 0; + virtual bool initialize(llvm::StringRef Directory) = 0; +}; sammccall wrote: > kadircet wrote: > > sammccall

Re: r346491 - [clang-cl] Add warning for /Zc:dllexportInlines- when the flag is used with /fallback

Hmm, I see. Then I think /Zc:dllexportInlines- and /fallback should not be used at the same time. https://reviews.llvm.org/D54426 Or will you remove /fallback? 2018年11月12日(月) 19:59 Nico Weber : > > On Mon, Nov 12, 2018 at 4:58 AM Hans Wennborg wrote: >> >> Hmm, maybe I misunderstood your initial

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

hans added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:164 -def warn_drv_non_fallback_argument_clang_cl : Warning< - "option '%0' is ignored when /fallback happens">, - InGroup; +def err_drv_both_fallback_and_dllexport_inlines_cannot_be_use

[PATCH] D54414: [Sema] Make sure we substitute an instantiation-dependent default template parameter

Rakete accepted this revision. Rakete added a comment. This revision is now accepted and ready to land. LGTM, thanks :) Comment at: clang/test/SemaCXX/alias-template.cpp:188 +template > +int sfinae_me() { return 0; } // expected-note{{candidate template ignored: substi

r346659 - Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c is failing under windows

Author: calixte Date: Mon Nov 12 06:57:17 2018 New Revision: 346659 URL: http://llvm.org/viewvc/llvm-project?rev=346659&view=rev Log: Revert rL346644, rL346642: the added test test/CodeGen/code-coverage-filter.c is failing under windows Removed: cfe/trunk/test/CodeGen/Inputs/code-coverage-fi

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

nik added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D41005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

takuto.ikuta updated this revision to Diff 173670. takuto.ikuta added a comment. short diag Repository: rL LLVM https://reviews.llvm.org/D54426 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChains/MSVC.cpp clang/t

[PATCH] D52984: [analyzer] Checker reviewer's checklist

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Let's continue the conversation about coding standards somewhere else. Can you please mark inlines as done? https://reviews.llvm.org/D52984

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

takuto.ikuta marked 2 inline comments as done. takuto.ikuta added a comment. Thank you for review! Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5529 + false)) { + Arg *dllexportInlines = Args.getLastArg(options::OPT__SLASH_Zc_dllexportInlines_); + if

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. Thanks for taking a look! ^-^ Comment at: lib/StaticAnalyzer/Core/CheckerRegistry.cpp:51 -/// Collects the checkers for the supplied \p opt option into \p collected. -static void collectCheckers(const CheckerRegistry::CheckerInfoList &checkers, -

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D54426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. We should allow symbols from any scope in dexp results, othewise `find StringRef` doesn't return any results (llvm::StringRef). Repository: rCTE Clang T

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

ioeric added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:55 FuzzyFindRequest Request; + Request.AnyScope = true; // Remove leading "::" qualifier as FuzzyFind doesn't need leading "::" I don't think you would want AnyScope here. For example

[PATCH] D54428: [clangd] XPC transport layer, framework, test-client

jkorous created this revision. jkorous added reviewers: arphaman, sammccall. Herald added subscribers: cfe-commits, kadircet, dexonsmith, MaskRay, ioeric, ilya-biryukov, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54428 Files: CMakeLists.txt Features.inc.in clan

[PATCH] D54407: Record the matcher type when storing a binding

sbenza added a comment. In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > Adding @sbenza in case he has opinions on this approach. I think it's > reasonable, but I also know that changes to the the AST matcher internals > sometimes have unintended side effects with the various

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein updated this revision to Diff 173676. hokein marked 2 inline comments as done. hokein added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54427 Files: clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/Dexp.cpp =

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

hokein added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:55 FuzzyFindRequest Request; + Request.AnyScope = true; // Remove leading "::" qualifier as FuzzyFind doesn't need leading "::" ioeric wrote: > I don't think you would want AnyScope h

[clang-tools-extra] r346665 - [clang-tidy] new check: bugprone-too-small-loop-variable

Author: jonastoth Date: Mon Nov 12 08:01:39 2018 New Revision: 346665 URL: http://llvm.org/viewvc/llvm-project?rev=346665&view=rev Log: [clang-tidy] new check: bugprone-too-small-loop-variable The new checker searches for those for loops which has a loop variable with a "too small" type which me

[PATCH] D54407: Record the matcher type when storing a binding

steveire added a comment. In https://reviews.llvm.org/D54407#129, @sbenza wrote: > In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > > > Adding @sbenza in case he has opinions on this approach. I think it's > > reasonable, but I also know that changes to the the AST matcher

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

This revision was automatically updated to reflect the committed changes. Closed by commit rL346665: [clang-tidy] new check: bugprone-too-small-loop-variable (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53974 Fi

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

JonasToth added a comment. Committed r346665. Thank you very much for the patch! Repository: rL LLVM https://reviews.llvm.org/D53974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D54429: Creating standard shpinx documentation for Clang Static Analyzer

dkrupp created this revision. dkrupp added reviewers: Szelethus, NoQ, george.karpenkov. dkrupp added a project: clang. Herald added subscribers: cfe-commits, donat.nagy, jfb, arphaman, a.sidorin, rnkovacs, baloghadamsoftware, whisperity. Standard Clang tools (ThreadSanitizer, MemorySanitizer, Dat

[clang-tools-extra] r346666 - [clangd] Allow symbols from AnyScope in dexp.

Author: hokein Date: Mon Nov 12 08:03:59 2018 New Revision: 34 URL: http://llvm.org/viewvc/llvm-project?rev=34&view=rev Log: [clangd] Allow symbols from AnyScope in dexp. Summary: We should allow symbols from any scope in dexp results, othewise `find StringRef` doesn't return any results

[PATCH] D54427: [clangd] Allow symbols from AnyScope in dexp.

This revision was automatically updated to reflect the committed changes. Closed by commit rL34: [clangd] Allow symbols from AnyScope in dexp. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54427 Files: clang-t

[PATCH] D54429: Creating standard shpinx documentation for Clang Static Analyzer

Szelethus added a subscriber: xazax.hun. Szelethus added a comment. I'll read through this as soon as possible, but a HUGE thank you for this. This is what the Static Analyzer desperately needed for years. This will trivialize documenting, so conversations about the inner workings of the analyze

[PATCH] D54429: [analyzer] Creating standard shpinx documentation

dkrupp updated this revision to Diff 173679. dkrupp added a comment. making the diff full context. Repository: rC Clang https://reviews.llvm.org/D54429 Files: docs/ClangStaticAnalyzer.rst docs/analyzer/DesignDiscussions/IPA.rst docs/analyzer/DesignDiscussions/InitializerLists.rst doc

[PATCH] D53488: [clang-tidy] Improving narrowing conversions

JonasToth added a comment. Only a few nits from me. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:30 + WarnOnFloatingPointNarrowingConversion( + Options.get("WarnOnFloatingPointNarrowingConversion", 0)) {} + I would make t

[PATCH] D54430: [clangd] Don't show all refs results if -name is ambiguous in dexp.

hokein created this revision. hokein added a reviewer: ioeric. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54430 Files: clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/Dexp.cpp =

[PATCH] D41005: Reuse preamble even if an unsaved file does not exist

ilya-biryukov added a comment. > Before this change, this was not a problem because OverriddenFiles were keyed > on Status.getUniqueID(). Starting with this change, the key is the file path. I suggest keeping two maps for overridden files: one for existing files (key is UniqueID), another one f

[PATCH] D54429: [analyzer] Creating standard shpinx documentation

xazax.hun added a comment. I do like the idea of moving the Clang Static Analyzer documentation to where the rest of the tools are documented. I believe the original reason the analyzer had a separate homepage is due to it was off by default in clang at the beginning and users downloaded it fro

r346635 - Fix compatibility with z3-4.8.1

Author: jankratochvil Date: Sun Nov 11 22:48:02 2018 New Revision: 346635 URL: http://llvm.org/viewvc/llvm-project?rev=346635&view=rev Log: Fix compatibility with z3-4.8.1 With z3-4.8.1: ../tools/clang/lib/StaticAnalyzer/Core/Z3ConstraintManager.cpp:49:40: error: 'Z3_get_error_msg_ex' was not dec

[PATCH] D54430: [clangd] Don't show all refs results if -name is ambiguous in dexp.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346671: [clangd] Don't show all refs results if -name is ambiguous in dexp. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5

[clang-tools-extra] r346671 - [clangd] Don't show all refs results if -name is ambiguous in dexp.

Author: hokein Date: Mon Nov 12 08:41:15 2018 New Revision: 346671 URL: http://llvm.org/viewvc/llvm-project?rev=346671&view=rev Log: [clangd] Don't show all refs results if -name is ambiguous in dexp. Reviewers: ioeric Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

[PATCH] D54309: [AST] Allow limiting the scope of common AST traversals (getParents, RAV).

ioeric added a subscriber: thakis. ioeric added a comment. The new API and the refactoring look good to me. Just a nit and a question. Comment at: lib/AST/ASTContext.cpp:10292 + if (!Parents) // We always need to run over the whole translation unit, as // hasAncestor

r346675 - Revert "Make clang-based tools find libc++ on MacOS"

Author: jdevlieghere Date: Mon Nov 12 08:59:50 2018 New Revision: 346675 URL: http://llvm.org/viewvc/llvm-project?rev=346675&view=rev Log: Revert "Make clang-based tools find libc++ on MacOS" This breaks the LLDB bots. Removed: cfe/trunk/test/Tooling/Inputs/mock-libcxx/include/c++/v1/mock_ve

[clang-tools-extra] r346676 - [clang-tidy] fix ARM tests, because int and long have same width

Author: jonastoth Date: Mon Nov 12 09:02:05 2018 New Revision: 346676 URL: http://llvm.org/viewvc/llvm-project?rev=346676&view=rev Log: [clang-tidy] fix ARM tests, because int and long have same width Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-too-small-loop-variable.cpp Modi

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

JDevlieghere added a comment. I reverted this because it broke the LLDB bots on GreenDragon: http://green.lab.llvm.org/green/view/LLDB/ Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

dblaikie added inline comments. Comment at: include/clang/AST/Expr.h:1700-1701 bool containsNonAscii() const { -StringRef Str = getString(); -for (unsigned i = 0, e = Str.size(); i != e; ++i) - if (!isASCII(Str[i])) +for (auto c : getString()) + if (!isAS

r346677 - Implement P1094R2 (nested inline namespaces)

Author: erichkeane Date: Mon Nov 12 09:19:48 2018 New Revision: 346677 URL: http://llvm.org/viewvc/llvm-project?rev=346677&view=rev Log: Implement P1094R2 (nested inline namespaces) As approved for the Working Paper in San Diego, support annotating inline namespaces with 'inline'. Change-Id: I51

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

Anastasia updated this revision to Diff 173693. Anastasia marked an inline comment as done. Anastasia added a comment. - Extended assert - Handled AS of ToType https://reviews.llvm.org/D53764 Files: include/clang/Sema/Sema.h lib/AST/Expr.cpp lib/CodeGen/CGExpr.cpp lib/Sema/DeclSpec.cp

[clang-tools-extra] r346678 - Revert "Add a test checking clang-tidy can find libc++ on Mac"

Author: jonastoth Date: Mon Nov 12 09:22:36 2018 New Revision: 346678 URL: http://llvm.org/viewvc/llvm-project?rev=346678&view=rev Log: Revert "Add a test checking clang-tidy can find libc++ on Mac" This reverts commit r346653. Removed: clang-tools-extra/trunk/test/clang-tidy/Inputs/mock-li

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas added a comment. > Thank you very much for the patch! Thank you for reviewing! Repository: rL LLVM https://reviews.llvm.org/D53974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

r346680 - [analyzer] Drastically simplify the tblgen files used for checkers

Author: szelethus Date: Mon Nov 12 09:49:51 2018 New Revision: 346680 URL: http://llvm.org/viewvc/llvm-project?rev=346680&view=rev Log: [analyzer] Drastically simplify the tblgen files used for checkers Interestingly, only about the quarter of the emitter file is used, the DescFile entry hasn't e

[PATCH] D53995: [analyzer] Drastically simplify the tblgen files used for checkers

This revision was automatically updated to reflect the committed changes. Closed by commit rL346680: [analyzer] Drastically simplify the tblgen files used for checkers (authored by Szelethus, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

riccibruno added a comment. @dblaikie Thanks for looking at this patch ! I have a set of patches shrinking the other statements/expressions. Can I add you to review some of these too ? Most of them consists of just moving some data. I added rsmith but I think that he is busy with the standard.

r346687 - [clang-format] Support breaking consecutive string literals for TableGen

Author: rupprecht Date: Mon Nov 12 10:15:04 2018 New Revision: 346687 URL: http://llvm.org/viewvc/llvm-project?rev=346687&view=rev Log: [clang-format] Support breaking consecutive string literals for TableGen Summary: clang-format can get confused by string literals in TableGen: it knows that st

[PATCH] D53952: [clang-format] Support breaking consecutive string literals for TableGen

This revision was automatically updated to reflect the committed changes. Closed by commit rC346687: [clang-format] Support breaking consecutive string literals for TableGen (authored by rupprecht, committed by ). Changed prior to commit: https://reviews.llvm.org/D53952?vs=172029&id=173711#toc

[PATCH] D46403: [CFI] Force LLVM to die if the implicit blacklist files cannot be found.

pcc added a comment. In https://reviews.llvm.org/D46403#1291697, @filcab wrote: > Sorry to ressurect this review, but I have a few questions: > > - What kind of functions fail? > - Are there bugzillas to track these? > - How can a compiler expect to have blacklists for "all" its CFI clients? > (

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett abandoned this revision. juliehockett added a comment. After a lot of discussion, we'll do this migration internally. Thanks for your comments! https://reviews.llvm.org/D54169 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54168: [clang-tidy] Zircon fbl::move -> std::move

juliehockett abandoned this revision. juliehockett added a comment. After a lot of discussion, we'll do this migration internally. Thanks for your comments! https://reviews.llvm.org/D54168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

  1   2   3   >