ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments.
================ Comment at: test/clang-tidy/clang-tidy-mac-libcxx.cpp:11 +// Pretend clang is installed beside the mock library that we provided. +// RUN: echo '[{"directory":"%t","command":"%t/mock-libcxx/bin/clang++ -stdlib=libc++ -target x86_64-apple-darwin -c test.cpp","file":"test.cpp"}]' | sed -e 's/\\/\//g' > %t/compile_commands.json +// RUN: cp "%s" "%t/test.cpp" ---------------- sammccall wrote: > ilya-biryukov wrote: > > sammccall wrote: > > > should this be `"command":"clang++"...` with clang++ on the PATH? > > Both the relative and the absolute path should work, but cmake produces > > absolute paths. Hence the test. > Is there a test for the other case? (In the clang repo rather than here is > fine) No, will add one in the clang repo. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54311 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits