riccibruno added a comment. @dblaikie Thanks for looking at this patch !
I have a set of patches shrinking the other statements/expressions. Can I add you to review some of these too ? Most of them consists of just moving some data. I added rsmith but I think that he is busy with the standard. ================ Comment at: include/clang/AST/Expr.h:1701 + for (auto c : getString()) + if (!isASCII(c)) return true; ---------------- They are not needed, I just could not resist. I can factor these changes out of this patch and submit it as an NFC. Repository: rC Clang https://reviews.llvm.org/D54166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits