[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas updated this revision to Diff 172486. ztamas marked an inline comment as done. ztamas added a comment. - Analyze template dependant for loops too (add some test cases) - Use double backticks for marking code in docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53974 Fi

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas marked 2 inline comments as done. ztamas added inline comments. Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:109 + +if (RHSE->isInstantiationDependent() || LHSE->isInstantiationDependent()) + return 0; Szelethus wrote: > You seem

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas updated this revision to Diff 172487. ztamas marked an inline comment as done. ztamas added a comment. Update docs based on reviewer comment Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53974 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMa

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas added a comment. In https://reviews.llvm.org/D53974#1285930, @Szelethus wrote: > In https://reviews.llvm.org/D53974#1283759, @ZaMaZaN4iK wrote: > > > Hmm, i thought Clang has some warning for this, but I was wrong... Did you > > think to implement this check as Clang warning? > > > That i

Re: [llvm-dev] mips builders on LLVM buildbot?

Hi Galina, I will try to find owners of these buildbots. I hope to get results on the next week. On Sat, Nov 3, 2018 at 1:48 AM Daniel Sanders wrote: > > Hi Galina, > > I'm sad that they appear to have been abandoned but no objections from me as > I'm not the admin for any of these anymore. A c

r346070 - Fix test on Windows.

Author: dyung Date: Sat Nov 3 01:51:27 2018 New Revision: 346070 URL: http://llvm.org/viewvc/llvm-project?rev=346070&view=rev Log: Fix test on Windows. This test checks the entire output of a help option, the problem is that on Windows, the line break occurs in a different place causing the CHEC

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

Szelethus added a comment. In https://reviews.llvm.org/D53974#1286434, @ztamas wrote: > In https://reviews.llvm.org/D53974#1285930, @Szelethus wrote: > > > In https://reviews.llvm.org/D53974#1283759, @ZaMaZaN4iK wrote: > > > > > Hmm, i thought Clang has some warning for this, but I was wrong... D

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

Romain-Geissler-1A created this revision. Romain-Geissler-1A added reviewers: rsmith, vsk, beanz. Herald added a subscriber: cfe-commits. Romain-Geissler-1A edited the summary of this revision. Hi, Current clang fail to bootstrap in PGO mode when only python3 is available, because perf-helper.py

[PATCH] D54061: [clang-tidy] run() doesn't update the SourceManager.

steveire added a comment. After this change, it seems that `ClangTidyCheck::check` is not needed and all callers should be ported to call `run()` instead (and the private `run()` declaration should be removed from `ClangTidyCheck`. Repository: rCTE Clang Tools Extra https://reviews.llvm.org

[PATCH] D54055: CXXNameMangler::mangleFunctionParam: fix assertion

rjmccall added a comment. In https://reviews.llvm.org/D54055#1286397, @jfb wrote: > In https://reviews.llvm.org/D54055#1286396, @rjmccall wrote: > > > That sounds more like this use of the mangler isn't manipulating the > > function type context correctly. But actually I think the problem is th

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

rjmccall added a comment. I'm just concerned about adding a great deal of complexity to mainline Clang in order to support a language that might still be in major flux and which I feel is likely to be forced to re-embrace qualifiers in the language model. Maybe this work should happen in a bra

[PATCH] D54055: CXXNameMangler::mangleFunctionParam: fix assertion

jfb added a comment. In https://reviews.llvm.org/D54055#1286514, @rjmccall wrote: > In https://reviews.llvm.org/D54055#1286397, @jfb wrote: > > > In https://reviews.llvm.org/D54055#1286396, @rjmccall wrote: > > > > > That sounds more like this use of the mangler isn't manipulating the > > > func

[PATCH] D54048: [AST] Get aliased type info from an aliased TemplateSpecialization.

rjmccall added a comment. Changing how `TemplateSpecializationType` is declared in `TypeNodes.def` has way more implications than you're giving it credit for. `FooType::desugar()` should always perform a single-step desugar, but on `TemplateSpecializationType` it's calling `getCanonicalTypeInte

[PATCH] D51268: [libc++] Implement P0487R1 - Fixing operator>>(basic_istream&, CharT*)

lichray updated this revision to Diff 172497. lichray added a comment. Herald added a subscriber: libcxx-commits. Rebased Repository: rCXX libc++ https://reviews.llvm.org/D51268 Files: include/istream test/std/input.output/iostream.format/input.streams/istream.formatted/istream_extracto

[PATCH] D54055: CXXNameMangler::mangleFunctionParam: fix assertion

rjmccall added a comment. Pfft, if I'm going to be held responsible for my own work, I'm in a lot of trouble. :) Function name + local variable name WFM. Repository: rC Clang https://reviews.llvm.org/D54055 ___ cfe-commits mailing list cfe-comm

[PATCH] D53780: Fix bitcast to address space cast for coerced load/stores

rjmccall added inline comments. Comment at: lib/CodeGen/CGCall.cpp:1257 + Address Casted = CGF.Builder.CreateBitCast(Tmp, CGF.Int8Ty->getPointerTo(Tmp.getAddressSpace())); + Address SrcCasted = CGF.Builder.CreateBitCast(Src, CGF.Int8Ty->getPointerTo(Src.getAddressSpace()));

[PATCH] D54075: [coroutines] Fix fallthrough warning on try/catch

modocache created this revision. modocache added reviewers: GorNishanov, tks2103, rsmith. Herald added a subscriber: EricWF. The test case added in this diff would incorrectly warn that control flow may fall through without returning. Here's a standalone example: https://godbolt.org/z/dCwXEi The

[PATCH] D54077: [clangd] Implemented DraftFileSystem

LutsenkoDanil created this revision. LutsenkoDanil added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric. Patch changes behavior of preamble building. If headers was changed in editor, preamble will be built with draft vers

[PATCH] D54048: [AST] Get aliased type info from an aliased TemplateSpecialization.

mattd updated this revision to Diff 172503. mattd added a comment. Thanks for the review @rjmccall. I have moved the type-alias check into TemplateSpecializationType's desugar method. I like this solution better. https://reviews.llvm.org/D54048 Files: include/clang/AST/Type.h test/SemaCX

[PATCH] D54075: [coroutines] Fix fallthrough warning on try/catch

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D54075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r346074 - [coroutines] Fix fallthrough warning on try/catch

Author: modocache Date: Sat Nov 3 15:35:17 2018 New Revision: 346074 URL: http://llvm.org/viewvc/llvm-project?rev=346074&view=rev Log: [coroutines] Fix fallthrough warning on try/catch Summary: The test case added in this diff would incorrectly warn that control flow may fall through without ret

[PATCH] D54075: [coroutines] Fix fallthrough warning on try/catch

modocache added a comment. Great, thanks! Repository: rC Clang https://reviews.llvm.org/D54075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54075: [coroutines] Fix fallthrough warning on try/catch

This revision was automatically updated to reflect the committed changes. Closed by commit rC346074: [coroutines] Fix fallthrough warning on try/catch (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D54075?vs=172498&id=172508#toc Repository: rC Clang

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 updated this revision to Diff 172509. https://reviews.llvm.org/D52835 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp test/Sema/ext_vector_casts.c test/Sema/impcast-integer-float.c Index: test/Sema/impcast-integer-float.c =

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

mcgrathr added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static"); ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs); MaskRay w

[PATCH] D54064: [Driver] Always match resource dir in Fuchsia driver tests

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D54064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[libclc] r346076 - r600: Convert get_global_size to clc

Author: jvesely Date: Sat Nov 3 17:35:08 2018 New Revision: 346076 URL: http://llvm.org/viewvc/llvm-project?rev=346076&view=rev Log: r600: Convert get_global_size to clc Signed-off-by: Jan Vesely Reviewer: Aaron Watry Added: libclc/trunk/r600/lib/workitem/get_global_size.cl Removed: li

[libclc] r346075 - r600: Convert get_local_size to clc

Author: jvesely Date: Sat Nov 3 17:35:03 2018 New Revision: 346075 URL: http://llvm.org/viewvc/llvm-project?rev=346075&view=rev Log: r600: Convert get_local_size to clc Signed-off-by: Jan Vesely Reviewer: Aaron Watry Added: libclc/trunk/r600/lib/workitem/get_local_size.cl Removed: libc

[libclc] r346078 - r600: Convert barrier to clc

Author: jvesely Date: Sat Nov 3 17:35:15 2018 New Revision: 346078 URL: http://llvm.org/viewvc/llvm-project?rev=346078&view=rev Log: r600: Convert barrier to clc Signed-off-by: Jan Vesely Reviewer: Aaron Watry Added: libclc/trunk/r600/lib/synchronization/barrier.cl Removed: libclc/trun

[libclc] r346077 - r600: Convert get_num_groups to clc

Author: jvesely Date: Sat Nov 3 17:35:12 2018 New Revision: 346077 URL: http://llvm.org/viewvc/llvm-project?rev=346077&view=rev Log: r600: Convert get_num_groups to clc Signed-off-by: Jan Vesely Reviewer: Aaron Watry Added: libclc/trunk/r600/lib/workitem/get_num_groups.cl Removed: libc

[libclc] r346080 - amdgcn: Convert get_global_size to clc

Author: jvesely Date: Sat Nov 3 17:39:20 2018 New Revision: 346080 URL: http://llvm.org/viewvc/llvm-project?rev=346080&view=rev Log: amdgcn: Convert get_global_size to clc Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Added: libclc/trunk/amdgcn/lib/workitem/get_global_size.cl Removed

[libclc] r346079 - amdgcn: Convert get_local_size to clc

Author: jvesely Date: Sat Nov 3 17:39:16 2018 New Revision: 346079 URL: http://llvm.org/viewvc/llvm-project?rev=346079&view=rev Log: amdgcn: Convert get_local_size to clc Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Added: libclc/trunk/amdgcn/lib/workitem/get_local_size.cl Removed:

[libclc] r346082 - amdgcn: Move __clc_amdgcn_s_waitcnt definition to clc file

Author: jvesely Date: Sat Nov 3 17:39:27 2018 New Revision: 346082 URL: http://llvm.org/viewvc/llvm-project?rev=346082&view=rev Log: amdgcn: Move __clc_amdgcn_s_waitcnt definition to clc file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/amdgcn/lib/mem_fence/wai

[libclc] r346083 - amdgcn-amdhsa: Convert get_{global, local}_size to clc for all llvm versions

Author: jvesely Date: Sat Nov 3 17:39:30 2018 New Revision: 346083 URL: http://llvm.org/viewvc/llvm-project?rev=346083&view=rev Log: amdgcn-amdhsa: Convert get_{global,local}_size to clc for all llvm versions Signed-off-by: Jan Vesely Acked-By: Aaron Watry Removed: libclc/trunk/amdgcn-amd

[libclc] r346081 - amdgcn: Convert get_num_groups to clc

Author: jvesely Date: Sat Nov 3 17:39:25 2018 New Revision: 346081 URL: http://llvm.org/viewvc/llvm-project?rev=346081&view=rev Log: amdgcn: Convert get_num_groups to clc Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Added: libclc/trunk/amdgcn/lib/workitem/get_num_groups.cl Removed:

[libclc] r346084 - travis: Check tahiti-amdgcn-mesa-mesa3d.bc

Author: jvesely Date: Sat Nov 3 17:54:43 2018 New Revision: 346084 URL: http://llvm.org/viewvc/llvm-project?rev=346084&view=rev Log: travis: Check tahiti-amdgcn-mesa-mesa3d.bc Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.tr

[libclc] r346085 - configure: Provide symlink for amdgcn-mesa3d instead of configure hack

Author: jvesely Date: Sat Nov 3 17:54:45 2018 New Revision: 346085 URL: http://llvm.org/viewvc/llvm-project?rev=346085&view=rev Log: configure: Provide symlink for amdgcn-mesa3d instead of configure hack Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Added: libclc/trunk/amdgcn-mesa3d

[libclc] r346086 - Remove redundant OVERRRIDES file

Author: jvesely Date: Sat Nov 3 17:54:46 2018 New Revision: 346086 URL: http://llvm.org/viewvc/llvm-project?rev=346086&view=rev Log: Remove redundant OVERRRIDES file Signed-off-by: Jan Vesely Reviewed-By: Aaron Watry Removed: libclc/trunk/amdgpu/lib/OVERRIDES Removed: libclc/trunk/amdgpu

[PATCH] D54048: [AST] Get aliased type info from an aliased TemplateSpecialization.

rjmccall added a comment. That looks a lot better, thanks. Did you check whether any other tests needed adjustment? That's not uncommon from this kind of desugaring change. If not, LGTM. https://reviews.llvm.org/D54048 ___ cfe-commits mailing li

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

mcgrathr reopened this revision. mcgrathr added inline comments. This revision is now accepted and ready to land. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static");

r346088 - [Driver] Always match resource dir in Fuchsia driver tests

Author: phosek Date: Sat Nov 3 20:53:07 2018 New Revision: 346088 URL: http://llvm.org/viewvc/llvm-project?rev=346088&view=rev Log: [Driver] Always match resource dir in Fuchsia driver tests This makes the tests stricter by not only matching the runtime file name, but the entire path into the re

[PATCH] D54064: [Driver] Always match resource dir in Fuchsia driver tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL346088: [Driver] Always match resource dir in Fuchsia driver tests (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54064?

[PATCH] D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a reviewer: EricWF. Herald added a subscriber: cfe-commits. -static relies on lld's behavior, but -Bstatic/dynamic across all linkers, -lm is only needed when statically linking libc++. Repository: rC Clang https://

[PATCH] D53854: [Driver] Use -push-/-pop-state and -as-needed for libc++ on Fuchsia

phosek closed this revision. phosek added inline comments. Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128 if (OnlyLibstdcxxStatic) - CmdArgs.push_back("-Bstatic"); + CmdArgs.push_back("-static"); ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);

[PATCH] D54082: [Driver] Use -Bstatic/dynamic for libc++ on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D54082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D44865: [libc++] Implement P0608R2 - A sane variant converting constructor

lichray updated this revision to Diff 172514. lichray added a comment. Herald added subscribers: libcxx-commits, ldionne. Updated implementation for https://reviews.llvm.org/source/clang/ Repository: rCXX libc++ https://reviews.llvm.org/D44865 Files: include/variant test/std/utilities/va