ztamas marked 2 inline comments as done.
ztamas added inline comments.

================
Comment at: clang-tidy/bugprone/TooSmallLoopVariableCheck.cpp:109
+
+    if (RHSE->isInstantiationDependent() || LHSE->isInstantiationDependent())
+      return 0;
----------------
Szelethus wrote:
> You seem to have code for handling templates, but I don't see test cases for 
> it.
Thanks for mentioning it. I was overdefensive against false positives. This 
isInstantiationDependent() is not needed here. So I removed and added some test 
cases with templates.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53974



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to