mcgrathr added inline comments.
================
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:128
if (OnlyLibstdcxxStatic)
- CmdArgs.push_back("-Bstatic");
+ CmdArgs.push_back("-static");
ToolChain.AddCXXStdlibLibArgs(Args, CmdArgs);
----------------
MaskRay wrote:
> If Fuchsia doesn't use gold, it is fine. gold diverges from ld.bfd (lld) in
> that `-static` switches the whole link to its special static mode. (as
> usually while you link libstdc++/libc++ statically, you can still link other
> libraries normally)
>
> In ld.bfd/lld, `-Bstatic` is synonym with `-static`.
I think this part of the change was unintentional and should be undone.
Using `--pop-state` obviates the need for `-Bdynamic` to undo `-Bstatic`, but
`-Bstatic` is still the right switch here.
Repository:
rC Clang
https://reviews.llvm.org/D53854
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
