void created this revision.
void added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Both compound literals and enums require their initializers to be
constant. Wrap the initializer expressions in a ConstantExpr so that we
can easily check for this later on.
Repository:
rC Clang
takuto.ikuta accepted this revision.
takuto.ikuta added a comment.
LGTM, thank you for fix!
https://reviews.llvm.org/D53870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: hans
Date: Wed Oct 31 01:38:48 2018
New Revision: 345699
URL: http://llvm.org/viewvc/llvm-project?rev=345699&view=rev
Log:
[clang-cl] Inherit dllexport to static locals also in template instantiations
(PR39496)
In the course of D51340, @takuto.ikuta discovered that Clang fails to put
dll
This revision was automatically updated to reflect the committed changes.
Closed by commit rC345699: [clang-cl] Inherit dllexport to static locals also
in template instantiations… (authored by hans, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D53870
Files:
include/clang/Se
devnexen created this revision.
devnexen added reviewers: kadircet, sammccall.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov, krytarowski.
There is no SCHED_IDLE semantic equivalent in BSD sy
hans added inline comments.
Comment at: test/CodeGenCXX/dllimport.cpp:1010
+int bar() { T t; return t.foo(); }
+// MO1-DAG: @"?x@?{{1|2}}??foo@?$T@H@pr39496@@Q{{[A-Z]*}}HXZ@4HA" =
available_externally dllimport global i32 0, align 4
+}
rnk wrote:
> I notice that
hans added inline comments.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5719
+ TSK != TSK_ExplicitInstantiationDeclaration &&
+ TSK != TSK_ExplicitInstantiationDefinition) {
+if (ClassExported) {
hans wrote:
> takuto.ikuta wrote:
> > hans
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks!
We should work out what to do on BSD+Mac (and windows at some point), but no-op
is good for now.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53922
___
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Looks sane to me, you might want someone more familiar with ObjC to verify
though.
Repository:
rC Clang
https://reviews.llvm.org/D53900
___
Author: devnexen
Date: Wed Oct 31 02:04:15 2018
New Revision: 345700
URL: http://llvm.org/viewvc/llvm-project?rev=345700&view=rev
Log:
[clangd] fix non linux build
There is no SCHED_IDLE semantic equivalent in BSD systems.
Reviewers: kadircet, sammccall
Revieweed By: sammccall
Differential Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345700: [clangd] fix non linux build (authored by devnexen,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53922?vs=171870&id=171873#toc
Rep
krytarowski added a comment.
For NetBSD:
- `ThreadPriority::Low` select either `SCHED_RR` or `SCHED_FIFO`, call
sched_get_priority_min() and set pthread_setschedparam().
- `ThreadPriority::Normal` use SCHED_OTHER with `PRI_NONE`.
Repository:
rL LLVM
https://reviews.llvm.org/D53922
__
kadircet added inline comments.
Comment at: clangd/index/SymbolCollector.cpp:619
+ shouldIndexFile(SM, SM.getFileID(Loc), Opts, &FilesToIndexCache);
+ if (auto DefLoc = getTokenLocation(Loc,
ND.getASTContext().getSourceManager(),
Opts, AST
ebevhan added a comment.
In https://reviews.llvm.org/D53738#1281332, @rjmccall wrote:
> Well, maybe the cleanest solution would be to actually fold
> `CompoundAssignOperator` back into `BinaryOperator` and just allow
> `BinaryOperator` to optionally store information about the intermediate type
sammccall added a comment.
In https://reviews.llvm.org/D53922#1281882, @krytarowski wrote:
> For NetBSD:
>
> - `ThreadPriority::Low` select either `SCHED_RR` or `SCHED_FIFO`, call
> sched_get_priority_min() and set pthread_setschedparam().
https://www.netbsd.org/docs/internals/en/chap-processe
krytarowski added a comment.
In https://reviews.llvm.org/D53922#1281898, @sammccall wrote:
> In https://reviews.llvm.org/D53922#1281882, @krytarowski wrote:
>
> > For NetBSD:
> >
> > - `ThreadPriority::Low` select either `SCHED_RR` or `SCHED_FIFO`, call
> > sched_get_priority_min() and set pthre
takuto.ikuta updated this revision to Diff 171877.
takuto.ikuta added a comment.
Rebased to take r345699
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Driver/C
takuto.ikuta added a comment.
Thank you for quick fix!
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
takuto.ikuta wrote:
> hans wrote:
>
hans added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
takuto.ikuta wrote:
> takuto.ikuta wrote:
> > hans wrote:
> > >
hjl.tools added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:2862
// place naturally.
- if (!isAggregateTypeForABI(Ty)) {
+ if (!isAggregateTypeForABI(Ty) && !IsIllegalVectorType(Ty)) {
// Treat an enum type as its underlying type.
Doesn't -m
devnexen added a comment.
I thought applying this sort of change for BSD but SCHED_IDLE is a GNU
extension and does not have equivalence per see.
Repository:
rL LLVM
https://reviews.llvm.org/D53922
___
cfe-commits mailing list
cfe-commits@lists.
sammccall added a comment.
In https://reviews.llvm.org/D53922#1281902, @krytarowski wrote:
> In https://reviews.llvm.org/D53922#1281898, @sammccall wrote:
>
> > In https://reviews.llvm.org/D53922#1281882, @krytarowski wrote:
> >
> > > For NetBSD:
> > >
> > > - `ThreadPriority::Low` select either
hans added a comment.
Bah, I should have known something was going to break if I touched this :-)
http://lab.llvm.org:8011/builders/sanitizer-windows/builds/37132
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/1017
Here's a repro:
template struct __declspec(dllimport) S {
ilya-biryukov added a comment.
Mostly NITs
Comment at: lib/Sema/SemaCodeComplete.cpp:5136
+ auto AddDefaultCtorInit = [&](const char *TypedName,
+const char *TypeName,
+const NamedDecl* ND) {
kadi
Author: hans
Date: Wed Oct 31 03:34:46 2018
New Revision: 345709
URL: http://llvm.org/viewvc/llvm-project?rev=345709&view=rev
Log:
Follow-up to r345699: Call CheckStaticLocalForDllExport later for templates
Calling it too early might cause dllimport to get inherited onto the
VarDecl before the in
hans added a comment.
r345709 should do it.
Repository:
rC Clang
https://reviews.llvm.org/D53870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
takuto.ikuta added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
hans wrote:
> takuto.ikuta wrote:
> > takuto.ikuta wrote
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, bruno.
Herald added a subscriber: cfe-commits.
If the ABI supports inline key functions we must emit them eagerly. The generic
reason is that CodeGen might assume they are emitted and generate a reference
to the vtable. In
ilya-biryukov added a comment.
Why does resetting the conditional stack is the right thing to do here?
I can see how it can hide the problem, but can't come up with with a consistent
model to handle the fact that the file contents were trimmed.
Failing to build the preamble in that case seems li
v.g.vassilev added a comment.
@rsmith, @bruno could you verify this patch on your codebases?
Repository:
rC Clang
https://reviews.llvm.org/D53925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
lebedev.ri added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D52695
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
In https://reviews.llvm.org/D53457#1279191, @neerajksingh wrote:
> In https://reviews.llvm.org/D53457#1278579, @hans wrote:
>
> > The `-Xclang` option has the same issue, and I think `/clang:` should work
> > similarly, i.e. `/clang:-MF /clang:`. It's not pretty, but at
>
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
This avoids duplicated scopes in the query e.g. when anonymous namespace
is present.
Repository:
rCTE Clang Tools Extra
https://review
Anastasia added a comment.
FYI, I have created a bug to the OpenCL C++ spec:
https://github.com/KhronosGroup/OpenCL-Docs/issues/13.
Gladly, we now moved into discussing the issues publicly. So anyone can create
bugs and also participate in discussions.
I would like to feed all of the suggestio
steleman created this revision.
steleman added a reviewer: joel_k_jones.
Herald added subscribers: kristina, kristof.beyls, javed.absar.
This changeset adds the required Builtins for enabling AArch64 vectorization of
libm trigonometry functions via SLEEF: http://sleef.org/.
- A new argument is a
nik added a comment.
In https://reviews.llvm.org/D53866#1281978, @ilya-biryukov wrote:
> Why does resetting the conditional stack is the right thing to do here?
Because this case can be detected and handled without loosing the benefits of
the preamble.
> Failing to build the preamble in that
krytarowski added a comment.
In https://reviews.llvm.org/D53922#1281914, @sammccall wrote:
> Thanks. I was replying to your suggestion for NetBSD though - my reading of
> the docs says your "low" suggestion would end up being a very high priority.
> Is this not the case? Can you suggest a bette
alexfh added inline comments.
Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:30
+ if (const NamedDecl *AN = Node.getAliasedNamespace()) {
+// If this aliases to an actual namespace, check if its std.
+if (const auto *N = dyn_cast(AN))
---
ymandel updated this revision to Diff 171897.
ymandel marked 2 inline comments as done.
ymandel added a comment.
Small tweaks in response to comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Co
ymandel added a comment.
In https://reviews.llvm.org/D53025#1281097, @aaron.ballman wrote:
> I think this is getting really close! One question: would it make more sense
> to name this `readability-const-type-return` or
> `readability-const-return-type` instead? It's not that the functions retu
kadircet updated this revision to Diff 171899.
kadircet marked 8 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/ctor-initializer.cpp
test/Index/complete
ymandel updated this revision to Diff 171900.
ymandel added a comment.
Rename readability-const-value-return to readability-const-return-type
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ConstReturn
ymandel added a comment.
I've renamed the check. I noticed that the script did not rename the header
guard macro, though. Please let me know if/where to file a bug.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
___
cfe-comm
kadircet added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:5136
+ auto AddDefaultCtorInit = [&](const char *TypedName,
+const char *TypeName,
+const NamedDecl* ND) {
ilya-biryukov wro
Author: sammccall
Date: Wed Oct 31 06:08:19 2018
New Revision: 345716
URL: http://llvm.org/viewvc/llvm-project?rev=345716&view=rev
Log:
[clang-tidy] Remove false decoupling in ClangTidyContext. NFC
These getters/setters don't encapsulate any behavior, and can only be
called by friends.
Modified:
ioeric updated this revision to Diff 171901.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- Merged with multi-threading changes. Added mutex for file digests.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53433
Files:
clangd/index/Background.cpp
clangd/
ioeric added a comment.
Made some more changes to make the code work in multiple threads (add mutex for
digests, take snapshot of digests for each run etc). PTAL
Comment at: clangd/index/Background.cpp:311
SPAN_ATTACH(Tracer, "refs", int(Refs.numRefs()));
- // FIXME: parti
hans added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
takuto.ikuta wrote:
> hans wrote:
> > takuto.ikuta wrote:
> > >
xbolva00 updated this revision to Diff 171906.
https://reviews.llvm.org/D53666
Files:
lib/CodeGen/SelectionDAG/DAGCombiner.cpp
test/CodeGen/X86/combine-sdiv.ll
test/CodeGen/X86/combine-srem.ll
test/CodeGen/X86/combine-udiv.ll
test/CodeGen/X86/combine-urem.ll
Index: test/CodeGen/X86/com
JonasToth added inline comments.
Comment at: clang-tools-extra/docs/ReleaseNotes.rst:176
+
+ Warns when the `std` namespace is used, as its use is against Zircon's libc++
+ policy for the kernel.
alexfh wrote:
> JonasToth wrote:
> > s/its/it's/
> >
> > Could `
xbolva00 updated this revision to Diff 171908.
https://reviews.llvm.org/D53666
Files:
test/CodeGen/tbaa-struct.cpp
Index: test/CodeGen/tbaa-struct.cpp
===
--- test/CodeGen/tbaa-struct.cpp
+++ test/CodeGen/tbaa-struct.cpp
@@ -17,7
JonasToth added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:107
+diag(Def->getInnerLocStart(), "return type %0 is 'const'-qualified "
+ "hindering compiler optimizations")
+<< Def->getReturnTyp
JonasToth marked an inline comment as done.
JonasToth added inline comments.
Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:119
+ const LangOptions &LangOpts) {
+ std::size_t DeclCount = std::distance(DS->decl_begin(), DS->decl_end());
+ if (DeclCount
martong added a comment.
Hi Davide,
I'd like to draw your attention to an important relation of this patch to a bug
in LLDB which manifests as incorrect vtable layouts for LLDB expression code.
Please see the conversation started with this message:
https://lists.llvm.org/pipermail/cfe-dev/2018-
xazax.hun accepted this revision.
xazax.hun added a comment.
LGTM! Thanks, I think it is much easier to understand what is going on this way.
https://reviews.llvm.org/D52742
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
a.sidorin added a comment.
Hello everyone.
@martong : this version of patch reorders only fields and friends. No method
reordering is done (I can check if it works, though, and add the feature).
@davide: Unfortunately, I was not able to reproduce the problem on Linux. Could
you please provide a
xazax.hun added a comment.
Please add a test case where a bug path goes through a macro definition and
this macro is undefed at the end of the translation unit.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:667
+
+//===---
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
This LGTM, thank you for working on this check!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53025
___
cfe-commi
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53933
Files:
clangd/FindSymbols.cpp
clangd/index/Index.h
clangd/inde
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: docs/clang-tidy/checks/readability-isolate-declaration.rst:45
+
+Global variables and member variables are excluded.
+
JonasT
takuto.ikuta updated this revision to Diff 171916.
takuto.ikuta added a comment.
export/import explicit template instantiation function
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
takuto.ikuta marked an inline comment as done.
takuto.ikuta added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:9552
+// overwrite linkage of explicit template instantiation
+// definition/declaration.
+return GVA_DiscardableODR;
hans wrot
Also, don't we usually put ABI changes under an ABI compatibility check? This
would be making Clang incompatible with itself.
--paulr
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
Richard Trieu via cfe-commits
Sent: Tuesday, October 30, 2018 10:16 PM
To: Reid Kleckn
aaron.ballman added a comment.
I am a bit confused by what this check is trying to accomplish. It seems like
this is intended to catch use of anything declared within the standard library,
but that includes library support things that are needed to write useful code.
For instance, it seems this
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
Anonymou
ioeric added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
ilya-biryukov w
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:471
+DisplayMacroExpansions =
+getBooleanOption("expand-macros", /*Default=*/false);
+ return DisplayMacroExpansions.getValue();
-
ilya-biryukov added a comment.
> Because this case can be detected and handled without loosing the benefits of
> the preamble.
The cases where recursive includes make sense are incredibly rare in practice.
Most of the time, recursively including the same file is unintentional should
be conside
xbolva00 updated this revision to Diff 171920.
xbolva00 added a reviewer: MTC.
xbolva00 added a comment.
- New warning text, added another test line
https://reviews.llvm.org/D52949
Files:
include/clang/Basic/DiagnosticGroups.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaExpr.
Author: szelethus
Date: Wed Oct 31 07:54:27 2018
New Revision: 345724
URL: http://llvm.org/viewvc/llvm-project?rev=345724&view=rev
Log:
[analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag
This is the first part of the implementation of the inclusion of macro
expansions into the plist
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345724: [analyzer][PlistMacroExpansion] Part 1.: New
expand-macros flag (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org
dgoldman created this revision.
dgoldman added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous,
MaskRay, ioeric, ilya-biryukov.
Previously code completion did not work well for Objective-C methods
which contained multiple arguments as clangd did not
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaCodeComplete.cpp:176
public:
+void AddConstructorResults(const CXXRecordDecl *Record, Result R);
+
AddConstructorResults is not defined and not used. Remove it?
Repository:
rC Clang
https:/
xbolva00 added a comment.
Ping
Anything else to be done here? I would like to finish this patch to work on
other things.
https://reviews.llvm.org/D52835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:563
for (auto *Context : CCContext.getVisitedContexts()) {
- if (isa(Context))
+ if (isa(Context)) {
Info.AccessibleScopes.push_back(""); // global namespace
ioeric w
davide added a comment.
No worries :) l
In https://reviews.llvm.org/D44100#1282148, @martong wrote:
> Hi Davide,
>
> I'd like to draw your attention to an important relation of this patch to a
> bug in LLDB which manifests as incorrect vtable layouts for LLDB expression
> code.
> Please see t
ioeric updated this revision to Diff 171924.
ioeric added a comment.
- Clarify documentation for printNamespaceScope
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
Files:
clangd/AST.h
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/
davide added a comment.
In https://reviews.llvm.org/D44100#1282157, @a.sidorin wrote:
> Hello everyone.
> @martong : this version of patch reorders only fields and friends. No method
> reordering is done (I can check if it works, though, and add the feature).
> @davide: Unfortunately, I was no
kadircet updated this revision to Diff 171926.
kadircet added a comment.
- Revert back declaration.
Repository:
rC Clang
https://reviews.llvm.org/D53654
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/ctor-initializer.cpp
test/Index/complete-ctor-inits.cpp
test/Index/complet
astrelni updated this revision to Diff 171925.
astrelni marked 9 inline comments as done.
astrelni added a comment.
Thanks for the feedback so far.
Reply to review comments.
- Improve comments.
- Fix matcher to check for invalid source range.
- Improve test coverage for templates and macros.
h
ioeric updated this revision to Diff 171928.
ioeric added a comment.
- revert wrong comment
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
Files:
clangd/AST.h
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
Index: unittests/clangd/CodeCompleteTests.
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, ioeric,
ilya-biryukov, krytarowski.
Since llvm/Config/config.h is not available on standalone builds,
use __USE_POSIX instead of HAVE_PTHREAD_H and get rid of the i
astrelni marked an inline comment as done.
astrelni added inline comments.
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:118
+AST_MATCHER_P(Expr, hasSourceRange, SourceRange, Range) {
+ return Node.getSourceRange() == Range;
+}
JonasToth wrot
ioeric planned changes to this revision.
ioeric added a comment.
I got the behavior of `printNamespaceScope` wrong in this patch. Will update.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53926
___
cfe-commits mailing list
cfe-com
lebedev.ri added a comment.
How does this play with `LLVM_ENABLE_THREADS` cmake option?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Threading.cpp:7
#include
-#ifdef HAVE_PTHREAD_H
+#if defined(__USE_POSIX)
#include
nit: just ifdef?
Repository:
rCTE Cla
sammccall added inline comments.
Comment at: clangd/Threading.cpp:104
void setThreadPriority(std::thread &T, ThreadPriority Priority) {
-#if defined(HAVE_PTHREAD_H) && defined(__linux__)
+#if defined(__USE_POSIX) && defined(__linux__)
sched_param priority;
th
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the change!
Repository:
rC Clang
https://reviews.llvm.org/D53654
___
cfe-commits mailing list
cfe-commits@lists
kadircet updated this revision to Diff 171931.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53935
Files:
clangd/Threading.cpp
Index: clangd/Threading.cpp
=
sammccall added a comment.
In https://reviews.llvm.org/D53935#1282303, @lebedev.ri wrote:
> How does this play with `LLVM_ENABLE_THREADS` cmake option?
Clangd doesn't support/respect that, and I don't think anyone's building in
that configuration.
If this causes actual problems e.g. with bots,
oleg.smolsky marked 2 inline comments as done.
oleg.smolsky added inline comments.
Comment at: unittests/Format/FormatTest.cpp:11854
+ // case above.
+ {
+auto Style = getGoogleStyle();
djasper wrote:
> No need to use a scope here. Feel free to redefine Sty
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE345729: Delete dependency on config.h (authored by
kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53935?vs=171931&id=171933#toc
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345729: Delete dependency on config.h (authored by kadircet,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53935
Files:
clang-tools-extra/tru
Author: kadircet
Date: Wed Oct 31 08:37:09 2018
New Revision: 345729
URL: http://llvm.org/viewvc/llvm-project?rev=345729&view=rev
Log:
Delete dependency on config.h
Summary:
Since llvm/Config/config.h is not available on standalone builds,
use __USE_POSIX instead of HAVE_PTHREAD_H and get rid of
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, xazax.hun.
This codifies the mostly-current state:
- The stuff in ClangTidy.h is reasonable for checks to depend on.
- The stuff in ClangTidyDiagnosticConsumer.h is a mish-mash of clang-tid
krasimir added a comment.
Looks good! Will stamp when the scopes are removed. Oleg, do you need someone
to commit this for you?
Repository:
rC Clang
https://reviews.llvm.org/D52676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
oleg.smolsky updated this revision to Diff 171932.
oleg.smolsky marked 2 inline comments as done.
Repository:
rC Clang
https://reviews.llvm.org/D52676
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotator.cpp
lib/Format/UnwrappedLineFormatter.cpp
scott.linder updated this revision to Diff 171936.
scott.linder added a comment.
Rebase
@klimek is there anyone I should add to take a look at this? As far as the YAML
is concerned I believe this is a non-functional change.
https://reviews.llvm.org/D51223
Files:
unittests/Tooling/Diagnostic
oleg.smolsky added a comment.
In https://reviews.llvm.org/D52676#1282335, @krasimir wrote:
> Looks good! Will stamp when the scopes are removed.
Cool, thanks, Krasimir. I've just posted the updated patch.
> Oleg, do you need someone to commit this for you?
I do, could you commit this please?
sammccall updated this revision to Diff 171937.
sammccall added a comment.
Add FIXME to fuchsia check that uses private APIs.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53936
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/ClangTidyDiagnosticConsumer
1 - 100 of 287 matches
Mail list logo
