[PATCH] D53926: [clangd] Only add global scope to completion query scopes for TU context.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/CodeComplete.cpp:563
     for (auto *Context : CCContext.getVisitedContexts()) {
-      if (isa<TranslationUnitDecl>(Context))
+      if (isa<TranslationUnitDecl>(Context)) {
         Info.AccessibleScopes.push_back(""); // global namespace
----------------
Anonymous namespace inside other namespaces will also produce duplicate scopes.
Maybe simply remove the duplicates from the vector before we return it?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53926



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits