oleg.smolsky marked 2 inline comments as done.
oleg.smolsky added inline comments.


================
Comment at: unittests/Format/FormatTest.cpp:11854
+  // case above.
+  {
+    auto Style = getGoogleStyle();
----------------
djasper wrote:
> No need to use a scope here. Feel free to redefine Style.
> 
> If in fact you feel like that is getting out of hand, maybe extract a 
> separate TEST_F() for this.
OK, sure, removed the scoped block.


================
Comment at: unittests/Format/FormatTest.cpp:11865
+  }
+  {
+    verifyFormat("SomeFunction(\n"
----------------
djasper wrote:
> No need for this scope.
Oh, right, that's vestigial. Removed.


Repository:
  rC Clang

https://reviews.llvm.org/D52676



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to